Skip to content

Conversation

@hari-kummari
Copy link

@hari-kummari hari-kummari commented Sep 12, 2025

Tested changes and no failure observed.


Progress

  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue
  • JDK-8364263 needs maintainer approval

Issue

  • JDK-8364263: HttpClient: Improve encapsulation of ProxyServer (Enhancement - P4 - Approved)

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk25u.git pull/188/head:pull/188
$ git checkout pull/188

Update a local copy of the PR:
$ git checkout pull/188
$ git pull https://git.openjdk.org/jdk25u.git pull/188/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 188

View PR using the GUI difftool:
$ git pr show -t 188

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk25u/pull/188.diff

Using Webrev

Link to Webrev Comment

@bridgekeeper
Copy link

bridgekeeper bot commented Sep 12, 2025

👋 Welcome back hkummari! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk
Copy link

openjdk bot commented Sep 12, 2025

@hari-kummari This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8364263: HttpClient: Improve encapsulation of ProxyServer

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 2 new commits pushed to the master branch:

  • 9669816: 8367137: RISC-V: Detect Zicboz block size via hwprobe
  • 4ad231a: 8367066: RISC-V: refine register selection in MacroAssembler:: decode_klass_not_null

Please see this link for an up-to-date comparison between the source branch of this pull request and the master branch.
As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

As you do not have Committer status in this project an existing Committer must agree to sponsor your change.

➡️ To flag this PR as ready for integration with the above commit message, type /integrate in a new comment. (Afterwards, your sponsor types /sponsor in a new comment to perform the integration).

@openjdk openjdk bot changed the title backport 190e113031bc6ece781fdf0d9f3c853ce324f170 8364263: HttpClient: Improve encapsulation of ProxyServer Sep 12, 2025
@openjdk
Copy link

openjdk bot commented Sep 12, 2025

This backport pull request has now been updated with issue from the original commit.

@openjdk openjdk bot added backport Port of a pull request already in a different code base clean Identical backport; no merge resolution required labels Sep 12, 2025
@openjdk
Copy link

openjdk bot commented Sep 12, 2025

⚠️ @hari-kummari This change is now ready for you to apply for maintainer approval. This can be done directly in each associated issue or by using the /approval command.

@openjdk openjdk bot added the rfr Pull request is ready for review label Sep 12, 2025
@hari-kummari
Copy link
Author

/approval request

@mlbridge
Copy link

mlbridge bot commented Sep 12, 2025

Webrevs

@openjdk
Copy link

openjdk bot commented Sep 12, 2025

@hari-kummari
8364263: The approval request has been created successfully.

@openjdk openjdk bot added approval Requires approval; will be removed when approval is received ready Pull request is ready to be integrated and removed approval Requires approval; will be removed when approval is received labels Sep 12, 2025
@hari-kummari
Copy link
Author

/integrate

@openjdk openjdk bot added the sponsor Pull request is ready to be sponsored label Sep 15, 2025
@openjdk
Copy link

openjdk bot commented Sep 15, 2025

@hari-kummari
Your change (at version 7e6e5f3) is now ready to be sponsored by a Committer.

@shipilev
Copy link
Member

/sponsor

@openjdk
Copy link

openjdk bot commented Sep 15, 2025

Going to push as commit 1173f8e.
Since your change was applied there have been 2 commits pushed to the master branch:

  • 9669816: 8367137: RISC-V: Detect Zicboz block size via hwprobe
  • 4ad231a: 8367066: RISC-V: refine register selection in MacroAssembler:: decode_klass_not_null

Your commit was automatically rebased without conflicts.

@openjdk openjdk bot added the integrated Pull request has been integrated label Sep 15, 2025
@openjdk openjdk bot closed this Sep 15, 2025
@openjdk openjdk bot removed ready Pull request is ready to be integrated rfr Pull request is ready for review sponsor Pull request is ready to be sponsored labels Sep 15, 2025
@openjdk
Copy link

openjdk bot commented Sep 15, 2025

@shipilev @hari-kummari Pushed as commit 1173f8e.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

backport Port of a pull request already in a different code base clean Identical backport; no merge resolution required integrated Pull request has been integrated

Development

Successfully merging this pull request may close these issues.

2 participants