8365790: Shutdown hook for application image does not work on Windows

[alexeysemenyukoracle]

Backport of https://git.openjdk.org/jdk/pull/27264 PR

Clean implementation backport.

Manual merge of test sources: test/jdk/tools/jpackage/helpers/jdk/jpackage/test/TKit.java, and test/jdk/tools/jpackage/helpers/jdk/jpackage/test/PackageTest.java.

---

Progress

• Change must be properly reviewed (1 review required, with at least 1 Reviewer)
• Change must not contain extraneous whitespace
• Commit message must refer to an issue
• JDK-8365790 needs maintainer approval

Issue

• JDK-8365790: Shutdown hook for application image does not work on Windows (Bug - P3 - Approved)

Reviewers

• Alexander Matveev (@sashamatveev - no project role)
• Alexey Ivanov (@aivanov-jdk - Reviewer)

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk25u.git pull/210/head:pull/210
$ git checkout pull/210

Update a local copy of the PR:
$ git checkout pull/210
$ git pull https://git.openjdk.org/jdk25u.git pull/210/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 210

View PR using the GUI difftool:
$ git pr show -t 210

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk25u/pull/210.diff

Using Webrev

Link to Webrev Comment

[bridgekeeper]

👋 Welcome back asemenyuk! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

[openjdk]

@alexeysemenyukoracle This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8365790: Shutdown hook for application image does not work on Windows

Reviewed-by: almatvee, aivanov

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 8 new commits pushed to the master branch:

• 9f2d753: 8367689: Revert removal of several compilation-related vmStructs fields
• d998196: 8367378: GenShen: Missing timing stats when old mark buffers are flushed during final update refs
• d8b2de8: 8367348: Enhance PassFailJFrame to support links in HTML
• ... and 5 more: https://git.openjdk.org/jdk25u/compare/b2484b5e2d8177c3b84511b47caf889fcbb3bc81...master

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

As you do not have Committer status in this project an existing Committer must agree to sponsor your change. Possible candidates are the reviewers of this PR (@aivanov-jdk) but any other Committer may sponsor as well.

➡️ To flag this PR as ready for integration with the above commit message, type /integrate in a new comment. (Afterwards, your sponsor types /sponsor in a new comment to perform the integration).

[openjdk]

This backport pull request has now been updated with issue from the original commit.

[mlbridge]

Webrevs

• 00: Full (392ca46a)

[alexeysemenyukoracle]

@sashamatveev please review

[alexeysemenyukoracle]

@aivanov-jdk @prrace could you please help out with the review

@sashamatveev is usually doing jpackage reviews in the mainline, but he doesn't have the reviewer role in jdk25u project.

[sashamatveev]

Looks good.

[aivanov-jdk]

Looks good.

[openjdk]

⚠️ @alexeysemenyukoracle This change is now ready for you to apply for maintainer approval. This can be done directly in each associated issue or by using the /approval command.

[aivanov-jdk]

@alexeysemenyukoracle Request maintainer approval, see JDK Updates: Requesting push approval for fixes and/or Requesting approvals for backports in OpenJDK Developers’ Guide.

[alexeysemenyukoracle]

/approval request

[openjdk]

@alexeysemenyukoracle
8365790: The approval request has been created successfully.

[alexeysemenyukoracle]

/integrate

[openjdk]

@alexeysemenyukoracle
Your change (at version 392ca46) is now ready to be sponsored by a Committer.

[aivanov-jdk]

/sponsor

[openjdk]

Going to push as commit 8b686d9.
Since your change was applied there have been 9 commits pushed to the master branch:

• 1a69c6b: 8358532: JFileChooser in GTK L&F still displays HTML filename
• 9f2d753: 8367689: Revert removal of several compilation-related vmStructs fields
• d998196: 8367378: GenShen: Missing timing stats when old mark buffers are flushed during final update refs
• ... and 6 more: https://git.openjdk.org/jdk25u/compare/b2484b5e2d8177c3b84511b47caf889fcbb3bc81...master

Your commit was automatically rebased without conflicts.

[openjdk]

@aivanov-jdk @alexeysemenyukoracle Pushed as commit 8b686d9.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.