8359423: Improve error message in case of missing jsa shared archive#226
8359423: Improve error message in case of missing jsa shared archive#226MBaesken wants to merge 1 commit intoopenjdk:masterfrom
Conversation
|
👋 Welcome back mbaesken! A progress list of the required criteria for merging this PR into |
|
@MBaesken This change now passes all automated pre-integration checks. ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details. After integration, the commit message for the final commit will be: You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed. At the time when this comment was updated there had been 24 new commits pushed to the
As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details. ➡️ To integrate this PR with the above commit message to the |
|
This backport pull request has now been updated with issue from the original commit. |
|
Strange, the backport is clean but this is not shown in this PR !? |
RealCLanger
left a comment
There was a problem hiding this comment.
Not sure why the backport isn't marked clean but it looks like upstream. Should be good 😄
|
Thanks for the review! /integrate |
|
Going to push as commit 87c8c19.
Your commit was automatically rebased without conflicts. |
Backport of 8359423
Progress
Issue
Reviewers
Reviewing
Using
gitCheckout this PR locally:
$ git fetch https://git.openjdk.org/jdk25u.git pull/226/head:pull/226$ git checkout pull/226Update a local copy of the PR:
$ git checkout pull/226$ git pull https://git.openjdk.org/jdk25u.git pull/226/headUsing Skara CLI tools
Checkout this PR locally:
$ git pr checkout 226View PR using the GUI difftool:
$ git pr show -t 226Using diff file
Download this PR as a diff file:
https://git.openjdk.org/jdk25u/pull/226.diff
Using Webrev
Link to Webrev Comment