-
Notifications
You must be signed in to change notification settings - Fork 117
8368308: ISO 4217 Amendment 180 Update #240
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
👋 Welcome back kfarrell! A progress list of the required criteria for merging this PR into |
|
@kieran-farrell This change now passes all automated pre-integration checks. ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details. After integration, the commit message for the final commit will be: You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed. At the time when this comment was updated there had been 311 new commits pushed to the
As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details. As you do not have Committer status in this project an existing Committer must agree to sponsor your change. Possible candidates are the reviewers of this PR (@naotoj) but any other Committer may sponsor as well. ➡️ To flag this PR as ready for integration with the above commit message, type |
|
This backport pull request has now been updated with issue from the original commit. |
|
|
|
/approval |
|
@kieran-farrell usage: |
|
/approval 8368308 request |
|
@kieran-farrell |
|
/integrate |
|
@kieran-farrell |
|
/sponsor |
|
Going to push as commit 3f9c665.
Your commit was automatically rebased without conflicts. |
|
@naotoj @kieran-farrell Pushed as commit 3f9c665. 💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored. |
Clean backport
Progress
Issue
Reviewers
Reviewing
Using
gitCheckout this PR locally:
$ git fetch https://git.openjdk.org/jdk25u.git pull/240/head:pull/240$ git checkout pull/240Update a local copy of the PR:
$ git checkout pull/240$ git pull https://git.openjdk.org/jdk25u.git pull/240/headUsing Skara CLI tools
Checkout this PR locally:
$ git pr checkout 240View PR using the GUI difftool:
$ git pr show -t 240Using diff file
Download this PR as a diff file:
https://git.openjdk.org/jdk25u/pull/240.diff
Using Webrev
Link to Webrev Comment