Skip to content

Conversation

@kieran-farrell
Copy link

@kieran-farrell kieran-farrell commented Sep 24, 2025

Clean backport


Progress

  • JDK-8368308 needs maintainer approval
  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue

Issue

  • JDK-8368308: ISO 4217 Amendment 180 Update (Bug - P3 - Approved)

Reviewers

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk25u.git pull/240/head:pull/240
$ git checkout pull/240

Update a local copy of the PR:
$ git checkout pull/240
$ git pull https://git.openjdk.org/jdk25u.git pull/240/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 240

View PR using the GUI difftool:
$ git pr show -t 240

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk25u/pull/240.diff

Using Webrev

Link to Webrev Comment

@bridgekeeper
Copy link

bridgekeeper bot commented Sep 24, 2025

👋 Welcome back kfarrell! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk
Copy link

openjdk bot commented Sep 24, 2025

@kieran-farrell This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8368308: ISO 4217 Amendment 180 Update

Reviewed-by: naoto, jlu

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 311 new commits pushed to the master branch:

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

As you do not have Committer status in this project an existing Committer must agree to sponsor your change. Possible candidates are the reviewers of this PR (@naotoj) but any other Committer may sponsor as well.

➡️ To flag this PR as ready for integration with the above commit message, type /integrate in a new comment. (Afterwards, your sponsor types /sponsor in a new comment to perform the integration).

@openjdk openjdk bot changed the title Backport 85f5bf3f415cc3d44d1618ec574e73f846bb91c4 8368308: ISO 4217 Amendment 180 Update Sep 24, 2025
@openjdk
Copy link

openjdk bot commented Sep 24, 2025

This backport pull request has now been updated with issue from the original commit.

@openjdk openjdk bot added backport Port of a pull request already in a different code base clean Identical backport; no merge resolution required labels Sep 24, 2025
@openjdk
Copy link

openjdk bot commented Sep 24, 2025

⚠️ @kieran-farrell This change is now ready for you to apply for maintainer approval. This can be done directly in each associated issue or by using the /approval command.

@openjdk openjdk bot added the rfr Pull request is ready for review label Sep 24, 2025
@mlbridge
Copy link

mlbridge bot commented Sep 24, 2025

Webrevs

@kieran-farrell
Copy link
Author

/approval

@openjdk
Copy link

openjdk bot commented Sep 24, 2025

@kieran-farrell usage: /approval [<id>] (request|cancel) [<text>]

@kieran-farrell
Copy link
Author

/approval 8368308 request

@openjdk
Copy link

openjdk bot commented Sep 24, 2025

@kieran-farrell
8368308: The approval request has been created successfully.

@openjdk openjdk bot added the approval Requires approval; will be removed when approval is received label Sep 24, 2025
@openjdk openjdk bot added ready Pull request is ready to be integrated and removed approval Requires approval; will be removed when approval is received labels Sep 24, 2025
@kieran-farrell
Copy link
Author

/integrate

@openjdk openjdk bot added the sponsor Pull request is ready to be sponsored label Sep 24, 2025
@openjdk
Copy link

openjdk bot commented Sep 24, 2025

@kieran-farrell
Your change (at version ca4a000) is now ready to be sponsored by a Committer.

@naotoj
Copy link
Member

naotoj commented Sep 24, 2025

/sponsor

@openjdk
Copy link

openjdk bot commented Sep 24, 2025

Going to push as commit 3f9c665.
Since your change was applied there have been 311 commits pushed to the master branch:

Your commit was automatically rebased without conflicts.

@openjdk openjdk bot added the integrated Pull request has been integrated label Sep 24, 2025
@openjdk openjdk bot closed this Sep 24, 2025
@openjdk openjdk bot removed ready Pull request is ready to be integrated rfr Pull request is ready for review sponsor Pull request is ready to be sponsored labels Sep 24, 2025
@openjdk
Copy link

openjdk bot commented Sep 24, 2025

@naotoj @kieran-farrell Pushed as commit 3f9c665.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

backport Port of a pull request already in a different code base clean Identical backport; no merge resolution required integrated Pull request has been integrated

Development

Successfully merging this pull request may close these issues.

3 participants