8367333: C2: Vector math operation intrinsification failure

[shipilev]

Avoids the fatal VM crash when using Vector code. Fixes recent regression in JDK 25.

Additional testing:

• New test fails (crashes VM) without the fix in both release and fastdebug modes, works with the fix
• Linux x86_64 server fastdebug, all

---

Progress

• Change must be properly reviewed (1 review required, with at least 1 Reviewer)
• Change must not contain extraneous whitespace
• JDK-8367333 needs maintainer approval
• JDK-8367969 needs maintainer approval
• Commit message must refer to an issue

Issues

• JDK-8367333: C2: Vector math operation intrinsification failure (Bug - P3 - Approved)
• JDK-8367969: C2: compiler/vectorapi/TestVectorMathLib.java fails without UnlockDiagnosticVMOptions (Bug - P4 - Approved)

Reviewers

• Evgeny Astigeevich (@eastig - Author)
• Paul Hohensee (@phohensee - Reviewer)

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk25u.git pull/243/head:pull/243
$ git checkout pull/243

Update a local copy of the PR:
$ git checkout pull/243
$ git pull https://git.openjdk.org/jdk25u.git pull/243/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 243

View PR using the GUI difftool:
$ git pr show -t 243

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk25u/pull/243.diff

Using Webrev

Link to Webrev Comment

[shipilev]

/issue add JDK-8367969

[bridgekeeper]

👋 Welcome back shade! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

[openjdk]

@shipilev This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8367333: C2: Vector math operation intrinsification failure
8367969: C2: compiler/vectorapi/TestVectorMathLib.java fails without UnlockDiagnosticVMOptions

Reviewed-by: eastigeevich, phh

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 14 new commits pushed to the master branch:

• ec0d44c: 8367017: Remove legacy checks from WrappedToolkitTest and convert from bash
• 9776e4d: 8368071: Compilation throughput regressed 2X-8X after JDK-8355003
• 5861aa7: 8365726: Test crashed with assert in C1 thread: Possible safepoint reached by thread that does not allow it
• ... and 11 more: https://git.openjdk.org/jdk25u/compare/e90d54198d4310830c3a970dbe2bc883c67867f8...master

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

[openjdk]

This backport pull request has now been updated with issue from the original commit.

[openjdk]

@shipilev
Adding additional issue to issue list: 8367969: C2: compiler/vectorapi/TestVectorMathLib.java fails without UnlockDiagnosticVMOptions.

[mlbridge]

Webrevs

• 00: Full (73279b9c)

[eastig]

lgtm

[shipilev]

/approval 8367333 request Avoids the fatal VM crash when using Vector code under aggressive inlining. Fixes recent regression in JDK 25. Applies cleanly. New test fails without the fix, passes with it. All other tests are passing as well. Risk is on lower side: patch is simple, the alternative is VM crash, and the fix goes through a known path in Java. Needs JDK-8367969 as testbug followup.
/approval 8367969 Testbug followup for JDK-8367333. Applies cleanly. Test passes in both release and debug.

[openjdk]

@shipilev
8367333: The approval request has been created successfully.

[openjdk]

@shipilev usage: /approval [<id>] (request|cancel) [<text>]

[shipilev]

/approval 8367969 request Testbug followup for JDK-8367333. Applies cleanly. Test passes in both release and debug.

[openjdk]

@shipilev
8367969: The approval request has been created successfully.

[shipilev]

GHA failure is unrelated. Push approval granted.

/integrate

[openjdk]

Going to push as commit 6c751f2.
Since your change was applied there have been 15 commits pushed to the master branch:

• 668808f: 8362530: VM crash with -XX:+PrintTieredEvents when collecting AOT profiling
• ec0d44c: 8367017: Remove legacy checks from WrappedToolkitTest and convert from bash
• 9776e4d: 8368071: Compilation throughput regressed 2X-8X after JDK-8355003
• ... and 12 more: https://git.openjdk.org/jdk25u/compare/e90d54198d4310830c3a970dbe2bc883c67867f8...master

Your commit was automatically rebased without conflicts.

[openjdk]

@shipilev Pushed as commit 6c751f2.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.