Skip to content

8357691: File blocked.certs contains bad content when boot jdk 25 is used, sun/security/lib/CheckBlockedCerts.java failing#249

Closed
MBaesken wants to merge 1 commit intoopenjdk:masterfrom
openjdk-bots:backport-MBaesken-a80ba626-master
Closed

8357691: File blocked.certs contains bad content when boot jdk 25 is used, sun/security/lib/CheckBlockedCerts.java failing#249
MBaesken wants to merge 1 commit intoopenjdk:masterfrom
openjdk-bots:backport-MBaesken-a80ba626-master

Conversation

@MBaesken
Copy link
Member

@MBaesken MBaesken commented Sep 29, 2025


Progress

  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue
  • JDK-8357691 needs maintainer approval

Issue

  • JDK-8357691: File blocked.certs contains bad content when boot jdk 25 is used, sun/security/lib/CheckBlockedCerts.java failing (Bug - P4 - Approved)

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk25u.git pull/249/head:pull/249
$ git checkout pull/249

Update a local copy of the PR:
$ git checkout pull/249
$ git pull https://git.openjdk.org/jdk25u.git pull/249/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 249

View PR using the GUI difftool:
$ git pr show -t 249

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk25u/pull/249.diff

Using Webrev

Link to Webrev Comment

@bridgekeeper
Copy link

bridgekeeper bot commented Sep 29, 2025

👋 Welcome back mbaesken! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk
Copy link

openjdk bot commented Sep 29, 2025

@MBaesken This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8357691: File blocked.certs contains bad content when boot jdk 25 is used, sun/security/lib/CheckBlockedCerts.java failing

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been no new commits pushed to the master branch. If another commit should be pushed before you perform the /integrate command, your PR will be automatically rebased. If you prefer to avoid any potential automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

@openjdk openjdk bot changed the title Backport a80ba6260effdca7a7703c6903f273401b861793 8357691: File blocked.certs contains bad content when boot jdk 25 is used, sun/security/lib/CheckBlockedCerts.java failing Sep 29, 2025
@openjdk
Copy link

openjdk bot commented Sep 29, 2025

This backport pull request has now been updated with issue from the original commit.

@openjdk openjdk bot added backport Port of a pull request already in a different code base clean Identical backport; no merge resolution required labels Sep 29, 2025
@openjdk
Copy link

openjdk bot commented Sep 29, 2025

⚠️ @MBaesken This change is now ready for you to apply for maintainer approval. This can be done directly in each associated issue or by using the /approval command.

@openjdk openjdk bot added the rfr Pull request is ready for review label Sep 29, 2025
@mlbridge
Copy link

mlbridge bot commented Sep 29, 2025

Webrevs

@openjdk openjdk bot added approval Requires approval; will be removed when approval is received ready Pull request is ready to be integrated and removed approval Requires approval; will be removed when approval is received labels Sep 29, 2025
@MBaesken
Copy link
Member Author

MBaesken commented Oct 1, 2025

/integrate

@openjdk
Copy link

openjdk bot commented Oct 1, 2025

Going to push as commit 756bcc9.
Since your change was applied there have been 2 commits pushed to the master branch:

  • 8058a5b: 8358340: Support CDS heap archive with Generational Shenandoah
  • 86803cc: 8365165: Zap C-heap memory at delete/free

Your commit was automatically rebased without conflicts.

@openjdk openjdk bot added the integrated Pull request has been integrated label Oct 1, 2025
@openjdk openjdk bot closed this Oct 1, 2025
@openjdk openjdk bot removed ready Pull request is ready to be integrated rfr Pull request is ready for review labels Oct 1, 2025
@openjdk
Copy link

openjdk bot commented Oct 1, 2025

@MBaesken Pushed as commit 756bcc9.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

backport Port of a pull request already in a different code base clean Identical backport; no merge resolution required integrated Pull request has been integrated

Development

Successfully merging this pull request may close these issues.

1 participant