Skip to content

Conversation

@shipilev
Copy link
Member

@shipilev shipilev commented Sep 30, 2025

Improves -Xlog:async reliability.

Additional testing:

  • Linux x86_64 server fastdebug, all
  • Linux x86_64 server fastdebug, all with -Xlog:async

Progress

  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue
  • JDK-8362282 needs maintainer approval

Issue

  • JDK-8362282: runtime/logging/StressAsyncUL.java failed with exitValue = 134 (Bug - P3 - Approved)

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk25u.git pull/254/head:pull/254
$ git checkout pull/254

Update a local copy of the PR:
$ git checkout pull/254
$ git pull https://git.openjdk.org/jdk25u.git pull/254/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 254

View PR using the GUI difftool:
$ git pr show -t 254

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk25u/pull/254.diff

Using Webrev

Link to Webrev Comment

@bridgekeeper
Copy link

bridgekeeper bot commented Sep 30, 2025

👋 Welcome back shade! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk
Copy link

openjdk bot commented Sep 30, 2025

@shipilev This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8362282: runtime/logging/StressAsyncUL.java failed with exitValue = 134

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 8 new commits pushed to the master branch:

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

@openjdk openjdk bot changed the title Backport c968a672c034fe533ea5f4ac5efe37ffb76c93e2 8362282: runtime/logging/StressAsyncUL.java failed with exitValue = 134 Sep 30, 2025
@openjdk
Copy link

openjdk bot commented Sep 30, 2025

This backport pull request has now been updated with issue from the original commit.

@openjdk openjdk bot added backport Port of a pull request already in a different code base clean Identical backport; no merge resolution required labels Sep 30, 2025
@shipilev shipilev marked this pull request as ready for review October 1, 2025 17:02
@openjdk
Copy link

openjdk bot commented Oct 1, 2025

⚠️ @shipilev This change is now ready for you to apply for maintainer approval. This can be done directly in each associated issue or by using the /approval command.

@openjdk openjdk bot added the rfr Pull request is ready for review label Oct 1, 2025
@shipilev
Copy link
Member Author

shipilev commented Oct 1, 2025

/approval request Improves -Xlog:async reliability by straightening up initialization sequence. Applies cleanly. No new failures with -Xlog:async, all tests are passing with default logging mode. Patch was in mainline for 3 weeks without new issues. Risk is low-medium: affects non-default logging mode, the problems if any, manifest at startup.

@openjdk
Copy link

openjdk bot commented Oct 1, 2025

@shipilev
8362282: The approval request has been created successfully.

@openjdk openjdk bot added the approval Requires approval; will be removed when approval is received label Oct 1, 2025
@mlbridge
Copy link

mlbridge bot commented Oct 1, 2025

Webrevs

@openjdk openjdk bot added ready Pull request is ready to be integrated and removed approval Requires approval; will be removed when approval is received labels Oct 6, 2025
@shipilev
Copy link
Member Author

shipilev commented Oct 6, 2025

Push approval granted.

/integrate

@openjdk
Copy link

openjdk bot commented Oct 6, 2025

Going to push as commit affde09.
Since your change was applied there have been 9 commits pushed to the master branch:

Your commit was automatically rebased without conflicts.

@openjdk openjdk bot added the integrated Pull request has been integrated label Oct 6, 2025
@openjdk openjdk bot closed this Oct 6, 2025
@openjdk openjdk bot removed ready Pull request is ready to be integrated rfr Pull request is ready for review labels Oct 6, 2025
@openjdk
Copy link

openjdk bot commented Oct 6, 2025

@shipilev Pushed as commit affde09.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

backport Port of a pull request already in a different code base clean Identical backport; no merge resolution required integrated Pull request has been integrated

Development

Successfully merging this pull request may close these issues.

1 participant