Skip to content

Conversation

@Yassine-O
Copy link
Contributor

@Yassine-O Yassine-O commented Oct 2, 2025

Hi all,

This pull request contains a backport of commit bdf9834 from the openjdk/jdk repository.

The commit being backported was authored by Prasanta Sadhukhan and was reviewed by Alexander Zuev and Damon Nguyen.

Thanks!


Progress

  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue
  • JDK-8365425 needs maintainer approval

Issue

  • JDK-8365425: [macos26] javax/swing/JInternalFrame/8160248/JInternalFrameDraggingTest.java fails on macOS 26 (Bug - P4 - Approved)

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk25u.git pull/264/head:pull/264
$ git checkout pull/264

Update a local copy of the PR:
$ git checkout pull/264
$ git pull https://git.openjdk.org/jdk25u.git pull/264/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 264

View PR using the GUI difftool:
$ git pr show -t 264

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk25u/pull/264.diff

Using Webrev

Link to Webrev Comment

@bridgekeeper bridgekeeper bot added the oca Needs verification of OCA signatory status label Oct 2, 2025
@bridgekeeper
Copy link

bridgekeeper bot commented Oct 2, 2025

Hi @Yassine-O, welcome to this OpenJDK project and thanks for contributing!

We do not recognize you as Contributor and need to ensure you have signed the Oracle Contributor Agreement (OCA). If you have not signed the OCA, please follow the instructions. Please fill in your GitHub username in the "Username" field of the application. Once you have signed the OCA, please let us know by writing /signed in a comment in this pull request.

If you already are an OpenJDK Author, Committer or Reviewer, please click here to open a new issue so that we can record that fact. Please use "Add GitHub user Yassine-O" as summary for the issue.

If you are contributing this work on behalf of your employer and your employer has signed the OCA, please let us know by writing /covered in a comment in this pull request.

@openjdk
Copy link

openjdk bot commented Oct 2, 2025

@Yassine-O This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8365425: [macos26] javax/swing/JInternalFrame/8160248/JInternalFrameDraggingTest.java fails on macOS 26

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 39 new commits pushed to the master branch:

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

As you do not have Committer status in this project an existing Committer must agree to sponsor your change.

➡️ To flag this PR as ready for integration with the above commit message, type /integrate in a new comment. (Afterwards, your sponsor types /sponsor in a new comment to perform the integration).

@openjdk openjdk bot changed the title Backport bdf9834b81f0565e3572de42ebd42981d1d05a5c 8365425: [macos26] javax/swing/JInternalFrame/8160248/JInternalFrameDraggingTest.java fails on macOS 26 Oct 2, 2025
@openjdk
Copy link

openjdk bot commented Oct 2, 2025

This backport pull request has now been updated with issue from the original commit.

@openjdk openjdk bot added backport Port of a pull request already in a different code base clean Identical backport; no merge resolution required labels Oct 2, 2025
@Yassine-O
Copy link
Contributor Author

/covered

@bridgekeeper bridgekeeper bot removed the oca Needs verification of OCA signatory status label Oct 2, 2025
@bridgekeeper
Copy link

bridgekeeper bot commented Oct 2, 2025

You are already a known contributor!

@openjdk
Copy link

openjdk bot commented Oct 2, 2025

⚠️ @Yassine-O the full name on your profile does not match the author name in this pull requests' HEAD commit. If this pull request gets integrated then the author name from this pull requests' HEAD commit will be used for the resulting commit. If you wish to push a new commit with a different author name, then please run the following commands in a local repository of your personal fork:

$ git checkout backport-8365425
$ git commit --author='Preferred Full Name <you@example.com>' --allow-empty -m 'Update full name'
$ git push

@openjdk openjdk bot added ready Pull request is ready to be integrated rfr Pull request is ready for review labels Oct 2, 2025
@mlbridge
Copy link

mlbridge bot commented Oct 2, 2025

Webrevs

@Yassine-O
Copy link
Contributor Author

/integrate

@openjdk openjdk bot added the sponsor Pull request is ready to be sponsored label Oct 7, 2025
@openjdk
Copy link

openjdk bot commented Oct 7, 2025

@Yassine-O
Your change (at version 43e6361) is now ready to be sponsored by a Committer.

@shipilev
Copy link
Member

shipilev commented Oct 7, 2025

/sponsor

@openjdk
Copy link

openjdk bot commented Oct 7, 2025

Going to push as commit 9305ebf.
Since your change was applied there have been 39 commits pushed to the master branch:

Your commit was automatically rebased without conflicts.

@openjdk openjdk bot added the integrated Pull request has been integrated label Oct 7, 2025
@openjdk openjdk bot closed this Oct 7, 2025
@openjdk openjdk bot removed ready Pull request is ready to be integrated rfr Pull request is ready for review sponsor Pull request is ready to be sponsored labels Oct 7, 2025
@openjdk
Copy link

openjdk bot commented Oct 7, 2025

@shipilev @Yassine-O Pushed as commit 9305ebf.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

backport Port of a pull request already in a different code base clean Identical backport; no merge resolution required integrated Pull request has been integrated

Development

Successfully merging this pull request may close these issues.

2 participants