Skip to content

8358751: C2: Recursive inlining check for compiled lambda forms is broken#279

Closed
wkia wants to merge 1 commit intoopenjdk:masterfrom
wkia:backport
Closed

8358751: C2: Recursive inlining check for compiled lambda forms is broken#279
wkia wants to merge 1 commit intoopenjdk:masterfrom
wkia:backport

Conversation

@wkia
Copy link

@wkia wkia commented Oct 8, 2025

This is backport of JDK-8358751 "C2: Recursive inlining check for compiled lambda forms is broken"

Clean backport. tier1-tier4 seem OK, run on linux64.


Progress

  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue
  • JDK-8358751 needs maintainer approval

Issue

  • JDK-8358751: C2: Recursive inlining check for compiled lambda forms is broken (Bug - P2 - Approved)

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk25u.git pull/279/head:pull/279
$ git checkout pull/279

Update a local copy of the PR:
$ git checkout pull/279
$ git pull https://git.openjdk.org/jdk25u.git pull/279/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 279

View PR using the GUI difftool:
$ git pr show -t 279

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk25u/pull/279.diff

Using Webrev

Link to Webrev Comment

@bridgekeeper
Copy link

bridgekeeper bot commented Oct 8, 2025

👋 Welcome back rmarchenko! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk
Copy link

openjdk bot commented Oct 8, 2025

@wkia This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8358751: C2: Recursive inlining check for compiled lambda forms is broken

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 31 new commits pushed to the master branch:

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

As you do not have Committer status in this project an existing Committer must agree to sponsor your change.

➡️ To flag this PR as ready for integration with the above commit message, type /integrate in a new comment. (Afterwards, your sponsor types /sponsor in a new comment to perform the integration).

@openjdk openjdk bot changed the title Backport 9cca4f7c760bea9bf79f7c03f37a70449acad51e 8358751: C2: Recursive inlining check for compiled lambda forms is broken Oct 8, 2025
@openjdk
Copy link

openjdk bot commented Oct 8, 2025

This backport pull request has now been updated with issue from the original commit.

@openjdk openjdk bot added backport Port of a pull request already in a different code base clean Identical backport; no merge resolution required labels Oct 8, 2025
@openjdk
Copy link

openjdk bot commented Oct 8, 2025

⚠️ @wkia This change is now ready for you to apply for maintainer approval. This can be done directly in each associated issue or by using the /approval command.

@openjdk openjdk bot added the rfr Pull request is ready for review label Oct 8, 2025
@mlbridge
Copy link

mlbridge bot commented Oct 8, 2025

Webrevs

@openjdk
Copy link

openjdk bot commented Oct 10, 2025

@wkia Please do not rebase or force-push to an active PR as it invalidates existing review comments. Note for future reference, the bots always squash all changes into a single commit automatically as part of the integration. See OpenJDK Developers’ Guide for more information.

@wkia
Copy link
Author

wkia commented Oct 10, 2025

/approval request I'd like to backport this to jdk25u, as it's affected. Clean backport. Tier1-Tier4 are OK.

@openjdk
Copy link

openjdk bot commented Oct 10, 2025

@wkia
8358751: The approval request has been created successfully.

@openjdk openjdk bot added approval Requires approval; will be removed when approval is received ready Pull request is ready to be integrated and removed approval Requires approval; will be removed when approval is received labels Oct 10, 2025
@wkia
Copy link
Author

wkia commented Oct 13, 2025

/integrate

@openjdk openjdk bot added the sponsor Pull request is ready to be sponsored label Oct 13, 2025
@openjdk
Copy link

openjdk bot commented Oct 13, 2025

@wkia
Your change (at version aa83f2f) is now ready to be sponsored by a Committer.

@phohensee
Copy link
Member

/sponsor

@openjdk
Copy link

openjdk bot commented Oct 13, 2025

Going to push as commit a156447.
Since your change was applied there have been 37 commits pushed to the master branch:

Your commit was automatically rebased without conflicts.

@openjdk openjdk bot added the integrated Pull request has been integrated label Oct 13, 2025
@openjdk openjdk bot closed this Oct 13, 2025
@openjdk openjdk bot removed ready Pull request is ready to be integrated rfr Pull request is ready for review sponsor Pull request is ready to be sponsored labels Oct 13, 2025
@openjdk
Copy link

openjdk bot commented Oct 13, 2025

@phohensee @wkia Pushed as commit a156447.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

@wkia wkia deleted the backport branch October 13, 2025 19:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

backport Port of a pull request already in a different code base clean Identical backport; no merge resolution required integrated Pull request has been integrated

Development

Successfully merging this pull request may close these issues.

2 participants