8361711: Add library name configurability to PKCS11Test.java#288
8361711: Add library name configurability to PKCS11Test.java#288fitzsim wants to merge 1 commit intoopenjdk:masterfrom
Conversation
|
👋 Welcome back fitzsim! A progress list of the required criteria for merging this PR into |
|
@fitzsim This change now passes all automated pre-integration checks. ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details. After integration, the commit message for the final commit will be: You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed. At the time when this comment was updated there had been 7 new commits pushed to the
As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details. As you do not have Committer status in this project an existing Committer must agree to sponsor your change. ➡️ To flag this PR as ready for integration with the above commit message, type |
|
This backport pull request has now been updated with issue from the original commit. |
|
There was a failure in linux-x64 / test (hs/tier1 serviceability) but that does not seem related to this patch. |
|
|
|
/approval request This backport will allow the Kryoptic continuous integration scripts to test against upstream OpenJDK 25. I would like to continuously test Kryoptic against the long-term support JDK 25 releases. I have this patch working with Kryoptic CI (merged in latchset/kryoptic#347) in a branch of my own jdk25u fork (https://github.com/fitzsim/jdk25u/tree/kryoptic-jdk-25). |
|
/integrate |
|
/sponsor |
|
Going to push as commit a1d5dd1.
Your commit was automatically rebased without conflicts. |
|
@phohensee @fitzsim Pushed as commit a1d5dd1. 💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored. |
Hi all,
This pull request contains a backport of commit 1cb1267c from the openjdk/jdk repository.
The commit being backported was authored by Thomas Fitzsimmons on 15 Sep 2025 and was reviewed by Valerie Peng.
This backport will allow the Kryoptic continuous integration scripts to test against upstream OpenJDK 25. I have this patch working with Kryoptic CI (merged in latchset/kryoptic#347) in a branch of my own jdk25u fork (https://github.com/fitzsim/jdk25u/tree/kryoptic-jdk-25).
Thanks!
Progress
Issue
Reviewing
Using
gitCheckout this PR locally:
$ git fetch https://git.openjdk.org/jdk25u.git pull/288/head:pull/288$ git checkout pull/288Update a local copy of the PR:
$ git checkout pull/288$ git pull https://git.openjdk.org/jdk25u.git pull/288/headUsing Skara CLI tools
Checkout this PR locally:
$ git pr checkout 288View PR using the GUI difftool:
$ git pr show -t 288Using diff file
Download this PR as a diff file:
https://git.openjdk.org/jdk25u/pull/288.diff
Using Webrev
Link to Webrev Comment