Skip to content

8361711: Add library name configurability to PKCS11Test.java#288

Closed
fitzsim wants to merge 1 commit intoopenjdk:masterfrom
openjdk-bots:backport-fitzsim-1cb1267c-master
Closed

8361711: Add library name configurability to PKCS11Test.java#288
fitzsim wants to merge 1 commit intoopenjdk:masterfrom
openjdk-bots:backport-fitzsim-1cb1267c-master

Conversation

@fitzsim
Copy link

@fitzsim fitzsim commented Oct 9, 2025

Hi all,

This pull request contains a backport of commit 1cb1267c from the openjdk/jdk repository.

The commit being backported was authored by Thomas Fitzsimmons on 15 Sep 2025 and was reviewed by Valerie Peng.

This backport will allow the Kryoptic continuous integration scripts to test against upstream OpenJDK 25. I have this patch working with Kryoptic CI (merged in latchset/kryoptic#347) in a branch of my own jdk25u fork (https://github.com/fitzsim/jdk25u/tree/kryoptic-jdk-25).

Thanks!


Progress

  • Change must not contain extraneous whitespace
  • JDK-8361711 needs maintainer approval
  • Commit message must refer to an issue

Issue

  • JDK-8361711: Add library name configurability to PKCS11Test.java (Enhancement - P4 - Approved)

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk25u.git pull/288/head:pull/288
$ git checkout pull/288

Update a local copy of the PR:
$ git checkout pull/288
$ git pull https://git.openjdk.org/jdk25u.git pull/288/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 288

View PR using the GUI difftool:
$ git pr show -t 288

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk25u/pull/288.diff

Using Webrev

Link to Webrev Comment

@bridgekeeper
Copy link

bridgekeeper bot commented Oct 9, 2025

👋 Welcome back fitzsim! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk
Copy link

openjdk bot commented Oct 9, 2025

@fitzsim This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8361711: Add library name configurability to PKCS11Test.java

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 7 new commits pushed to the master branch:

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

As you do not have Committer status in this project an existing Committer must agree to sponsor your change.

➡️ To flag this PR as ready for integration with the above commit message, type /integrate in a new comment. (Afterwards, your sponsor types /sponsor in a new comment to perform the integration).

@openjdk openjdk bot changed the title Backport 1cb1267ce84dea2bfcb434b03c982b859997c6d2 8361711: Add library name configurability to PKCS11Test.java Oct 9, 2025
@openjdk
Copy link

openjdk bot commented Oct 9, 2025

This backport pull request has now been updated with issue from the original commit.

@openjdk openjdk bot added backport Port of a pull request already in a different code base clean Identical backport; no merge resolution required labels Oct 9, 2025
@fitzsim
Copy link
Author

fitzsim commented Oct 9, 2025

There was a failure in linux-x64 / test (hs/tier1 serviceability) but that does not seem related to this patch.

@fitzsim fitzsim marked this pull request as ready for review October 9, 2025 20:58
@openjdk
Copy link

openjdk bot commented Oct 9, 2025

⚠️ @fitzsim This change is now ready for you to apply for maintainer approval. This can be done directly in each associated issue or by using the /approval command.

@openjdk openjdk bot added the rfr Pull request is ready for review label Oct 9, 2025
@mlbridge
Copy link

mlbridge bot commented Oct 9, 2025

Webrevs

@fitzsim
Copy link
Author

fitzsim commented Oct 9, 2025

/approval request This backport will allow the Kryoptic continuous integration scripts to test against upstream OpenJDK 25. I would like to continuously test Kryoptic against the long-term support JDK 25 releases. I have this patch working with Kryoptic CI (merged in latchset/kryoptic#347) in a branch of my own jdk25u fork (https://github.com/fitzsim/jdk25u/tree/kryoptic-jdk-25).

@openjdk
Copy link

openjdk bot commented Oct 9, 2025

@fitzsim
8361711: The approval request has been created successfully.

@openjdk openjdk bot added approval Requires approval; will be removed when approval is received ready Pull request is ready to be integrated and removed approval Requires approval; will be removed when approval is received labels Oct 9, 2025
@fitzsim
Copy link
Author

fitzsim commented Oct 10, 2025

/integrate

@openjdk openjdk bot added the sponsor Pull request is ready to be sponsored label Oct 10, 2025
@openjdk
Copy link

openjdk bot commented Oct 10, 2025

@fitzsim
Your change (at version 23c57fd) is now ready to be sponsored by a Committer.

@phohensee
Copy link
Member

/sponsor

@openjdk
Copy link

openjdk bot commented Oct 13, 2025

Going to push as commit a1d5dd1.
Since your change was applied there have been 19 commits pushed to the master branch:

Your commit was automatically rebased without conflicts.

@openjdk openjdk bot added the integrated Pull request has been integrated label Oct 13, 2025
@openjdk openjdk bot closed this Oct 13, 2025
@openjdk openjdk bot removed ready Pull request is ready to be integrated rfr Pull request is ready for review sponsor Pull request is ready to be sponsored labels Oct 13, 2025
@openjdk
Copy link

openjdk bot commented Oct 13, 2025

@phohensee @fitzsim Pushed as commit a1d5dd1.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

backport Port of a pull request already in a different code base clean Identical backport; no merge resolution required integrated Pull request has been integrated

Development

Successfully merging this pull request may close these issues.

2 participants