8369078: Fix faulty test conversion in IllegalCharsetName.java

[justin-curtis-lu]

A test-only correction, which is a backport of commit 0f406c42 from the openjdk/jdk repository.

---

Progress

• Change must not contain extraneous whitespace
• Commit message must refer to an issue
• JDK-8369078 needs maintainer approval

Issue

• JDK-8369078: Fix faulty test conversion in IllegalCharsetName.java (Bug - P4 - Approved)

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk25u.git pull/293/head:pull/293
$ git checkout pull/293

Update a local copy of the PR:
$ git checkout pull/293
$ git pull https://git.openjdk.org/jdk25u.git pull/293/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 293

View PR using the GUI difftool:
$ git pr show -t 293

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk25u/pull/293.diff

Using Webrev

Link to Webrev Comment

[bridgekeeper]

👋 Welcome back jlu! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

[openjdk]

@justin-curtis-lu This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8369078: Fix faulty test conversion in IllegalCharsetName.java

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 8 new commits pushed to the master branch:

• d4a7d0d: 8367948: JFR: MethodTrace threshold setting has no effect
• 8df7dd1: 8367953: JFR sampler threads does not appear in thread dump
• b26b71d: 8364993: JFR: Disable jdk.ModuleExport in default.jfc
• ... and 5 more: https://git.openjdk.org/jdk25u/compare/b1921d3a97c68b4c423f2ddd06c64f5c707e1ef3...master

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

As you do not have Committer status in this project an existing Committer must agree to sponsor your change.

➡️ To flag this PR as ready for integration with the above commit message, type /integrate in a new comment. (Afterwards, your sponsor types /sponsor in a new comment to perform the integration).

[openjdk]

This backport pull request has now been updated with issue from the original commit.

[openjdk]

⚠️ @justin-curtis-lu This change is now ready for you to apply for maintainer approval. This can be done directly in each associated issue or by using the /approval command.

[justin-curtis-lu]

/approval request Clean backport to fix a test.

[openjdk]

@justin-curtis-lu
8369078: The approval request has been created successfully.

[mlbridge]

Webrevs

• 00: Full (1d1e06b5)

[justin-curtis-lu]

/integrate

[openjdk]

@justin-curtis-lu
Your change (at version 1d1e06b) is now ready to be sponsored by a Committer.

[shipilev]

/sponsor

[openjdk]

Going to push as commit cbc605a.
Since your change was applied there have been 9 commits pushed to the master branch:

• a44b6bd: 8360411: [TEST] open/test/jdk/java/io/File/MaxPathLength.java Refactor extract method to encapsulate Windows specific test logic
• d4a7d0d: 8367948: JFR: MethodTrace threshold setting has no effect
• 8df7dd1: 8367953: JFR sampler threads does not appear in thread dump
• ... and 6 more: https://git.openjdk.org/jdk25u/compare/b1921d3a97c68b4c423f2ddd06c64f5c707e1ef3...master

Your commit was automatically rebased without conflicts.

[openjdk]

@shipilev @justin-curtis-lu Pushed as commit cbc605a.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.