Skip to content

8362123: ClassLoader Leak via Executors.newSingleThreadExecutor(...)#295

Closed
chrisdennis wants to merge 1 commit intoopenjdk:masterfrom
chrisdennis:JDK-8362123
Closed

8362123: ClassLoader Leak via Executors.newSingleThreadExecutor(...)#295
chrisdennis wants to merge 1 commit intoopenjdk:masterfrom
chrisdennis:JDK-8362123

Conversation

@chrisdennis
Copy link
Contributor

@chrisdennis chrisdennis commented Oct 13, 2025

This is a backport of d5a207994b9c374e6638e57826326f8f4593b96b from openjdk/jdk which is a bug-fix of JDK-8362123.


Progress

  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue
  • JDK-8362123 needs maintainer approval

Issue

  • JDK-8362123: ClassLoader Leak via Executors.newSingleThreadExecutor(...) (Bug - P4 - Approved)

Reviewers

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk25u.git pull/295/head:pull/295
$ git checkout pull/295

Update a local copy of the PR:
$ git checkout pull/295
$ git pull https://git.openjdk.org/jdk25u.git pull/295/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 295

View PR using the GUI difftool:
$ git pr show -t 295

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk25u/pull/295.diff

Using Webrev

Link to Webrev Comment

@bridgekeeper
Copy link

bridgekeeper bot commented Oct 13, 2025

👋 Welcome back chrisdennis! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk
Copy link

openjdk bot commented Oct 13, 2025

@chrisdennis This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8362123: ClassLoader Leak via Executors.newSingleThreadExecutor(...)

Reviewed-by: aph

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 18 new commits pushed to the master branch:

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

As you do not have Committer status in this project an existing Committer must agree to sponsor your change. Possible candidates are the reviewers of this PR (@theRealAph) but any other Committer may sponsor as well.

➡️ To flag this PR as ready for integration with the above commit message, type /integrate in a new comment. (Afterwards, your sponsor types /sponsor in a new comment to perform the integration).

@openjdk openjdk bot changed the title Backport d5a207994b9c374e6638e57826326f8f4593b96b 8362123: ClassLoader Leak via Executors.newSingleThreadExecutor(...) Oct 13, 2025
@openjdk
Copy link

openjdk bot commented Oct 13, 2025

This backport pull request has now been updated with issue from the original commit.

@openjdk openjdk bot added backport Port of a pull request already in a different code base clean Identical backport; no merge resolution required labels Oct 13, 2025
@openjdk
Copy link

openjdk bot commented Oct 13, 2025

⚠️ @chrisdennis This change is now ready for you to apply for maintainer approval. This can be done directly in each associated issue or by using the /approval command.

@openjdk openjdk bot added the rfr Pull request is ready for review label Oct 13, 2025
@mlbridge
Copy link

mlbridge bot commented Oct 13, 2025

Webrevs

@chrisdennis
Copy link
Contributor Author

/approval request This fixes a memory leak and/or prompt garbage collection issue introduced in Java 21

@openjdk
Copy link

openjdk bot commented Oct 13, 2025

@chrisdennis
8362123: The approval request has been created successfully.

@openjdk openjdk bot added the approval Requires approval; will be removed when approval is received label Oct 13, 2025
@jerboaa
Copy link
Contributor

jerboaa commented Oct 14, 2025

@chrisdennis Please enable GHA for your fork. See how here:
https://github.com/openjdk/jdk25u/pull/295/checks?check_run_id=52627905452

@openjdk
Copy link

openjdk bot commented Oct 14, 2025

@chrisdennis Please do not rebase or force-push to an active PR as it invalidates existing review comments. Note for future reference, the bots always squash all changes into a single commit automatically as part of the integration. See OpenJDK Developers’ Guide for more information.

@openjdk openjdk bot added ready Pull request is ready to be integrated and removed approval Requires approval; will be removed when approval is received labels Oct 16, 2025
@chrisdennis
Copy link
Contributor Author

/integrate

@openjdk openjdk bot added the sponsor Pull request is ready to be sponsored label Oct 16, 2025
@openjdk
Copy link

openjdk bot commented Oct 16, 2025

@chrisdennis
Your change (at version 5226827) is now ready to be sponsored by a Committer.

@jerboaa
Copy link
Contributor

jerboaa commented Oct 16, 2025

/sponsor

@openjdk
Copy link

openjdk bot commented Oct 16, 2025

Going to push as commit 9018319.
Since your change was applied there have been 18 commits pushed to the master branch:

Your commit was automatically rebased without conflicts.

@openjdk openjdk bot added the integrated Pull request has been integrated label Oct 16, 2025
@openjdk openjdk bot closed this Oct 16, 2025
@openjdk openjdk bot removed ready Pull request is ready to be integrated rfr Pull request is ready for review sponsor Pull request is ready to be sponsored labels Oct 16, 2025
@openjdk
Copy link

openjdk bot commented Oct 16, 2025

@jerboaa @chrisdennis Pushed as commit 9018319.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

backport Port of a pull request already in a different code base clean Identical backport; no merge resolution required integrated Pull request has been integrated

Development

Successfully merging this pull request may close these issues.

3 participants