Skip to content

Conversation

@rgangadhar
Copy link
Member

@rgangadhar rgangadhar commented Oct 15, 2025


Progress

  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue
  • JDK-8366342 needs maintainer approval

Issue

  • JDK-8366342: Key generator and key pair generator tests skipping, but showing as passed (Bug - P4 - Approved)

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk25u.git pull/312/head:pull/312
$ git checkout pull/312

Update a local copy of the PR:
$ git checkout pull/312
$ git pull https://git.openjdk.org/jdk25u.git pull/312/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 312

View PR using the GUI difftool:
$ git pr show -t 312

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk25u/pull/312.diff

Using Webrev

Link to Webrev Comment

@bridgekeeper
Copy link

bridgekeeper bot commented Oct 15, 2025

👋 Welcome back rgangadhar! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk
Copy link

openjdk bot commented Oct 15, 2025

@rgangadhar This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8366342: Key generator and key pair generator tests skipping, but showing as passed

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 3 new commits pushed to the master branch:

  • c767b2d: 8369616: JavaFrameAnchor on RISC-V has unnecessary barriers and wrong store order in MacroAssembler
  • 1cd8cd8: 8368565: Adjust comment regarding dependency of libjvm.so to librt
  • a5faa59: 8201778: Speed up test javax/net/ssl/DTLS/PacketLossRetransmission.java

Please see this link for an up-to-date comparison between the source branch of this pull request and the master branch.
As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

As you do not have Committer status in this project an existing Committer must agree to sponsor your change.

➡️ To flag this PR as ready for integration with the above commit message, type /integrate in a new comment. (Afterwards, your sponsor types /sponsor in a new comment to perform the integration).

@openjdk openjdk bot changed the title Backport 7690a45f77a2da47fa912fe7a2b2faa589f259f0 8366342: Key generator and key pair generator tests skipping, but showing as passed Oct 15, 2025
@openjdk
Copy link

openjdk bot commented Oct 15, 2025

This backport pull request has now been updated with issue from the original commit.

@openjdk openjdk bot added backport Port of a pull request already in a different code base clean Identical backport; no merge resolution required labels Oct 15, 2025
@openjdk
Copy link

openjdk bot commented Oct 15, 2025

⚠️ @rgangadhar This change is now ready for you to apply for maintainer approval. This can be done directly in each associated issue or by using the /approval command.

@openjdk openjdk bot added the rfr Pull request is ready for review label Oct 15, 2025
@mlbridge
Copy link

mlbridge bot commented Oct 15, 2025

Webrevs

@openjdk openjdk bot added approval Requires approval; will be removed when approval is received ready Pull request is ready to be integrated and removed approval Requires approval; will be removed when approval is received labels Oct 15, 2025
@rgangadhar
Copy link
Member Author

/integrate

@coffeys
Copy link
Contributor

coffeys commented Oct 15, 2025

/sponsor

@openjdk openjdk bot added the sponsor Pull request is ready to be sponsored label Oct 15, 2025
@openjdk
Copy link

openjdk bot commented Oct 15, 2025

@rgangadhar
Your change (at version 7a8844a) is now ready to be sponsored by a Committer.

@openjdk
Copy link

openjdk bot commented Oct 15, 2025

Going to push as commit 07b5de6.
Since your change was applied there have been 3 commits pushed to the master branch:

  • c767b2d: 8369616: JavaFrameAnchor on RISC-V has unnecessary barriers and wrong store order in MacroAssembler
  • 1cd8cd8: 8368565: Adjust comment regarding dependency of libjvm.so to librt
  • a5faa59: 8201778: Speed up test javax/net/ssl/DTLS/PacketLossRetransmission.java

Your commit was automatically rebased without conflicts.

@openjdk openjdk bot added the integrated Pull request has been integrated label Oct 15, 2025
@openjdk openjdk bot closed this Oct 15, 2025
@openjdk openjdk bot removed ready Pull request is ready to be integrated rfr Pull request is ready for review sponsor Pull request is ready to be sponsored labels Oct 15, 2025
@openjdk
Copy link

openjdk bot commented Oct 15, 2025

@coffeys @rgangadhar Pushed as commit 07b5de6.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

backport Port of a pull request already in a different code base clean Identical backport; no merge resolution required integrated Pull request has been integrated

Development

Successfully merging this pull request may close these issues.

2 participants