8360478: libjsig related tier3 jtreg tests fail when asan is configured

[MBaesken]

---

Progress

• JDK-8360478 needs maintainer approval
• Change must not contain extraneous whitespace
• Commit message must refer to an issue

Warning

 ⚠️ Found leading lowercase letter in issue title for 8360478: libjsig related tier3 jtreg tests fail when asan is configured

Issue

• JDK-8360478: libjsig related tier3 jtreg tests fail when asan is configured (Bug - P4)

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk25u.git pull/35/head:pull/35
$ git checkout pull/35

Update a local copy of the PR:
$ git checkout pull/35
$ git pull https://git.openjdk.org/jdk25u.git pull/35/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 35

View PR using the GUI difftool:
$ git pr show -t 35

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk25u/pull/35.diff

Using Webrev

Link to Webrev Comment

[bridgekeeper]

👋 Welcome back mbaesken! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

[openjdk]

❗ This change is not yet ready to be integrated.
See the Progress checklist in the description for automated requirements.

[openjdk]

This backport pull request has now been updated with issue from the original commit.

[openjdk]

⚠️ @MBaesken This change is now ready for you to apply for maintainer approval. This can be done directly in each associated issue or by using the /approval command.

[mlbridge]

Webrevs

• 00: Full (90b25d93)

[tstuefe]

Hmmm...

If ASAN does not come first, libjsig comes first, and libjsig uses malloc, it will use the malloc implementation from the C-Runtime, not the one ASAN interposes. That, in turn, could cause weird errors or crashes when later memory is freed at a place where ASAN interposition of malloc holds, since we use a different free().

I would probably just disable the libjsig tests for ASAN completely.

[MBaesken]

Hmmm...

If ASAN does not come first, libjsig comes first, and libjsig uses malloc, it will use the malloc implementation from the C-Runtime, not the one ASAN interposes. That, in turn, could cause weird errors or crashes when later memory is freed at a place where ASAN interposition of malloc holds, since we use a different free().

I would probably just disable the libjsig tests for ASAN completely.

Hi Thomas, never saw that really happening in practise when running tests with ASAN enabled binaries.
(of course that is no proof that it is technically impossible under special circumstances)

[MBaesken]

Maybe we should just wait some more time with the backport; in case we really see issues with setting this ASAN flag, we can adjust this setting.

[tstuefe]

Also, does this not switch off the warning for all tests, not only the libjsig tests?

[MBaesken]

Also, does this not switch off the warning for all tests, not only the libjsig tests?

For all tests; but the jsig tests are the ones where we really saw this.

[bridgekeeper]

@MBaesken This pull request has been inactive for more than 4 weeks and will be automatically closed if another 4 weeks passes without any activity. To avoid this, simply issue a /touch or /keepalive command to the pull request. Feel free to ask for assistance if you need help with progressing this pull request towards integration!

[bridgekeeper]

@MBaesken This pull request has been inactive for more than 8 weeks and will now be automatically closed. If you would like to continue working on this pull request in the future, feel free to reopen it! This can be done using the /open pull request command.