8370969: --launcher-as-service option is ignored when used with --app-image option

[alexeysemenyukoracle]

Clean backport of openjdk/jdk#28071 PR on top of prerequisite commits.

It is easier and safer to bring in all prerequisite commits to get a clean backport than to backport an isolated fix.

---

Progress

• Change must be properly reviewed (1 review required, with at least 1 Reviewer)
• Commit message must refer to an issue
• JDK-8362598 needs maintainer approval
• JDK-8370956 needs maintainer approval
• JDK-8363979 needs maintainer approval
• JDK-8370136 needs maintainer approval
• Change requires CSR request JDK-8371299 to be approved
• JDK-8370134 needs maintainer approval
• JDK-8370156 needs maintainer approval
• JDK-8359756 needs maintainer approval
• JDK-8364587 needs maintainer approval
• JDK-8370969 needs maintainer approval
• JDK-8370100 needs maintainer approval
• JDK-8343220 needs maintainer approval
• JDK-8365555 needs maintainer approval
• JDK-8370120 needs maintainer approval
• JDK-8356578 needs maintainer approval
• JDK-8370122 needs maintainer approval
• JDK-8343221 needs maintainer approval
• JDK-8308349 needs maintainer approval
• JDK-8368030 needs maintainer approval
• JDK-8351073 needs maintainer approval
• JDK-8356575 needs maintainer approval
• JDK-8364564 needs maintainer approval
• JDK-8356218 needs maintainer approval
• JDK-8370126 needs maintainer approval
• Change must not contain extraneous whitespace
• JDK-8361224 needs maintainer approval
• JDK-8370442 needs maintainer approval
• JDK-8360507 needs maintainer approval
• JDK-8370123 needs maintainer approval
• JDK-8362352 needs maintainer approval
• JDK-8356047 needs maintainer approval

Warning

 ⚠️ Found leading lowercase letter in issue title for 8308349: missing working directory option for launcher when invoked from shortcuts, 8370122: jpackage test lib improvements

Issues

• JDK-8370969: --launcher-as-service option is ignored when used with --app-image option (Bug - P3)
• JDK-8361224: [macos] MacSignTest.testMultipleCertificates failed (Bug - P3)
• JDK-8351073: [macos] jpackage produces invalid Java runtime DMG bundles (Bug - P4)
• JDK-8360507: JPKG002-006: SigningPackageTest: appOutput.txt cannot be found in user home directory and output doesn't contain: origin=Developer ID Application: jpackage.openjdk.java.net (Bug - P4)
• JDK-8362352: Fix references to non-existing resource strings (Bug - P4)
• JDK-8359756: Bug in RuntimePackageTest.testName test (Bug - P4)
• JDK-8364587: Update jpackage internal javadoc (Bug - P4)
• JDK-8364564: Shortcut configuration is not recorded in .jpackage.xml file (Bug - P4)
• JDK-8308349: missing working directory option for launcher when invoked from shortcuts (Enhancement - P4)
• JDK-8365555: Cleanup redundancies in jpackage implementation (Enhancement - P3)
• JDK-8356218: [macos] Document --app-content (Enhancement - P3)
• JDK-8343221: IOUtils.copyRecursive() doesn't create parent directories (Bug - P4)
• JDK-8368030: Make package bundlers stateless (Enhancement - P4)
• JDK-8362598: [macos] Add tests for custom info plist files (Enhancement - P4)
• JDK-8356047: [macos] jpackage produces confusing post- and pre- installation PKG scripts (Bug - P4)
• JDK-8363979: Add JDK bundle/image validation for --runtime-image option (Enhancement - P3)
• JDK-8356575: Test order in which jpackage fills app image (Enhancement - P4)
• JDK-8370134: Fix minor jpackage issues (Bug - P4)
• JDK-8370120: Make jpackage tests output more stable (Enhancement - P4)
• JDK-8370136: Support async execution of jpackage tests (Enhancement - P4)
• JDK-8370123: Minor jpackage refactoring (Enhancement - P4)
• JDK-8370126: Improve jpackage signing testing (Enhancement - P4)
• JDK-8356578: Test --mac-entitlements (Enhancement - P4)
• JDK-8370122: jpackage test lib improvements (Enhancement - P4)
• JDK-8370442: Compilation error in jpackage EntitlementsTest test (Bug - P2)
• JDK-8370156: Fix jpackage IconTest (Bug - P4)
• JDK-8370100: Redundant .png files in Linux app-image cause unnecessary bloat (Bug - P4)
• JDK-8370956: ShortcutHintTest test fails when executed locally on Linux (Bug - P4)
• JDK-8343220: Add test cases to AppContentTest jpackage test (Enhancement - P4)
• JDK-8371299: missing working directory option for launcher when invoked from shortcuts (CSR)

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk25u.git pull/357/head:pull/357
$ git checkout pull/357

Update a local copy of the PR:
$ git checkout pull/357
$ git pull https://git.openjdk.org/jdk25u.git pull/357/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 357

View PR using the GUI difftool:
$ git pr show -t 357

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk25u/pull/357.diff

Using Webrev

Link to Webrev Comment

[bridgekeeper]

👋 Welcome back asemenyuk! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

[openjdk]

❗ This change is not yet ready to be integrated.
See the Progress checklist in the description for automated requirements.

[alexeysemenyukoracle]

/issue add 8361224 8351073 8360507 8362352 8359756 8364587 8364564 8308349 8365555 8356218 8343221 8368030 8362598 8356047 8363979 8356575 8370134 8370120 8370136 8370123 8370126 8356578 8370122 8370442 8370156 8370100 8370956 8370969

[openjdk]

@alexeysemenyukoracle
Adding additional issue to issue list: 8361224: [macos] MacSignTest.testMultipleCertificates failed.

Adding additional issue to issue list: 8351073: [macos] jpackage produces invalid Java runtime DMG bundles.

Adding additional issue to issue list: 8360507: JPKG002-006: SigningPackageTest: appOutput.txt cannot be found in user home directory and output doesn't contain: origin=Developer ID Application: jpackage.openjdk.java.net.

Adding additional issue to issue list: 8362352: Fix references to non-existing resource strings.

Adding additional issue to issue list: 8359756: Bug in RuntimePackageTest.testName test.

Adding additional issue to issue list: 8364587: Update jpackage internal javadoc.

Adding additional issue to issue list: 8364564: Shortcut configuration is not recorded in .jpackage.xml file.

Adding additional issue to issue list: 8308349: missing working directory option for launcher when invoked from shortcuts.

Adding additional issue to issue list: 8365555: Cleanup redundancies in jpackage implementation.

Adding additional issue to issue list: 8356218: [macos] Document --app-content.

Adding additional issue to issue list: 8343221: IOUtils.copyRecursive() doesn't create parent directories.

Adding additional issue to issue list: 8368030: Make package bundlers stateless.

Adding additional issue to issue list: 8362598: [macos] Add tests for custom info plist files.

Adding additional issue to issue list: 8356047: [macos] jpackage produces confusing post- and pre- installation PKG scripts.

Adding additional issue to issue list: 8363979: Add JDK bundle/image validation for --runtime-image option.

Adding additional issue to issue list: 8356575: Test order in which jpackage fills app image.

Adding additional issue to issue list: 8370134: Fix minor jpackage issues.

Adding additional issue to issue list: 8370120: Make jpackage tests output more stable.

Adding additional issue to issue list: 8370136: Support async execution of jpackage tests.

Adding additional issue to issue list: 8370123: Minor jpackage refactoring.

Adding additional issue to issue list: 8370126: Improve jpackage signing testing.

Adding additional issue to issue list: 8356578: Test --mac-entitlements.

Adding additional issue to issue list: 8370122: jpackage test lib improvements.

Adding additional issue to issue list: 8370442: Compilation error in jpackage EntitlementsTest test.

Adding additional issue to issue list: 8370156: Fix jpackage IconTest.

Adding additional issue to issue list: 8370100: Redundant .png files in Linux app-image cause unnecessary bloat.

Adding additional issue to issue list: 8370956: ShortcutHintTest test fails when executed locally on Linux.
This issue is referenced in the PR title - it will now be updated.

[openjdk]

⚠️ @alexeysemenyukoracle could not find any commit with hash e0b463fe1a501b3d32853093fcbac1aee740f24f. Please update the title with the hash for an existing commit.

[alexeysemenyukoracle]

/issue add 8343220

[openjdk]

This backport pull request has now been updated with issue from the original commit.

[openjdk]

At least one of the issues associated with this backport has a resolved CSR for a different version. As this means that this backport may also need a CSR, the csr label is being added to this pull request to signal this potential requirement. The command /csr unneeded can be used to remove the label in case a CSR is not needed.

[openjdk]

@alexeysemenyukoracle
Adding additional issue to issue list: 8343220: Add test cases to AppContentTest jpackage test.

[mlbridge]

Webrevs

• 00: Full (be5fdb3f)

[alexeysemenyukoracle]

@aivanov-jdk please review

[aivanov-jdk]

It is easier and safer to bring in all prerequisite commits to get a clean backport than to backport an isolated fix.

I do agree with this statement, but combining 29 changesets into 1 backport is too much, in my opinion.

Moreover, the Developers' Guide recommends not to combining changes unless absolutely necessary. I don't mind a couple of changes combined to avoid known regressions, although I would still prefer doing separate backports in quick succession, yet it usually means doing more work because creating a PR for each changeset still takes time.

[aivanov-jdk]

You can request approvals for the bugs before you create the PRs and before the PRs are approved.

[alexeysemenyukoracle]

Thank you for the review. I'll close this PR and split it into smaller, more manageable pieces.