8359428: Test 'javax/swing/JTabbedPane/bug4499556.java' failed because after selecting one of L&F items, the test case automatically failed when clicking on L&F Menu button again

[srmandal]

PR Changes
It is seen that this test (which was opensourced in JDK-8353304) when run with NimbusLookAndFeel, after selecting one of L&F items, the test case automatically failed when clicking on L&F Menu button again.
It is because while switching to another L&F say platform(WindowsL&F) from Metal/Nimbus LookAndFeel, if testcase was originally run in Nimbus L&F, SynthMenuItemLayoutHelper() calls MenuItemLayoutHelper.reset where style.getFont(context) return null font so when it calls getFontMetrics(font) it calls font.hashCode which fails with

Execution failed: `main' threw exception: java.lang.NullPointerException: Cannot invoke "java.awt.Font.hashCode()" because "font" is null

This is happening because the test calls SwingUtilities.updateComponentTreeUI on tabbedpane.
So, when L&F is changed inside the test via "L&F Menu" option 1st time say Metal to Platform, it changes the L&F of the tabbed pane to Windows L&F, but not for the "L&F Menu" font itself which is still in Nimbus L&F, but style context is reset so when next time "L&F Menu" is clicked to change the L&F, SynthMenuItemLayoutHelper gets null font from invalid context and then it crashes.
Fix is to ensure the updateComponentTreeUI should be for entire frame which consists of "L&F Menu" and the tabs so L&F is changed consistently for all nodes.

Testing

[JTREG Testing] (1 manual test )

runner starting test: javax/swing/JTabbedPane/bug4499556.java

runner finished test: javax/swing/JTabbedPane/bug4499556.java

Passed. Execution successful

Test results: passed: 1

Conflicts
[MR clean check] (A Clean Backport) -Yes

[Are higher backports completed(25u,21u,17u,11u,8u etc) ?]
Applicable to 25u via this MR and the others are being worked upon.

[Does it contain multiple changesets ?] - No

---

Progress

• Change must not contain extraneous whitespace
• Commit message must refer to an issue
• JDK-8359428 needs maintainer approval

Issue

• JDK-8359428: Test 'javax/swing/JTabbedPane/bug4499556.java' failed because after selecting one of L&F items, the test case automatically failed when clicking on L&F Menu button again (Bug - P4 - Approved)

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk25u.git pull/50/head:pull/50
$ git checkout pull/50

Update a local copy of the PR:
$ git checkout pull/50
$ git pull https://git.openjdk.org/jdk25u.git pull/50/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 50

View PR using the GUI difftool:
$ git pr show -t 50

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk25u/pull/50.diff

Using Webrev

Link to Webrev Comment

[bridgekeeper]

👋 Welcome back smandalika! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

[openjdk]

@srmandal This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8359428: Test 'javax/swing/JTabbedPane/bug4499556.java' failed because after selecting one of L&F items, the test case automatically failed when clicking on L&F Menu button again

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 8 new commits pushed to the master branch:

• 4dc7684: 8361888: [GCC static analyzer] ProcessImpl_md.c Java_java_lang_ProcessImpl_forkAndExec error: use of uninitialized value '*(ChildStuff *)p.mode
• f730110: 8354447: Missing test for retroactive @SuppressWarnings("dangling-doc-comments") behavior
• 91b33c3: 8360022: ClassRefDupInConstantPoolTest.java fails when running in repeat
• ... and 5 more: https://git.openjdk.org/jdk25u/compare/6f743020562b02a5fe916f785e5d31cd8f4c4021...master

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

As you do not have Committer status in this project an existing Committer must agree to sponsor your change.

➡️ To flag this PR as ready for integration with the above commit message, type /integrate in a new comment. (Afterwards, your sponsor types /sponsor in a new comment to perform the integration).

[mlbridge]

Webrevs

• 00: Full (3b8c8eae)

[srmandal]

/approval JDK-8359428 request Clean backport, Code changes to ensure L&F switches run without exceptions.

[openjdk]

@srmandal
JDK-8359428: The approval request has been created successfully.

[openjdk]

This backport pull request has now been updated with issue from the original commit.

[openjdk]

@srmandal This pull request has not yet been marked as ready for integration.

[srmandal]

/integrate

[openjdk]

@srmandal
Your change (at version 3b8c8ea) is now ready to be sponsored by a Committer.

[shipilev]

/sponsor

[openjdk]

Going to push as commit 3db9097.
Since your change was applied there have been 35 commits pushed to the master branch:

• 4f99224: 8361478: GHA: Use MSYS2 from GHA runners
• 22183de: 8361255: CTW: Tolerate more NCDFE problems
• 2a68b5d: 8360867: CTW: Disable inline cache verification
• ... and 32 more: https://git.openjdk.org/jdk25u/compare/6f743020562b02a5fe916f785e5d31cd8f4c4021...master

Your commit was automatically rebased without conflicts.

[openjdk]

@shipilev @srmandal Pushed as commit 3db9097.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.