Skip to content

8364177: JDK fails to build due to undefined symbol in libpng on LoongArch64#61

Closed
theaoqi wants to merge 1 commit intoopenjdk:masterfrom
openjdk-bots:backport-theaoqi-a9f3d3a2-master
Closed

8364177: JDK fails to build due to undefined symbol in libpng on LoongArch64#61
theaoqi wants to merge 1 commit intoopenjdk:masterfrom
openjdk-bots:backport-theaoqi-a9f3d3a2-master

Conversation

@theaoqi
Copy link
Member

@theaoqi theaoqi commented Aug 5, 2025

Hi all,

This pull request contains a backport of commit a9f3d3a2 from the openjdk/jdk repository.

The commit being backported was authored by Ao Qi on 4 Aug 2025 and was reviewed by Phil Race, Alexey Ivanov and Erik Joelsson.

Testing:

  • linux-loongarch64-zero-release native build
  • linux-loongarch64-zero-fastdebug native build

Thanks!


Progress

  • Change must not contain extraneous whitespace
  • JDK-8364177 needs maintainer approval
  • Commit message must refer to an issue

Issue

  • JDK-8364177: JDK fails to build due to undefined symbol in libpng on LoongArch64 (Bug - P4 - Approved)

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk25u.git pull/61/head:pull/61
$ git checkout pull/61

Update a local copy of the PR:
$ git checkout pull/61
$ git pull https://git.openjdk.org/jdk25u.git pull/61/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 61

View PR using the GUI difftool:
$ git pr show -t 61

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk25u/pull/61.diff

Using Webrev

Link to Webrev Comment

@bridgekeeper
Copy link

bridgekeeper bot commented Aug 5, 2025

👋 Welcome back aoqi! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk
Copy link

openjdk bot commented Aug 5, 2025

@theaoqi This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8364177: JDK fails to build due to undefined symbol in libpng on LoongArch64

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 17 new commits pushed to the master branch:

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

As you do not have Committer status in this project an existing Committer must agree to sponsor your change.

➡️ To flag this PR as ready for integration with the above commit message, type /integrate in a new comment. (Afterwards, your sponsor types /sponsor in a new comment to perform the integration).

@openjdk openjdk bot changed the title Backport a9f3d3a290060f98967feaad2fa03ef077a64534 8364177: JDK fails to build due to undefined symbol in libpng on LoongArch64 Aug 5, 2025
@openjdk
Copy link

openjdk bot commented Aug 5, 2025

This backport pull request has now been updated with issue from the original commit.

@openjdk openjdk bot added backport Port of a pull request already in a different code base clean Identical backport; no merge resolution required labels Aug 5, 2025
@theaoqi theaoqi marked this pull request as ready for review August 5, 2025 02:00
@openjdk
Copy link

openjdk bot commented Aug 5, 2025

⚠️ @theaoqi This change is now ready for you to apply for maintainer approval. This can be done directly in each associated issue or by using the /approval command.

@openjdk openjdk bot added the rfr Pull request is ready for review label Aug 5, 2025
@mlbridge
Copy link

mlbridge bot commented Aug 5, 2025

Webrevs

@theaoqi
Copy link
Member Author

theaoqi commented Aug 6, 2025

/approval request The backport is clean. This patch fixes a build issue with the zero build on some loongarch platforms. This patch affects a client-libs CFLAGS macro definition, which only works on LoongArch. The loongarch zero builds passed.

@openjdk
Copy link

openjdk bot commented Aug 6, 2025

@theaoqi
8364177: The approval request has been created successfully.

@openjdk openjdk bot added approval Requires approval; will be removed when approval is received ready Pull request is ready to be integrated and removed approval Requires approval; will be removed when approval is received labels Aug 6, 2025
@theaoqi
Copy link
Member Author

theaoqi commented Aug 9, 2025

/integrate

@openjdk openjdk bot added the sponsor Pull request is ready to be sponsored label Aug 9, 2025
@openjdk
Copy link

openjdk bot commented Aug 9, 2025

@theaoqi
Your change (at version bde7e73) is now ready to be sponsored by a Committer.

@shipilev
Copy link
Member

/sponsor

@openjdk
Copy link

openjdk bot commented Aug 11, 2025

Going to push as commit 3ee05cd.
Since your change was applied there have been 22 commits pushed to the master branch:

Your commit was automatically rebased without conflicts.

@openjdk openjdk bot added the integrated Pull request has been integrated label Aug 11, 2025
@openjdk openjdk bot closed this Aug 11, 2025
@openjdk openjdk bot removed ready Pull request is ready to be integrated rfr Pull request is ready for review sponsor Pull request is ready to be sponsored labels Aug 11, 2025
@openjdk
Copy link

openjdk bot commented Aug 11, 2025

@shipilev @theaoqi Pushed as commit 3ee05cd.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

@theaoqi
Copy link
Member Author

theaoqi commented Aug 11, 2025

Thank you for sponsoring, @shipilev.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

backport Port of a pull request already in a different code base clean Identical backport; no merge resolution required integrated Pull request has been integrated

Development

Successfully merging this pull request may close these issues.

2 participants