Skip to content

8374434: Several JShell tests report JUnit discovery warnings#19

Closed
Shivangi-aa wants to merge 1 commit intoopenjdk:masterfrom
Shivangi-aa:backport-8374434
Closed

8374434: Several JShell tests report JUnit discovery warnings#19
Shivangi-aa wants to merge 1 commit intoopenjdk:masterfrom
Shivangi-aa:backport-8374434

Conversation

@Shivangi-aa
Copy link

@Shivangi-aa Shivangi-aa commented Jan 20, 2026

Straight Backport. Ran the tests ,all passed.


Progress

  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue
  • JDK-8374434 needs maintainer approval

Issue

  • JDK-8374434: Several JShell tests report JUnit discovery warnings (Bug - P4 - Approved)

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk26u.git pull/19/head:pull/19
$ git checkout pull/19

Update a local copy of the PR:
$ git checkout pull/19
$ git pull https://git.openjdk.org/jdk26u.git pull/19/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 19

View PR using the GUI difftool:
$ git pr show -t 19

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk26u/pull/19.diff

Using Webrev

Link to Webrev Comment

@bridgekeeper
Copy link

bridgekeeper bot commented Jan 20, 2026

👋 Welcome back sshivang! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk
Copy link

openjdk bot commented Jan 20, 2026

@Shivangi-aa This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8374434: Several JShell tests report JUnit discovery warnings

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 2 new commits pushed to the master branch:

  • f414153: 8375063: Update Libpng to 1.6.54
  • 9447b25: 8373632: Some sound tests failing in CI due to lack of sound key

Please see this link for an up-to-date comparison between the source branch of this pull request and the master branch.
As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

As you do not have Committer status in this project an existing Committer must agree to sponsor your change.

➡️ To flag this PR as ready for integration with the above commit message, type /integrate in a new comment. (Afterwards, your sponsor types /sponsor in a new comment to perform the integration).

@openjdk openjdk bot changed the title Backport e6abf98e35079ed1b5547f2cc0ac6f518b78d67b 8374434: Several JShell tests report JUnit discovery warnings Jan 20, 2026
@openjdk
Copy link

openjdk bot commented Jan 20, 2026

This backport pull request has now been updated with issue from the original commit.

@openjdk openjdk bot added backport Port of a pull request already in a different code base clean Identical backport; no merge resolution required labels Jan 20, 2026
@openjdk
Copy link

openjdk bot commented Jan 20, 2026

⚠️ @Shivangi-aa This change is now ready for you to apply for maintainer approval. This can be done directly in each associated issue or by using the /approval command.

@openjdk openjdk bot added the rfr Pull request is ready for review label Jan 20, 2026
@Shivangi-aa
Copy link
Author

/approval JDK-8374434 request Test only fix. Needed in lower releases.

@openjdk
Copy link

openjdk bot commented Jan 20, 2026

@Shivangi-aa
JDK-8374434: The approval request has been created successfully.

@mlbridge
Copy link

mlbridge bot commented Jan 20, 2026

Webrevs

@openjdk openjdk bot added approval Requires approval; will be removed when approval is received ready Pull request is ready to be integrated and removed approval Requires approval; will be removed when approval is received labels Jan 20, 2026
@Shivangi-aa
Copy link
Author

/integrate

@openjdk openjdk bot added the sponsor Pull request is ready to be sponsored label Jan 21, 2026
@openjdk
Copy link

openjdk bot commented Jan 21, 2026

@Shivangi-aa
Your change (at version 335dc4b) is now ready to be sponsored by a Committer.

@coffeys
Copy link

coffeys commented Jan 21, 2026

/sponsor

@openjdk
Copy link

openjdk bot commented Jan 21, 2026

Going to push as commit 207722a.
Since your change was applied there have been 2 commits pushed to the master branch:

  • f414153: 8375063: Update Libpng to 1.6.54
  • 9447b25: 8373632: Some sound tests failing in CI due to lack of sound key

Your commit was automatically rebased without conflicts.

@openjdk openjdk bot added the integrated Pull request has been integrated label Jan 21, 2026
@openjdk openjdk bot closed this Jan 21, 2026
@openjdk openjdk bot removed ready Pull request is ready to be integrated rfr Pull request is ready for review sponsor Pull request is ready to be sponsored labels Jan 21, 2026
@openjdk
Copy link

openjdk bot commented Jan 21, 2026

@coffeys @Shivangi-aa Pushed as commit 207722a.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

backport Port of a pull request already in a different code base clean Identical backport; no merge resolution required integrated Pull request has been integrated

Development

Successfully merging this pull request may close these issues.

2 participants