8373101: JdkClient and JdkServer test classes ignore namedGroups field#30
8373101: JdkClient and JdkServer test classes ignore namedGroups field#30Shivangi-aa wants to merge 1 commit intoopenjdk:masterfrom
Conversation
|
👋 Welcome back sshivang! A progress list of the required criteria for merging this PR into |
|
@Shivangi-aa This change now passes all automated pre-integration checks. ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details. After integration, the commit message for the final commit will be: You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed. At the time when this comment was updated there had been 1 new commit pushed to the
Please see this link for an up-to-date comparison between the source branch of this pull request and the As you do not have Committer status in this project an existing Committer must agree to sponsor your change. ➡️ To flag this PR as ready for integration with the above commit message, type |
|
This backport pull request has now been updated with issue from the original commit. |
|
|
|
/approval JDK-8373101 request Test only fix.Need for other PQC related backports to be done in lower releases. |
|
@Shivangi-aa |
|
/integrate |
|
@Shivangi-aa |
|
/sponsor |
|
Going to push as commit bea39a1.
Your commit was automatically rebased without conflicts. |
|
@coffeys @Shivangi-aa Pushed as commit bea39a1. 💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored. |
TLSCommon tests passed after this change.
Straight Backport.
Progress
Issue
Reviewing
Using
gitCheckout this PR locally:
$ git fetch https://git.openjdk.org/jdk26u.git pull/30/head:pull/30$ git checkout pull/30Update a local copy of the PR:
$ git checkout pull/30$ git pull https://git.openjdk.org/jdk26u.git pull/30/headUsing Skara CLI tools
Checkout this PR locally:
$ git pr checkout 30View PR using the GUI difftool:
$ git pr show -t 30Using diff file
Download this PR as a diff file:
https://git.openjdk.org/jdk26u/pull/30.diff
Using Webrev
Link to Webrev Comment