Skip to content
This repository was archived by the owner on Apr 21, 2023. It is now read-only.

Conversation

@yan-too
Copy link

@yan-too yan-too commented May 31, 2022

I need to backport this change to 7u to facilitate other updates. Tests run fine (with testng 6)


Progress

  • Change must be properly reviewed (1 review required, with at least 1 Reviewer)
  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue

Issue

  • JDK-8087283: Add support for the XML Signature here() function to the JDK XPath implementation

Reviewers

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.java.net/jdk7u pull/6/head:pull/6
$ git checkout pull/6

Update a local copy of the PR:
$ git checkout pull/6
$ git pull https://git.openjdk.java.net/jdk7u pull/6/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 6

View PR using the GUI difftool:
$ git pr show -t 6

Using diff file

Download this PR as a diff file:
https://git.openjdk.java.net/jdk7u/pull/6.diff

@bridgekeeper
Copy link

bridgekeeper bot commented May 31, 2022

👋 Welcome back yan! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk openjdk bot changed the title Backport 22fad64529a890dd3ae8b07c7981d9a720cf8e96 8087283: Add support for the XML Signature here() function to the JDK XPath implementation May 31, 2022
@openjdk
Copy link

openjdk bot commented May 31, 2022

This backport pull request has now been updated with issue from the original commit.

@openjdk openjdk bot added backport rfr Pull request is ready for review labels May 31, 2022
@mlbridge
Copy link

mlbridge bot commented May 31, 2022

Webrevs

@openjdk
Copy link

openjdk bot commented May 31, 2022

@yan-too This change now passes all automated pre-integration checks.

After integration, the commit message for the final commit will be:

8087283: Add support for the XML Signature here() function to the JDK XPath implementation

Reviewed-by: bae

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been no new commits pushed to the master branch. If another commit should be pushed before you perform the /integrate command, your PR will be automatically rebased. If you prefer to avoid any potential automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

@openjdk openjdk bot added the ready Pull request is ready to be integrated label May 31, 2022
@yan-too
Copy link
Author

yan-too commented May 31, 2022

/integrate

@openjdk
Copy link

openjdk bot commented May 31, 2022

Going to push as commit bc575d0.

@openjdk openjdk bot added the integrated Pull request has been integrated label May 31, 2022
@openjdk openjdk bot closed this May 31, 2022
@openjdk openjdk bot removed ready Pull request is ready to be integrated rfr Pull request is ready for review labels May 31, 2022
@openjdk
Copy link

openjdk bot commented May 31, 2022

@yan-too Pushed as commit bc575d0.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

@yan-too yan-too deleted the bp8087283 branch May 31, 2022 13:10
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

backport integrated Pull request has been integrated

Development

Successfully merging this pull request may close these issues.

2 participants