Skip to content
This repository has been archived by the owner on Apr 21, 2023. It is now read-only.
/ jdk7u Public archive

8285445: cannot open file "NUL:" #9

Closed
wants to merge 1 commit into from

Conversation

omikhaltsova
Copy link

@omikhaltsova omikhaltsova commented Jun 29, 2022

I'd like to backport JDK-8285445 to jdk7u.

The patch applied not cleanly due to the directory structure differences:

  1. src/java.base/windows/classes/java/io/WinNTFileSystem.java-> jdk/src/windows/classes/java/io/Win32FileSystem.java
  2. test/jdk/java/io/FileOutputStream/OpenNUL.java-> jdk/test/java/io/FileOutputStream/OpenNUL.java

Tested manually as follow:
$JTREG_HOME/bin/jtreg -jdk:$BUILD_HOME /cygdrive/c/projects/jdk7u-fork/jdk/test/java/io/
No regression in the above tests' group.


Progress

  • Change must be properly reviewed (1 review required, with at least 1 Reviewer)
  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue

Issue

Reviewers

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk7u pull/9/head:pull/9
$ git checkout pull/9

Update a local copy of the PR:
$ git checkout pull/9
$ git pull https://git.openjdk.org/jdk7u pull/9/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 9

View PR using the GUI difftool:
$ git pr show -t 9

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk7u/pull/9.diff

@bridgekeeper
Copy link

bridgekeeper bot commented Jun 29, 2022

👋 Welcome back omikhaltcova! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk openjdk bot changed the title Backport 03cbb48e6a1d806f204a39bbdbb4bc9be9e57a41 8285445: cannot open file "NUL:" Jun 29, 2022
@openjdk
Copy link

openjdk bot commented Jun 29, 2022

This backport pull request has now been updated with issue from the original commit.

@openjdk openjdk bot added backport rfr Pull request is ready for review labels Jun 29, 2022
@mlbridge
Copy link

mlbridge bot commented Jun 29, 2022

Webrevs

Copy link
Member

@phohensee phohensee left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks identical to the 8u backport. Lgtm.

@openjdk
Copy link

openjdk bot commented Jun 29, 2022

@omikhaltsova This change now passes all automated pre-integration checks.

After integration, the commit message for the final commit will be:

8285445: cannot open file "NUL:"

Reviewed-by: phh

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been no new commits pushed to the master branch. If another commit should be pushed before you perform the /integrate command, your PR will be automatically rebased. If you prefer to avoid any potential automatic rebasing, please check the documentation for the /integrate command for further details.

As you do not have Committer status in this project an existing Committer must agree to sponsor your change. Possible candidates are the reviewers of this PR (@phohensee) but any other Committer may sponsor as well.

➡️ To flag this PR as ready for integration with the above commit message, type /integrate in a new comment. (Afterwards, your sponsor types /sponsor in a new comment to perform the integration).

@openjdk openjdk bot added the ready Pull request is ready to be integrated label Jun 29, 2022
@omikhaltsova
Copy link
Author

yes, it's identical to 8u.

@omikhaltsova
Copy link
Author

/integrate

@openjdk openjdk bot added the sponsor Pull request is ready to be sponsored label Jun 29, 2022
@openjdk
Copy link

openjdk bot commented Jun 29, 2022

@omikhaltsova
Your change (at version 34ee5bf) is now ready to be sponsored by a Committer.

@bae
Copy link

bae commented Jun 29, 2022

/sponsor

@openjdk
Copy link

openjdk bot commented Jun 29, 2022

Going to push as commit cb07ad2.

@openjdk openjdk bot added the integrated Pull request has been integrated label Jun 29, 2022
@openjdk openjdk bot closed this Jun 29, 2022
@openjdk openjdk bot removed ready Pull request is ready to be integrated rfr Pull request is ready for review sponsor Pull request is ready to be sponsored labels Jun 29, 2022
@openjdk
Copy link

openjdk bot commented Jun 29, 2022

@bae @omikhaltsova Pushed as commit cb07ad2.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
backport integrated Pull request has been integrated
Development

Successfully merging this pull request may close these issues.

3 participants