-
Notifications
You must be signed in to change notification settings - Fork 25
Conversation
👋 Welcome back omikhaltcova! A progress list of the required criteria for merging this PR into |
This backport pull request has now been updated with issue from the original commit. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks identical to the 8u backport. Lgtm.
@omikhaltsova This change now passes all automated pre-integration checks. After integration, the commit message for the final commit will be:
You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed. At the time when this comment was updated there had been no new commits pushed to the As you do not have Committer status in this project an existing Committer must agree to sponsor your change. Possible candidates are the reviewers of this PR (@phohensee) but any other Committer may sponsor as well. ➡️ To flag this PR as ready for integration with the above commit message, type |
yes, it's identical to 8u. |
/integrate |
@omikhaltsova |
/sponsor |
Going to push as commit cb07ad2. |
@bae @omikhaltsova Pushed as commit cb07ad2. 💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored. |
I'd like to backport JDK-8285445 to jdk7u.
The patch applied not cleanly due to the directory structure differences:
src/java.base/windows/classes/java/io/WinNTFileSystem.java
->jdk/src/windows/classes/java/io/Win32FileSystem.java
test/jdk/java/io/FileOutputStream/OpenNUL.java
->jdk/test/java/io/FileOutputStream/OpenNUL.java
Tested manually as follow:
$JTREG_HOME/bin/jtreg -jdk:$BUILD_HOME /cygdrive/c/projects/jdk7u-fork/jdk/test/java/io/
No regression in the above tests' group.
Progress
Issue
Reviewers
Reviewing
Using
git
Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk7u pull/9/head:pull/9
$ git checkout pull/9
Update a local copy of the PR:
$ git checkout pull/9
$ git pull https://git.openjdk.org/jdk7u pull/9/head
Using Skara CLI tools
Checkout this PR locally:
$ git pr checkout 9
View PR using the GUI difftool:
$ git pr show -t 9
Using diff file
Download this PR as a diff file:
https://git.openjdk.org/jdk7u/pull/9.diff