-
Notifications
You must be signed in to change notification settings - Fork 149
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
8282947: JFR: Dump on shutdown live-locks in some conditions
Reviewed-by: phh Backport-of: 63eb0b7e8606dd9cd145e92eeeb744ff5b7be569
- Loading branch information
Jiří Vaněk
authored and
Paul Hohensee
committed
Feb 15, 2023
1 parent
c183dc5
commit ec53e00
Showing
3 changed files
with
65 additions
and
4 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,54 @@ | ||
/* | ||
* Copyright (c) 2022, Oracle and/or its affiliates. All rights reserved. | ||
* DO NOT ALTER OR REMOVE COPYRIGHT NOTICES OR THIS FILE HEADER. | ||
* | ||
* This code is free software; you can redistribute it and/or modify it | ||
* under the terms of the GNU General Public License version 2 only, as | ||
* published by the Free Software Foundation. | ||
* | ||
* This code is distributed in the hope that it will be useful, but WITHOUT | ||
* ANY WARRANTY; without even the implied warranty of MERCHANTABILITY or | ||
* FITNESS FOR A PARTICULAR PURPOSE. See the GNU General Public License | ||
* version 2 for more details (a copy is included in the LICENSE file that | ||
* accompanied this code). | ||
* | ||
* You should have received a copy of the GNU General Public License version | ||
* 2 along with this work; if not, write to the Free Software Foundation, | ||
* Inc., 51 Franklin St, Fifth Floor, Boston, MA 02110-1301 USA. | ||
* | ||
* Please contact Oracle, 500 Oracle Parkway, Redwood Shores, CA 94065 USA | ||
* or visit www.oracle.com if you need additional information or have any | ||
* questions. | ||
*/ | ||
|
||
package jdk.jfr.api.recording.dump; | ||
|
||
import java.io.File; | ||
|
||
import jdk.jfr.Recording; | ||
|
||
/** | ||
* @test | ||
* @summary Tests that it's possible to dump to /dev/null without a livelock | ||
* @key jfr | ||
* | ||
* @library /lib / | ||
* @run main/othervm jdk.jfr.api.recording.dump.TestDumpDevNull | ||
*/ | ||
public class TestDumpDevNull { | ||
|
||
public static void main(String[] args) throws Exception { | ||
try (Recording r1 = new Recording()) { | ||
r1.setDestination(new File("/dev/null").toPath()); | ||
r1.start(); | ||
// Force a chunk rotation which ensures that jdk.jfr.internal.ChunkChannel | ||
// invokes FileChannel::transferFrom(ReadableByteChannel, position, count) twice. | ||
// FileChannel will return 0 the second time because position exceeds | ||
// FileChannel::size(), which is always 0 for /dev/null | ||
// Without proper handling of return value 0, the ChunkChannel will spin indefinitely. | ||
try (Recording r2 = new Recording()) { | ||
r2.start(); | ||
} | ||
} | ||
} | ||
} |
ec53e00
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Review
Issues