8202142: jfr/event/io/TestInstrumentation is unstable

[dongbohe]

Hi,

This PR has been reviewed by Paul before move to github: https://mail.openjdk.java.net/pipermail/jdk8u-dev/2022-January/014489.html

Thanks,
hedongbo

---

Progress

• Change must not contain extraneous whitespace
• Commit message must refer to an issue
• Change must be properly reviewed (1 review required, with at least 1 reviewer)

Issue

• JDK-8202142: jfr/event/io/TestInstrumentation is unstable

Reviewers

• Paul Hohensee (@phohensee - Reviewer) ⚠️ Review applies to 7fbbc697
• Zhengyu Gu (@zhengyu123 - Reviewer)

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.java.net/jdk8u-dev pull/10/head:pull/10
$ git checkout pull/10

Update a local copy of the PR:
$ git checkout pull/10
$ git pull https://git.openjdk.java.net/jdk8u-dev pull/10/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 10

View PR using the GUI difftool:
$ git pr show -t 10

Using diff file

Download this PR as a diff file:
https://git.openjdk.java.net/jdk8u-dev/pull/10.diff

[bridgekeeper]

👋 Welcome back dongbohe! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

[openjdk]

This backport pull request has now been updated with issue from the original commit.

[mlbridge]

Webrevs

• 01: Full (3785dcd0)
• 00: Full (7fbbc697)

[zhengyu123]

I think should backport 8223396 first to eliminate another out-of-order backport.

[phohensee]

Lgtm (again).

[openjdk]

@dongbohe This change now passes all automated pre-integration checks.

After integration, the commit message for the final commit will be:

8202142: jfr/event/io/TestInstrumentation is unstable

Reviewed-by: phh, zgu

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 50 new commits pushed to the master branch:

• d35dea7: 8266187: Memory leak in appendBootClassPath()
• 83fbc96: 8283350: (tz) Update Timezone Data to 2022a
• c5f96be: 8286989: Build failure on macOS after 8281814
• 7961755: 8285727: [11u, 17u] Unify fix for JDK-8284920 with version from head
• eb5711b: 8284620: CodeBuffer may leak _overflow_arena
• db52470: 8285523: Improve test java/io/FileOutputStream/OpenNUL.java
• 3e0eb09: 8248876: LoadObject with bad base address created for exec file on linux
• 6b94b65: 8278138: OpenJDK8 fails to start on Windows 8.1 after upgrading compiler to VS2017
• 680b09c: 8168926: C2: Bytecode escape analyzer crashes due to stack overflow
• 51f69d9: 8221988: add possibility to build with Visual Studio 2019
• ... and 40 more: https://git.openjdk.java.net/jdk8u-dev/compare/57d8d29080414dd038fffff1b97d97f3ab3f1570...master

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

As you do not have Committer status in this project an existing Committer must agree to sponsor your change. Possible candidates are the reviewers of this PR (@phohensee, @zhengyu123) but any other Committer may sponsor as well.

➡️ To flag this PR as ready for integration with the above commit message, type /integrate in a new comment. (Afterwards, your sponsor types /sponsor in a new comment to perform the integration).

[dongbohe]

I think should backport 8223396 first to eliminate another out-of-order backport.

Hi, Zhengyu. I have created #14 to backport 8223396.

[dongbohe]

I think should backport 8223396 first to eliminate another out-of-order backport.

Hi, Zhengyu

8223396 has been merged into 8u in #14, can you help me look at this again?

[dongbohe]

@zhengyu123 Could you please take another look?

[bridgekeeper]

@dongbohe This pull request has been inactive for more than 4 weeks and will be automatically closed if another 4 weeks passes without any activity. To avoid this, simply add a new comment to the pull request. Feel free to ask for assistance if you need help with progressing this pull request towards integration!

[phohensee]

/sponsor

Got the approval.

[openjdk]

@phohensee The change author (@dongbohe) must issue an integrate command before the integration can be sponsored.

[phohensee]

@dongbohe, please add a /integrate comment so I can sponsor.

[zhengyu123]

@zhengyu123 Could you please take another look?

Sorry, I did not get notification somehow. LGTM

[zhengyu123]

LGTM

[dongbohe]

/integrate

[openjdk]

@dongbohe
Your change (at version 3785dcd) is now ready to be sponsored by a Committer.

[phohensee]

/sponsor

[openjdk]

Going to push as commit 2194c53.
Since your change was applied there have been 50 commits pushed to the master branch:

• d35dea7: 8266187: Memory leak in appendBootClassPath()
• 83fbc96: 8283350: (tz) Update Timezone Data to 2022a
• c5f96be: 8286989: Build failure on macOS after 8281814
• 7961755: 8285727: [11u, 17u] Unify fix for JDK-8284920 with version from head
• eb5711b: 8284620: CodeBuffer may leak _overflow_arena
• db52470: 8285523: Improve test java/io/FileOutputStream/OpenNUL.java
• 3e0eb09: 8248876: LoadObject with bad base address created for exec file on linux
• 6b94b65: 8278138: OpenJDK8 fails to start on Windows 8.1 after upgrading compiler to VS2017
• 680b09c: 8168926: C2: Bytecode escape analyzer crashes due to stack overflow
• 51f69d9: 8221988: add possibility to build with Visual Studio 2019
• ... and 40 more: https://git.openjdk.java.net/jdk8u-dev/compare/57d8d29080414dd038fffff1b97d97f3ab3f1570...master

Your commit was automatically rebased without conflicts.

[openjdk]

@phohensee @dongbohe Pushed as commit 2194c53.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.