Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

8285400: Add '@apiNote' to the APIs defined in Java SE 8 MR 3 #103

Closed
wants to merge 2 commits into from

Conversation

poonamparhar
Copy link
Member

@poonamparhar poonamparhar commented Aug 15, 2022

This changeset is a backport of JDK-8285400 from jdk8u-ri to jdk8u-dev. It is a clean backport other than the manual update of the copyright years.

This change adds "apiNote This method is defined in Java SE 8 Maintenance Release 3." to the doc comments of the new APIs added with the following changesets in Java SE MR3 :

https://hg.openjdk.java.net/jdk8u/jdk8u41/jdk/rev/b26b096d4c89
https://hg.openjdk.java.net/jdk8u/jdk8u41/jdk/rev/6bada58189de

Progress

  • Change must be properly reviewed (1 review required, with at least 1 Reviewer)
  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue

Issue

Reviewers

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk8u-dev pull/103/head:pull/103
$ git checkout pull/103

Update a local copy of the PR:
$ git checkout pull/103
$ git pull https://git.openjdk.org/jdk8u-dev pull/103/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 103

View PR using the GUI difftool:
$ git pr show -t 103

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk8u-dev/pull/103.diff

@bridgekeeper
Copy link

bridgekeeper bot commented Aug 15, 2022

👋 Welcome back poonam! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk openjdk bot changed the title Backport 3740d05c063e1f80a0808a969a2cc136cafa48cb 8285400: Add '@apiNote' to the APIs defined in Java SE 8 MR 3 Aug 15, 2022
@openjdk
Copy link

openjdk bot commented Aug 15, 2022

This backport pull request has now been updated with issue from the original commit.

@openjdk openjdk bot added backport rfr Pull request is ready for review labels Aug 15, 2022
@mlbridge
Copy link

mlbridge bot commented Aug 15, 2022

Webrevs

Copy link
Member

@mlchung mlchung left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good.

@openjdk
Copy link

openjdk bot commented Aug 15, 2022

@poonamparhar This change now passes all automated pre-integration checks.

After integration, the commit message for the final commit will be:

8285400: Add '@apiNote' to the APIs defined in Java SE 8 MR 3

Reviewed-by: mchung, iris, andrew

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 3 new commits pushed to the master branch:

  • 4cc462a: 8214427: probable bug in logic of ConcurrentHashMap.addCount()
  • 645b6c8: 8288763: Pack200 extraction failure with invalid size
  • 8e2c498: 8245263: Enable TLSv1.3 by default on JDK 8u for Client roles

Please see this link for an up-to-date comparison between the source branch of this pull request and the master branch.
As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

@openjdk openjdk bot added the ready Pull request is ready to be integrated label Aug 15, 2022
Copy link
Member

@irisclark irisclark left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copy link
Member

@gnu-andrew gnu-andrew left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Backport looks good. Thanks for adjusting all those troublesome copyright headers!

I'm remember this being discussed when the MR3 changes were merged so it is good to see this update. Approved.

@poonamparhar
Copy link
Member Author

/integrate

@openjdk
Copy link

openjdk bot commented Aug 22, 2022

Going to push as commit 8ad9018.
Since your change was applied there have been 7 commits pushed to the master branch:

  • 3a5b2cd: 8201793: (ref) Reference object should not support cloning
  • 1b52b01: 8183107: PKCS11 regression regarding checkKeySize
  • e633df1: 8175797: (ref) Reference::enqueue method should clear the reference object before enqueuing
  • 5323ef6: 8254178: Remove .hgignore
  • 4cc462a: 8214427: probable bug in logic of ConcurrentHashMap.addCount()
  • 645b6c8: 8288763: Pack200 extraction failure with invalid size
  • 8e2c498: 8245263: Enable TLSv1.3 by default on JDK 8u for Client roles

Your commit was automatically rebased without conflicts.

@openjdk openjdk bot added the integrated Pull request has been integrated label Aug 22, 2022
@openjdk openjdk bot closed this Aug 22, 2022
@openjdk openjdk bot removed ready Pull request is ready to be integrated rfr Pull request is ready for review labels Aug 22, 2022
@openjdk
Copy link

openjdk bot commented Aug 22, 2022

@poonamparhar Pushed as commit 8ad9018.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport integrated Pull request has been integrated
4 participants