-
Notifications
You must be signed in to change notification settings - Fork 145
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
8254318: Remove .hgtags #108
Conversation
👋 Welcome back gdams! A progress list of the required criteria for merging this PR into |
This backport pull request has now been updated with issue from the original commit. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me. Are you able to add jdk8u-fix-request
now? I see an authorship status: https://openjdk.org/census#gdams If not, i can do so (and approve at the same time)
@gnu-andrew added the fix request |
@gdams This change now passes all automated pre-integration checks. After integration, the commit message for the final commit will be:
You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed. At the time when this comment was updated there had been 5 new commits pushed to the
Please see this link for an up-to-date comparison between the source branch of this pull request and the As you do not have Committer status in this project an existing Committer must agree to sponsor your change. Possible candidates are the reviewers of this PR (@gnu-andrew) but any other Committer may sponsor as well. ➡️ To flag this PR as ready for integration with the above commit message, type |
Approved. |
/integrate |
/sponsor |
Going to push as commit a4d4973.
Your commit was automatically rebased without conflicts. |
@RealCLanger @gdams Pushed as commit a4d4973. 💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored. |
Removes unused .hgtags files after the Git move. No code change. Low risk
Progress
Issue
Reviewers
Reviewing
Using
git
Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk8u-dev pull/108/head:pull/108
$ git checkout pull/108
Update a local copy of the PR:
$ git checkout pull/108
$ git pull https://git.openjdk.org/jdk8u-dev pull/108/head
Using Skara CLI tools
Checkout this PR locally:
$ git pr checkout 108
View PR using the GUI difftool:
$ git pr show -t 108
Using diff file
Download this PR as a diff file:
https://git.openjdk.org/jdk8u-dev/pull/108.diff