8232950: SUNPKCS11 Provider incorrectly check key length for PSS Signatures.

[zzambers]

This is backport of JDK-8183107 [1]. When dealt with different paths on jdk8, patch extracted from jdk project applied cleanly.

git apply -p3 --dir=jdk/src 0001-8232950-SUNPKCS11-Provider-incorrectly-check-key-len.patch

Tested locally, no regressions in jdk_security tests.

[1] https://bugs.openjdk.org/browse/JDK-8232950

---

Progress

• Change must not contain extraneous whitespace
• Commit message must refer to an issue

Issue

• JDK-8232950: SUNPKCS11 Provider incorrectly check key length for PSS Signatures.

Reviewers

• Andrew John Hughes (@gnu-andrew - Reviewer)

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk8u-dev pull/109/head:pull/109
$ git checkout pull/109

Update a local copy of the PR:
$ git checkout pull/109
$ git pull https://git.openjdk.org/jdk8u-dev pull/109/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 109

View PR using the GUI difftool:
$ git pr show -t 109

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk8u-dev/pull/109.diff

[bridgekeeper]

👋 Welcome back zzambers! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

[openjdk]

This backport pull request has now been updated with issue and summary from the original commit.

[mlbridge]

Webrevs

• 00: Full (cfa82b42)

[gnu-andrew]

Looks fine, clean backport.

[gnu-andrew]

/clean

[gnu-andrew]

Approved for 8u

[openjdk]

@zzambers This change now passes all automated pre-integration checks.

After integration, the commit message for the final commit will be:

8232950: SUNPKCS11 Provider incorrectly check key length for PSS Signatures.

Fixed to treat the queried key size values as bits instead of bytes

Reviewed-by: andrew

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 2 new commits pushed to the master branch:

• 8ad9018: 8285400: Add '@APinote' to the APIs defined in Java SE 8 MR 3
• 3a5b2cd: 8201793: (ref) Reference object should not support cloning

Please see this link for an up-to-date comparison between the source branch of this pull request and the master branch.
As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

As you do not have Committer status in this project an existing Committer must agree to sponsor your change. Possible candidates are the reviewers of this PR (@gnu-andrew) but any other Committer may sponsor as well.

➡️ To flag this PR as ready for integration with the above commit message, type /integrate in a new comment. (Afterwards, your sponsor types /sponsor in a new comment to perform the integration).

[openjdk]

@gnu-andrew This backport pull request is now marked as clean

[zzambers]

@gnu-andrew thanks
/integrate

[openjdk]

@zzambers
Your change (at version cfa82b4) is now ready to be sponsored by a Committer.

[gnu-andrew]

/sponsor

[openjdk]

Going to push as commit e3251a2.
Since your change was applied there have been 4 commits pushed to the master branch:

• 41c7d2d: 8039955: [TESTBUG] jdk/lambda/LambdaTranslationTest1 - java.lang.AssertionError: expected [d:1234.000000] but found [d:1234,000000]
• a4d4973: 8254318: Remove .hgtags
• 8ad9018: 8285400: Add '@APinote' to the APIs defined in Java SE 8 MR 3
• 3a5b2cd: 8201793: (ref) Reference object should not support cloning

Your commit was automatically rebased without conflicts.

[openjdk]

@gnu-andrew @zzambers Pushed as commit e3251a2.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.