Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

8049228: Improve multithreaded scalability of InetAddress cache #113

Closed
wants to merge 1 commit into from

Conversation

lusou-zhangquan
Copy link

@lusou-zhangquan lusou-zhangquan commented Aug 25, 2022

Refresh #70


Progress

  • Change must be properly reviewed (1 review required, with at least 1 Reviewer)
  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue

Issues

  • JDK-8049228: Improve multithreaded scalability of InetAddress cache
  • JDK-7186258: InetAddress$Cache should replace currentTimeMillis with nanoTime for more precise and accurate

Reviewers

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk8u-dev pull/113/head:pull/113
$ git checkout pull/113

Update a local copy of the PR:
$ git checkout pull/113
$ git pull https://git.openjdk.org/jdk8u-dev pull/113/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 113

View PR using the GUI difftool:
$ git pr show -t 113

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk8u-dev/pull/113.diff

Backport-of 250fbb065a789a303d692d698c9b69117bf6cd2c
@bridgekeeper
Copy link

bridgekeeper bot commented Aug 25, 2022

👋 Welcome back lusou-zhangquan! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk openjdk bot changed the title Backport 250fbb065a789a303d692d698c9b69117bf6cd2c 8049228: Improve multithreaded scalability of InetAddress cache Aug 25, 2022
@openjdk
Copy link

openjdk bot commented Aug 25, 2022

This backport pull request has now been updated with issues from the original commit.

@openjdk openjdk bot added backport rfr Pull request is ready for review labels Aug 25, 2022
@mlbridge
Copy link

mlbridge bot commented Aug 25, 2022

Webrevs

Copy link
Member

@gnu-andrew gnu-andrew left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Patch is identical to the one I reviewed for #70
Bug is already approved so let's just do /integrate and get this in :-)

@openjdk
Copy link

openjdk bot commented Aug 25, 2022

@lusou-zhangquan This change now passes all automated pre-integration checks.

After integration, the commit message for the final commit will be:

8049228: Improve multithreaded scalability of InetAddress cache
7186258: InetAddress$Cache should replace currentTimeMillis with nanoTime for more precise and accurate

Reviewed-by: andrew, phh

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 43 new commits pushed to the master branch:

  • d0ad242: 8285497: Add system property for Java SE specification maintenance version
  • e3251a2: 8232950: SUNPKCS11 Provider incorrectly check key length for PSS Signatures.
  • 41c7d2d: 8039955: [TESTBUG] jdk/lambda/LambdaTranslationTest1 - java.lang.AssertionError: expected [d:1234.000000] but found [d:1234,000000]
  • a4d4973: 8254318: Remove .hgtags
  • 8ad9018: 8285400: Add '@APinote' to the APIs defined in Java SE 8 MR 3
  • 3a5b2cd: 8201793: (ref) Reference object should not support cloning
  • 1b52b01: 8183107: PKCS11 regression regarding checkKeySize
  • e633df1: 8175797: (ref) Reference::enqueue method should clear the reference object before enqueuing
  • 5323ef6: 8254178: Remove .hgignore
  • 4cc462a: 8214427: probable bug in logic of ConcurrentHashMap.addCount()
  • ... and 33 more: https://git.openjdk.org/jdk8u-dev/compare/83e90957bef15267bed792ee5d8d65899a2487e8...master

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

As you do not have Committer status in this project an existing Committer must agree to sponsor your change. Possible candidates are the reviewers of this PR (@gnu-andrew, @phohensee) but any other Committer may sponsor as well.

➡️ To flag this PR as ready for integration with the above commit message, type /integrate in a new comment. (Afterwards, your sponsor types /sponsor in a new comment to perform the integration).

@openjdk openjdk bot added the ready Pull request is ready to be integrated label Aug 25, 2022
Copy link
Member

@phohensee phohensee left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lgtm.

@lusou-zhangquan
Copy link
Author

/integrate

@openjdk openjdk bot added the sponsor Pull request is ready to be sponsored label Aug 26, 2022
@openjdk
Copy link

openjdk bot commented Aug 26, 2022

@lusou-zhangquan
Your change (at version 0846705) is now ready to be sponsored by a Committer.

@phohensee
Copy link
Member

/sponsor

@openjdk
Copy link

openjdk bot commented Aug 26, 2022

Going to push as commit 2223058.
Since your change was applied there have been 43 commits pushed to the master branch:

  • d0ad242: 8285497: Add system property for Java SE specification maintenance version
  • e3251a2: 8232950: SUNPKCS11 Provider incorrectly check key length for PSS Signatures.
  • 41c7d2d: 8039955: [TESTBUG] jdk/lambda/LambdaTranslationTest1 - java.lang.AssertionError: expected [d:1234.000000] but found [d:1234,000000]
  • a4d4973: 8254318: Remove .hgtags
  • 8ad9018: 8285400: Add '@APinote' to the APIs defined in Java SE 8 MR 3
  • 3a5b2cd: 8201793: (ref) Reference object should not support cloning
  • 1b52b01: 8183107: PKCS11 regression regarding checkKeySize
  • e633df1: 8175797: (ref) Reference::enqueue method should clear the reference object before enqueuing
  • 5323ef6: 8254178: Remove .hgignore
  • 4cc462a: 8214427: probable bug in logic of ConcurrentHashMap.addCount()
  • ... and 33 more: https://git.openjdk.org/jdk8u-dev/compare/83e90957bef15267bed792ee5d8d65899a2487e8...master

Your commit was automatically rebased without conflicts.

@openjdk openjdk bot added the integrated Pull request has been integrated label Aug 26, 2022
@openjdk openjdk bot closed this Aug 26, 2022
@openjdk openjdk bot removed ready Pull request is ready to be integrated rfr Pull request is ready for review sponsor Pull request is ready to be sponsored labels Aug 26, 2022
@openjdk
Copy link

openjdk bot commented Aug 26, 2022

@phohensee @lusou-zhangquan Pushed as commit 2223058.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport integrated Pull request has been integrated
Development

Successfully merging this pull request may close these issues.

3 participants