8274563: jfr/event/oldobject/TestClassLoaderLeak.java fails when GC cycles are not happening

[caojoshua]

Not a clean backport. This change does not need to remove this line because it does not exist:

* @requires vm.gc != "Serial"

passing tests on my local machine. I've seen reports that max heap size needs to be decreased further for more consistent tests on other machines, so we should also backport https://bugs.openjdk.org/browse/JDK-8293828 after this.

---

Progress

• Change must be properly reviewed (1 review required, with at least 1 Reviewer)
• Change must not contain extraneous whitespace
• Commit message must refer to an issue

Issue

• JDK-8274563: jfr/event/oldobject/TestClassLoaderLeak.java fails when GC cycles are not happening

Reviewers

• Paul Hohensee (@phohensee - Reviewer)

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk8u-dev pull/120/head:pull/120
$ git checkout pull/120

Update a local copy of the PR:
$ git checkout pull/120
$ git pull https://git.openjdk.org/jdk8u-dev pull/120/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 120

View PR using the GUI difftool:
$ git pr show -t 120

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk8u-dev/pull/120.diff

[bridgekeeper]

👋 Welcome back caojoshua! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

[openjdk]

This backport pull request has now been updated with issue from the original commit.

[mlbridge]

Webrevs

• 00: Full (a1772e20)

[phohensee]

Lgtm.

[phohensee]

JBS issue tagged.

[openjdk]

@caojoshua This change now passes all automated pre-integration checks.

After integration, the commit message for the final commit will be:

8274563: jfr/event/oldobject/TestClassLoaderLeak.java fails when GC cycles are not happening

Reviewed-by: phh

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 3 new commits pushed to the master branch:

• 859c057: 8148005: One byte may be corrupted by get_datetime_string()
• a93344b: 8294863: Enable partial tier1 testing in GHA for JDK8
• d285382: 8293461: Add a test for JDK-8290832

Please see this link for an up-to-date comparison between the source branch of this pull request and the master branch.
As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

As you do not have Committer status in this project an existing Committer must agree to sponsor your change. Possible candidates are the reviewers of this PR (@phohensee) but any other Committer may sponsor as well.

➡️ To flag this PR as ready for integration with the above commit message, type /integrate in a new comment. (Afterwards, your sponsor types /sponsor in a new comment to perform the integration).

[caojoshua]

/integrate

[openjdk]

@caojoshua
Your change (at version a1772e2) is now ready to be sponsored by a Committer.

[phohensee]

/sponsor

[openjdk]

Going to push as commit 4a25b00.
Since your change was applied there have been 3 commits pushed to the master branch:

• 859c057: 8148005: One byte may be corrupted by get_datetime_string()
• a93344b: 8294863: Enable partial tier1 testing in GHA for JDK8
• d285382: 8293461: Add a test for JDK-8290832

Your commit was automatically rebased without conflicts.

[openjdk]

@phohensee @caojoshua Pushed as commit 4a25b00.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.