Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

8293828: JFR: jfr/event/oldobject/TestClassLoaderLeak.java still fails when GC cycles are not happening #122

Closed
wants to merge 2 commits into from

Conversation

Rudometov
Copy link
Member

@Rudometov Rudometov commented Sep 21, 2022

Backport for JDK-8293828


Progress

  • Change must be properly reviewed (1 review required, with at least 1 Reviewer)
  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue

Issue

  • JDK-8293828: JFR: jfr/event/oldobject/TestClassLoaderLeak.java still fails when GC cycles are not happening

Reviewers

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk8u-dev pull/122/head:pull/122
$ git checkout pull/122

Update a local copy of the PR:
$ git checkout pull/122
$ git pull https://git.openjdk.org/jdk8u-dev pull/122/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 122

View PR using the GUI difftool:
$ git pr show -t 122

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk8u-dev/pull/122.diff

@bridgekeeper
Copy link

bridgekeeper bot commented Sep 21, 2022

👋 Welcome back vrudomet! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk openjdk bot changed the title Backport 5002eaa5cc7301b91a45f8c0f65b5943fea225d8 8293828: JFR: jfr/event/oldobject/TestClassLoaderLeak.java still fails when GC cycles are not happening Sep 21, 2022
@openjdk
Copy link

openjdk bot commented Sep 21, 2022

This backport pull request has now been updated with issue from the original commit.

@openjdk openjdk bot added backport rfr Pull request is ready for review labels Sep 21, 2022
@mlbridge
Copy link

mlbridge bot commented Sep 21, 2022

Webrevs

Copy link
Member

@phohensee phohensee left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lgtm.

@openjdk
Copy link

openjdk bot commented Sep 21, 2022

@Rudometov This change now passes all automated pre-integration checks.

After integration, the commit message for the final commit will be:

8293828: JFR: jfr/event/oldobject/TestClassLoaderLeak.java still fails when GC cycles are not happening

Reviewed-by: phh

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been no new commits pushed to the master branch. If another commit should be pushed before you perform the /integrate command, your PR will be automatically rebased. If you prefer to avoid any potential automatic rebasing, please check the documentation for the /integrate command for further details.

As you do not have Committer status in this project an existing Committer must agree to sponsor your change. Possible candidates are the reviewers of this PR (@phohensee) but any other Committer may sponsor as well.

➡️ To flag this PR as ready for integration with the above commit message, type /integrate in a new comment. (Afterwards, your sponsor types /sponsor in a new comment to perform the integration).

@openjdk openjdk bot added the ready Pull request is ready to be integrated label Sep 21, 2022
@caojoshua
Copy link
Contributor

Can this change be rebased on top of https://github.com/openjdk/jdk8u-dev/pull/120/files?

@Rudometov
Copy link
Member Author

Can this change be rebased on top of https://github.com/openjdk/jdk8u-dev/pull/120/files?

@caojoshua, sure, I'll wait for 120 to go first.

@Rudometov
Copy link
Member Author

/integrate

@openjdk openjdk bot added the sponsor Pull request is ready to be sponsored label Oct 11, 2022
@openjdk
Copy link

openjdk bot commented Oct 11, 2022

@Rudometov
Your change (at version a5f0eb8) is now ready to be sponsored by a Committer.

@phohensee
Copy link
Member

/sponsor

@openjdk
Copy link

openjdk bot commented Oct 11, 2022

Going to push as commit 861ac32.

@openjdk openjdk bot added the integrated Pull request has been integrated label Oct 11, 2022
@openjdk openjdk bot closed this Oct 11, 2022
@openjdk openjdk bot removed ready Pull request is ready to be integrated rfr Pull request is ready for review sponsor Pull request is ready to be sponsored labels Oct 11, 2022
@openjdk
Copy link

openjdk bot commented Oct 11, 2022

@phohensee @Rudometov Pushed as commit 861ac32.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

@Rudometov Rudometov deleted the Backport-JDK-8293828 branch April 13, 2023 22:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport integrated Pull request has been integrated
3 participants