Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

8159599: [TEST_BUG] java/awt/Modal/ModalInternalFrameTest/ModalInternalFrameTest.java #134

Closed
wants to merge 1 commit into from

Conversation

caojoshua
Copy link
Contributor

@caojoshua caojoshua commented Oct 11, 2022

Backport for parity with Oracle.

Backport does not apply to ProblemList.txt because the affected test is not there in JDK8. Cleanly applies to SimpleWindowActivationTest.java after fixing paths.


Progress

  • Change must be properly reviewed (1 review required, with at least 1 Reviewer)
  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue

Issue

  • JDK-8159599: [TEST_BUG] java/awt/Modal/ModalInternalFrameTest/ModalInternalFrameTest.java

Reviewers

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk8u-dev pull/134/head:pull/134
$ git checkout pull/134

Update a local copy of the PR:
$ git checkout pull/134
$ git pull https://git.openjdk.org/jdk8u-dev pull/134/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 134

View PR using the GUI difftool:
$ git pr show -t 134

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk8u-dev/pull/134.diff

@bridgekeeper
Copy link

bridgekeeper bot commented Oct 11, 2022

👋 Welcome back caojoshua! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk openjdk bot changed the title Backport f5beafa53f93a6ec03278dfd7063d7b3b0b9d241 8159599: [TEST_BUG] java/awt/Modal/ModalInternalFrameTest/ModalInternalFrameTest.java Oct 11, 2022
@openjdk
Copy link

openjdk bot commented Oct 11, 2022

This backport pull request has now been updated with issue from the original commit.

@openjdk openjdk bot added backport rfr Pull request is ready for review labels Oct 11, 2022
@mlbridge
Copy link

mlbridge bot commented Oct 11, 2022

Webrevs

Copy link
Member

@phohensee phohensee left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lgtm.

@phohensee
Copy link
Member

JBS issue tagged.

@openjdk
Copy link

openjdk bot commented Oct 11, 2022

@caojoshua This change now passes all automated pre-integration checks.

After integration, the commit message for the final commit will be:

8159599: [TEST_BUG] java/awt/Modal/ModalInternalFrameTest/ModalInternalFrameTest.java

Reviewed-by: phh

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 35 new commits pushed to the master branch:

  • f6d869f: 8221529: [TESTBUG] Docker tests use old/deprecated image on AArch64
  • 3bfde7d: 8284622: Update versions of some Github Actions used in JDK workflow
  • 3a1a2e0: 8233551: [TESTBUG] SelectEditTableCell.java fails on MacOS
  • 736c1fb: 8295288: Some vm_flags tests associate with a wrong BugID
  • 0f9095f: 7124218: [TEST_BUG] [macosx] Space should select cell in the JTable
  • 6e563e5: 8159720: Failure of C2 compilation with tiered prevents some C1 compilations
  • 01f7d1e: 8224506: [TESTBUG] TestDockerMemoryMetrics.java fails with exitValue = 137
  • c605aa3: 8296555: Enable hotspot/tier1 for 64-bit builds in GHA for 8u
  • fb98418: 8295915: Problemlist compiler/rtm failures specific to 8u
  • 2cd66fb: 8270344: Session resumption errors
  • ... and 25 more: https://git.openjdk.org/jdk8u-dev/compare/4a25b00aba29dd45529be805c4ec135f20228d80...master

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

As you do not have Committer status in this project an existing Committer must agree to sponsor your change. Possible candidates are the reviewers of this PR (@phohensee) but any other Committer may sponsor as well.

➡️ To flag this PR as ready for integration with the above commit message, type /integrate in a new comment. (Afterwards, your sponsor types /sponsor in a new comment to perform the integration).

@openjdk openjdk bot added the ready Pull request is ready to be integrated label Oct 11, 2022
@bridgekeeper
Copy link

bridgekeeper bot commented Nov 10, 2022

@caojoshua This pull request has been inactive for more than 4 weeks and will be automatically closed if another 4 weeks passes without any activity. To avoid this, simply add a new comment to the pull request. Feel free to ask for assistance if you need help with progressing this pull request towards integration!

@caojoshua
Copy link
Contributor Author

no jdk-8u-fix-request-yes yet. leaving this open.

@caojoshua
Copy link
Contributor Author

/integrate

@openjdk openjdk bot added the sponsor Pull request is ready to be sponsored label Nov 11, 2022
@openjdk
Copy link

openjdk bot commented Nov 11, 2022

@caojoshua
Your change (at version 5db11fe) is now ready to be sponsored by a Committer.

@phohensee
Copy link
Member

/sponsor

@openjdk
Copy link

openjdk bot commented Nov 11, 2022

Going to push as commit 2f509c7.
Since your change was applied there have been 35 commits pushed to the master branch:

  • f6d869f: 8221529: [TESTBUG] Docker tests use old/deprecated image on AArch64
  • 3bfde7d: 8284622: Update versions of some Github Actions used in JDK workflow
  • 3a1a2e0: 8233551: [TESTBUG] SelectEditTableCell.java fails on MacOS
  • 736c1fb: 8295288: Some vm_flags tests associate with a wrong BugID
  • 0f9095f: 7124218: [TEST_BUG] [macosx] Space should select cell in the JTable
  • 6e563e5: 8159720: Failure of C2 compilation with tiered prevents some C1 compilations
  • 01f7d1e: 8224506: [TESTBUG] TestDockerMemoryMetrics.java fails with exitValue = 137
  • c605aa3: 8296555: Enable hotspot/tier1 for 64-bit builds in GHA for 8u
  • fb98418: 8295915: Problemlist compiler/rtm failures specific to 8u
  • 2cd66fb: 8270344: Session resumption errors
  • ... and 25 more: https://git.openjdk.org/jdk8u-dev/compare/4a25b00aba29dd45529be805c4ec135f20228d80...master

Your commit was automatically rebased without conflicts.

@openjdk openjdk bot added the integrated Pull request has been integrated label Nov 11, 2022
@openjdk openjdk bot closed this Nov 11, 2022
@openjdk openjdk bot removed ready Pull request is ready to be integrated rfr Pull request is ready for review sponsor Pull request is ready to be sponsored labels Nov 11, 2022
@openjdk
Copy link

openjdk bot commented Nov 11, 2022

@phohensee @caojoshua Pushed as commit 2f509c7.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport integrated Pull request has been integrated
2 participants