Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

8294357: (tz) Update Timezone Data to 2022d #138

Closed
wants to merge 1 commit into from

Conversation

gnu-andrew
Copy link
Member

@gnu-andrew gnu-andrew commented Oct 16, 2022

Mostly clean backport of tzdata2022d update from 11u, with paths adjusted and files duplicated for jdk/test. There are no tzdata differences between the vanguard and rearguard update.

In updating TestZoneInfo310.java, I also brought in the restructuring of the check & comments from JDK-8212970

Tests in java/util/TimeZone and sun/util/calendar all pass.


Progress

  • Change must be properly reviewed (1 review required, with at least 1 Reviewer)
  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue

Issue

Reviewers

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk8u-dev pull/138/head:pull/138
$ git checkout pull/138

Update a local copy of the PR:
$ git checkout pull/138
$ git pull https://git.openjdk.org/jdk8u-dev pull/138/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 138

View PR using the GUI difftool:
$ git pr show -t 138

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk8u-dev/pull/138.diff

@bridgekeeper
Copy link

bridgekeeper bot commented Oct 16, 2022

👋 Welcome back andrew! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk openjdk bot changed the title Backport f67b4de8a07b8158be1dfb5b09cdb4cc5b7ac93b 8294357: (tz) Update Timezone Data to 2022d Oct 16, 2022
@openjdk
Copy link

openjdk bot commented Oct 16, 2022

This backport pull request has now been updated with issue from the original commit.

@openjdk openjdk bot added backport rfr Pull request is ready for review labels Oct 16, 2022
@mlbridge
Copy link

mlbridge bot commented Oct 16, 2022

Webrevs

Copy link
Contributor

@jerboaa jerboaa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks OK to me.

@openjdk
Copy link

openjdk bot commented Oct 21, 2022

@gnu-andrew This change now passes all automated pre-integration checks.

After integration, the commit message for the final commit will be:

8294357: (tz) Update Timezone Data to 2022d

Reviewed-by: sgehwolf

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 12 new commits pushed to the master branch:

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

@openjdk openjdk bot added the ready Pull request is ready to be integrated label Oct 21, 2022
@gnu-andrew
Copy link
Member Author

Thanks @jerboaa . Bug flagged with jdk8u-fix-request.

@gnu-andrew
Copy link
Member Author

I see jdk8u-fix-yes now.

@gnu-andrew
Copy link
Member Author

/integrate

@openjdk
Copy link

openjdk bot commented Nov 2, 2022

Going to push as commit 28cc835.
Since your change was applied there have been 14 commits pushed to the master branch:

Your commit was automatically rebased without conflicts.

@openjdk openjdk bot added the integrated Pull request has been integrated label Nov 2, 2022
@openjdk openjdk bot closed this Nov 2, 2022
@openjdk openjdk bot removed ready Pull request is ready to be integrated rfr Pull request is ready for review labels Nov 2, 2022
@openjdk
Copy link

openjdk bot commented Nov 2, 2022

@gnu-andrew Pushed as commit 28cc835.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport integrated Pull request has been integrated
2 participants