Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

8223396: [TESTBUG] several jfr tests do not clean up files created in /tmp #14

Closed
wants to merge 1 commit into from

Conversation

dongbohe
Copy link
Member

@dongbohe dongbohe commented Mar 18, 2022

Hi,

This is a clean backport of JDK-8223396. I'm backporting this as a predecessor of PR #10.

Test:

  • jdk_jfr
    EvilInstrument.java test fails. Followup JDK-8230865 backport to fix it.

Progress

  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue

Issue

  • JDK-8223396: [TESTBUG] several jfr tests do not clean up files created in /tmp

Reviewers

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.java.net/jdk8u-dev pull/14/head:pull/14
$ git checkout pull/14

Update a local copy of the PR:
$ git checkout pull/14
$ git pull https://git.openjdk.java.net/jdk8u-dev pull/14/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 14

View PR using the GUI difftool:
$ git pr show -t 14

Using diff file

Download this PR as a diff file:
https://git.openjdk.java.net/jdk8u-dev/pull/14.diff

@bridgekeeper
Copy link

bridgekeeper bot commented Mar 18, 2022

👋 Welcome back dongbohe! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk openjdk bot changed the title Backport 7d3aebccc0b90aa2ca2f656c683fa5931fd0ed3a 8223396: [TESTBUG] several jfr tests do not clean up files created in /tmp Mar 18, 2022
@openjdk
Copy link

openjdk bot commented Mar 18, 2022

This backport pull request has now been updated with issue and summary from the original commit.

@openjdk openjdk bot added backport rfr Pull request is ready for review labels Mar 18, 2022
@mlbridge
Copy link

mlbridge bot commented Mar 18, 2022

Webrevs

@jerboaa
Copy link
Contributor

jerboaa commented Mar 18, 2022

Clean backport other than path reshuffling.

@jerboaa
Copy link
Contributor

jerboaa commented Mar 18, 2022

/clean

@openjdk openjdk bot added the clean label Mar 18, 2022
@openjdk
Copy link

openjdk bot commented Mar 18, 2022

@jerboaa This backport pull request is now marked as clean

@openjdk
Copy link

openjdk bot commented Mar 18, 2022

@dongbohe This change now passes all automated pre-integration checks.

After integration, the commit message for the final commit will be:

8223396: [TESTBUG] several jfr tests do not clean up files created in /tmp

Using test utils to create temp files and directories

Reviewed-by: andrew

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 1 new commit pushed to the master branch:

  • 5fcfb7a: 8194154: System property user.dir should not be changed

Please see this link for an up-to-date comparison between the source branch of this pull request and the master branch.
As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

As you do not have Committer status in this project an existing Committer must agree to sponsor your change. Possible candidates are the reviewers of this PR (@gnu-andrew) but any other Committer may sponsor as well.

➡️ To flag this PR as ready for integration with the above commit message, type /integrate in a new comment. (Afterwards, your sponsor types /sponsor in a new comment to perform the integration).

@openjdk openjdk bot added the ready Pull request is ready to be integrated label Mar 18, 2022
@dongbohe
Copy link
Member Author

dongbohe commented Mar 21, 2022

Tagged the JBS issue with jdk8u-fix-request.

Copy link
Member

@gnu-andrew gnu-andrew left a comment

Note that the shuffle for test/lib/jdk/test/lib/Utils.java should really have been jdk/test/lib/testlibrary/jdk/testlibrary/Utils.java. This is not a problem with this backport, but with the lack of correct path shuffling applied by the original JFR backport. We should migrate to the newer file generally to avoid duplication.

I've approved this bug.

@dongbohe
Copy link
Member Author

dongbohe commented Mar 22, 2022

Thank you for your review, andrew.

@dongbohe
Copy link
Member Author

dongbohe commented Mar 22, 2022

/integrate

@openjdk openjdk bot added the sponsor Pull request is ready to be sponsored label Mar 22, 2022
@openjdk
Copy link

openjdk bot commented Mar 22, 2022

@dongbohe
Your change (at version 9f05d9b) is now ready to be sponsored by a Committer.

@dongbohe
Copy link
Member Author

dongbohe commented Mar 22, 2022

Got the push approval

@RealFYang
Copy link
Member

RealFYang commented Mar 22, 2022

/sponsor

@openjdk
Copy link

openjdk bot commented Mar 22, 2022

Going to push as commit 25693fa.
Since your change was applied there has been 1 commit pushed to the master branch:

  • 5fcfb7a: 8194154: System property user.dir should not be changed

Your commit was automatically rebased without conflicts.

@openjdk openjdk bot added the integrated Pull request has been integrated label Mar 22, 2022
@openjdk openjdk bot closed this Mar 22, 2022
@openjdk openjdk bot removed ready Pull request is ready to be integrated rfr Pull request is ready for review sponsor Pull request is ready to be sponsored labels Mar 22, 2022
@openjdk
Copy link

openjdk bot commented Mar 22, 2022

@RealFYang @dongbohe Pushed as commit 25693fa.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport clean integrated Pull request has been integrated
4 participants