Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

8295915: Problemlist compiler/rtm failures specific to 8u #148

Closed
wants to merge 1 commit into from

Conversation

zzambers
Copy link
Contributor

@zzambers zzambers commented Oct 25, 2022

I would like to problemlist few more compiler/rtm tests on jdk8u. Tests are failing on machines used by Github actions. Failures are specific to jdk8 ( For more details see my comments in JDK-8183263 [1] ).
List of tests follows:

compiler/rtm/locking/TestRTMTotalCountIncrRate.java
compiler/rtm/locking/TestUseRTMAfterLockInflation.java
compiler/rtm/locking/TestUseRTMForInflatedLocks.java
compiler/rtm/locking/TestUseRTMForStackLocks.java
compiler/rtm/method_options/TestUseRTMLockElidingOption.java

These tests are part of hotspot_tier1 and are currently the only failures for 64-bit builds. (There are some additional (unrelated) issues on 32-bit builds.) This blocks enabling of hotspot_tier1 in Github Actions.

Tested in GHA with hotspot_tier1 testing enabled (64-bit builds), no failures [2].

[1] https://bugs.openjdk.org/browse/JDK-8183263
[2] https://github.com/zzambers/jdk8u-dev/commits/problemlist-rtm-8u-test


Progress

  • Change must be properly reviewed (1 review required, with at least 1 Reviewer)
  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue

Issue

  • JDK-8295915: Problemlist compiler/rtm failures specific to 8u

Reviewers

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk8u-dev pull/148/head:pull/148
$ git checkout pull/148

Update a local copy of the PR:
$ git checkout pull/148
$ git pull https://git.openjdk.org/jdk8u-dev pull/148/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 148

View PR using the GUI difftool:
$ git pr show -t 148

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk8u-dev/pull/148.diff

@bridgekeeper
Copy link

bridgekeeper bot commented Oct 25, 2022

👋 Welcome back zzambers! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk openjdk bot added the rfr Pull request is ready for review label Oct 25, 2022
@mlbridge
Copy link

mlbridge bot commented Oct 25, 2022

Webrevs

Copy link
Member

@phohensee phohensee left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lgtm.

@openjdk
Copy link

openjdk bot commented Oct 31, 2022

@zzambers This change now passes all automated pre-integration checks.

After integration, the commit message for the final commit will be:

8295915: Problemlist compiler/rtm failures specific to 8u

Reviewed-by: phh, sgehwolf

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 5 new commits pushed to the master branch:

  • 2cd66fb: 8270344: Session resumption errors
  • ae6d30d: 8295950: Enable langtools/tier1 in GHA for 8u
  • 64faf40: 8295173: (tz) Update Timezone Data to 2022e
  • 28cc835: 8294357: (tz) Update Timezone Data to 2022d
  • f04ad96: 8265527: tools/javac/diags/CheckExamples.java fails after JDK-8078024 8u backport

Please see this link for an up-to-date comparison between the source branch of this pull request and the master branch.
As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

As you do not have Committer status in this project an existing Committer must agree to sponsor your change. Possible candidates are the reviewers of this PR (@phohensee, @jerboaa) but any other Committer may sponsor as well.

➡️ To flag this PR as ready for integration with the above commit message, type /integrate in a new comment. (Afterwards, your sponsor types /sponsor in a new comment to perform the integration).

@openjdk openjdk bot added the ready Pull request is ready to be integrated label Oct 31, 2022
@zzambers
Copy link
Contributor Author

zzambers commented Nov 7, 2022

@phohensee thank you for the review

Copy link
Contributor

@jerboaa jerboaa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

OK.

@zzambers
Copy link
Contributor Author

zzambers commented Nov 8, 2022

@jerboaa thank you for the review
/integrate

@openjdk openjdk bot added the sponsor Pull request is ready to be sponsored label Nov 8, 2022
@openjdk
Copy link

openjdk bot commented Nov 8, 2022

@zzambers
Your change (at version f893aeb) is now ready to be sponsored by a Committer.

@jerboaa
Copy link
Contributor

jerboaa commented Nov 8, 2022

/sponsor

@openjdk
Copy link

openjdk bot commented Nov 8, 2022

Going to push as commit fb98418.
Since your change was applied there have been 5 commits pushed to the master branch:

  • 2cd66fb: 8270344: Session resumption errors
  • ae6d30d: 8295950: Enable langtools/tier1 in GHA for 8u
  • 64faf40: 8295173: (tz) Update Timezone Data to 2022e
  • 28cc835: 8294357: (tz) Update Timezone Data to 2022d
  • f04ad96: 8265527: tools/javac/diags/CheckExamples.java fails after JDK-8078024 8u backport

Your commit was automatically rebased without conflicts.

@openjdk openjdk bot added the integrated Pull request has been integrated label Nov 8, 2022
@openjdk openjdk bot closed this Nov 8, 2022
@openjdk openjdk bot removed ready Pull request is ready to be integrated rfr Pull request is ready for review sponsor Pull request is ready to be sponsored labels Nov 8, 2022
@openjdk
Copy link

openjdk bot commented Nov 8, 2022

@jerboaa @zzambers Pushed as commit fb98418.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
integrated Pull request has been integrated
3 participants