Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

8270344: Session resumption errors #151

Closed
wants to merge 1 commit into from

Conversation

alexeybakhtin
Copy link
Contributor

@alexeybakhtin alexeybakhtin commented Oct 31, 2022

It is an almost clean backport.
TransportContext.java is not updated, because of extra newline already removed as part of JDK-8245468
Fixed library path for the InvalidateSession test

sun/security/ssl and javax/net/ssl regression tests are passed


Progress

  • Change must be properly reviewed (1 review required, with at least 1 Reviewer)
  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue

Issue

Reviewers

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk8u-dev pull/151/head:pull/151
$ git checkout pull/151

Update a local copy of the PR:
$ git checkout pull/151
$ git pull https://git.openjdk.org/jdk8u-dev pull/151/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 151

View PR using the GUI difftool:
$ git pr show -t 151

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk8u-dev/pull/151.diff

@bridgekeeper
Copy link

bridgekeeper bot commented Oct 31, 2022

👋 Welcome back abakhtin! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk openjdk bot changed the title Backport 04a806ec86a388b8de31d42f904c4321beb69e14 8270344: Session resumption errors Oct 31, 2022
@openjdk
Copy link

openjdk bot commented Oct 31, 2022

This backport pull request has now been updated with issue from the original commit.

@openjdk openjdk bot added backport rfr Pull request is ready for review labels Oct 31, 2022
@mlbridge
Copy link

mlbridge bot commented Oct 31, 2022

Webrevs

@jerboaa
Copy link
Contributor

jerboaa commented Nov 3, 2022

@martinuy Could you please review this? Thanks!

Copy link
Contributor

@martinuy martinuy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for proposing this backport. Looks good to me. The changed lib paths in sun/security/ssl/SSLSessionImpl/InvalidateSession.java are correct and the test passes.

@openjdk
Copy link

openjdk bot commented Nov 5, 2022

@alexeybakhtin This change now passes all automated pre-integration checks.

After integration, the commit message for the final commit will be:

8270344: Session resumption errors

Reviewed-by: mbalao

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 3 new commits pushed to the master branch:

  • ae6d30d: 8295950: Enable langtools/tier1 in GHA for 8u
  • 64faf40: 8295173: (tz) Update Timezone Data to 2022e
  • 28cc835: 8294357: (tz) Update Timezone Data to 2022d

Please see this link for an up-to-date comparison between the source branch of this pull request and the master branch.
As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

@openjdk openjdk bot added the ready Pull request is ready to be integrated label Nov 5, 2022
@alexeybakhtin
Copy link
Contributor Author

@martinuy Thank you a lot for the review!

@alexeybakhtin
Copy link
Contributor Author

/integrate

@openjdk
Copy link

openjdk bot commented Nov 7, 2022

Going to push as commit 2cd66fb.
Since your change was applied there have been 3 commits pushed to the master branch:

  • ae6d30d: 8295950: Enable langtools/tier1 in GHA for 8u
  • 64faf40: 8295173: (tz) Update Timezone Data to 2022e
  • 28cc835: 8294357: (tz) Update Timezone Data to 2022d

Your commit was automatically rebased without conflicts.

@openjdk openjdk bot added the integrated Pull request has been integrated label Nov 7, 2022
@openjdk openjdk bot closed this Nov 7, 2022
@openjdk openjdk bot removed ready Pull request is ready to be integrated rfr Pull request is ready for review labels Nov 7, 2022
@openjdk
Copy link

openjdk bot commented Nov 7, 2022

@alexeybakhtin Pushed as commit 2cd66fb.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport integrated Pull request has been integrated
3 participants