Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

8295322: Tests for JDK-8271459 were not backported to 11u #152

Closed
wants to merge 2 commits into from
Closed

8295322: Tests for JDK-8271459 were not backported to 11u #152

wants to merge 2 commits into from

Conversation

apavlyutkin
Copy link
Contributor

@apavlyutkin apavlyutkin commented Nov 1, 2022

Hi!

Here is the backport of JDK-8295322 that adds missed tests for JDK-8271459. Except the path shuffling the following changes were done to the original openjdk/jdk11u-dev@70ddb1b

  • visibility of test class and methods was changed to public to support older JTReg
  • requires annotation was removed to support older JTReg

Verification (amd64/20.04 LTS): running new hotspot/test/compiler/c2/TestNegativeStringBuilderCapacity.java

7 of 7 PASS on dfeeceb (integration of JDK-8271459)
4 of 7 FAIL on the previous 43cfe27


Progress

  • Change must be properly reviewed (1 review required, with at least 1 Reviewer)
  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue

Issue

  • JDK-8295322: Tests for JDK-8271459 were not backported to 11u

Reviewers

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk8u-dev pull/152/head:pull/152
$ git checkout pull/152

Update a local copy of the PR:
$ git checkout pull/152
$ git pull https://git.openjdk.org/jdk8u-dev pull/152/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 152

View PR using the GUI difftool:
$ git pr show -t 152

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk8u-dev/pull/152.diff

@bridgekeeper
Copy link

bridgekeeper bot commented Nov 1, 2022

👋 Welcome back apavlyutkin! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk openjdk bot changed the title Backport 70ddb1b025ce3b8eed4d8ad5af1b1fa4d0e0b015 8295322: Tests for JDK-8271459 were not backported to 11u Nov 1, 2022
@openjdk
Copy link

openjdk bot commented Nov 1, 2022

This backport pull request has now been updated with issue from the original commit.

@openjdk openjdk bot added backport rfr Pull request is ready for review labels Nov 1, 2022
@mlbridge
Copy link

mlbridge bot commented Nov 1, 2022

Webrevs

Copy link
Member

@phohensee phohensee left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lgtm.

@openjdk
Copy link

openjdk bot commented Nov 1, 2022

@apavlyutkin This change now passes all automated pre-integration checks.

After integration, the commit message for the final commit will be:

8295322: Tests for JDK-8271459 were not backported to 11u

Reviewed-by: phh

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 30 new commits pushed to the master branch:

  • 7eb2803: 8230305: Cgroups v2: Container awareness
  • 3b1bbef: 8297739: Bump update version of OpenJDK: 8u372
  • 41159a5: 8255559: Leak File Descriptors Because of ResolverLocalFilesystem#engineResolveURI()
  • df44cbf: 8073464: GC workers do not have thread names
  • 9f2f0c2: 6885993: Named Thread: introduce print() and print_on(outputStream* st) methods
  • c501bfa: 8269039: Disable SHA-1 Signed JARs
  • 5a32484: 8297141: Fix hotspot/test/runtime/SharedArchiveFile/DefaultUseWithClient.java for 8u
  • da0c382: 8241086: Test runtime/NMT/HugeArenaTracking.java is failing on 32bit Windows
  • 91d8b89: 8129827: [TEST_BUG] Test java/awt/Robot/RobotWheelTest/RobotWheelTest.java fails
  • 9cb8752: 8079255: [TEST_BUG] [macosx] Test closed/java/awt/Robot/RobotWheelTest/RobotWheelTest fails for Mac only
  • ... and 20 more: https://git.openjdk.org/jdk8u-dev/compare/1f8eafd8a05ce979eefd9ed45f5e7c6fb5fc5f2d...master

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

As you do not have Committer status in this project an existing Committer must agree to sponsor your change. Possible candidates are the reviewers of this PR (@phohensee) but any other Committer may sponsor as well.

➡️ To flag this PR as ready for integration with the above commit message, type /integrate in a new comment. (Afterwards, your sponsor types /sponsor in a new comment to perform the integration).

@openjdk openjdk bot added the ready Pull request is ready to be integrated label Nov 1, 2022
@apavlyutkin
Copy link
Contributor Author

Thank you for the review

@bridgekeeper
Copy link

bridgekeeper bot commented Nov 29, 2022

@apavlyutkin This pull request has been inactive for more than 4 weeks and will be automatically closed if another 4 weeks passes without any activity. To avoid this, simply add a new comment to the pull request. Feel free to ask for assistance if you need help with progressing this pull request towards integration!

@phohensee
Copy link
Member

I'd ping a maintainer directly.

@apavlyutkin
Copy link
Contributor Author

/integrate

@openjdk openjdk bot added the sponsor Pull request is ready to be sponsored label Dec 1, 2022
@openjdk
Copy link

openjdk bot commented Dec 1, 2022

@apavlyutkin
Your change (at version a93c000) is now ready to be sponsored by a Committer.

@yan-too
Copy link
Contributor

yan-too commented Dec 1, 2022

/sponsor

@openjdk
Copy link

openjdk bot commented Dec 1, 2022

Going to push as commit e9acfce.
Since your change was applied there have been 30 commits pushed to the master branch:

  • 7eb2803: 8230305: Cgroups v2: Container awareness
  • 3b1bbef: 8297739: Bump update version of OpenJDK: 8u372
  • 41159a5: 8255559: Leak File Descriptors Because of ResolverLocalFilesystem#engineResolveURI()
  • df44cbf: 8073464: GC workers do not have thread names
  • 9f2f0c2: 6885993: Named Thread: introduce print() and print_on(outputStream* st) methods
  • c501bfa: 8269039: Disable SHA-1 Signed JARs
  • 5a32484: 8297141: Fix hotspot/test/runtime/SharedArchiveFile/DefaultUseWithClient.java for 8u
  • da0c382: 8241086: Test runtime/NMT/HugeArenaTracking.java is failing on 32bit Windows
  • 91d8b89: 8129827: [TEST_BUG] Test java/awt/Robot/RobotWheelTest/RobotWheelTest.java fails
  • 9cb8752: 8079255: [TEST_BUG] [macosx] Test closed/java/awt/Robot/RobotWheelTest/RobotWheelTest fails for Mac only
  • ... and 20 more: https://git.openjdk.org/jdk8u-dev/compare/1f8eafd8a05ce979eefd9ed45f5e7c6fb5fc5f2d...master

Your commit was automatically rebased without conflicts.

@openjdk openjdk bot added the integrated Pull request has been integrated label Dec 1, 2022
@openjdk openjdk bot closed this Dec 1, 2022
@openjdk openjdk bot removed ready Pull request is ready to be integrated rfr Pull request is ready for review sponsor Pull request is ready to be sponsored labels Dec 1, 2022
@openjdk
Copy link

openjdk bot commented Dec 1, 2022

@yan-too @apavlyutkin Pushed as commit e9acfce.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport integrated Pull request has been integrated
3 participants