New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
8295322: Tests for JDK-8271459 were not backported to 11u #152
Conversation
|
This backport pull request has now been updated with issue from the original commit. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Lgtm.
@apavlyutkin This change now passes all automated pre-integration checks. After integration, the commit message for the final commit will be:
You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed. At the time when this comment was updated there had been 30 new commits pushed to the
As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details. As you do not have Committer status in this project an existing Committer must agree to sponsor your change. Possible candidates are the reviewers of this PR (@phohensee) but any other Committer may sponsor as well.
|
Thank you for the review |
@apavlyutkin This pull request has been inactive for more than 4 weeks and will be automatically closed if another 4 weeks passes without any activity. To avoid this, simply add a new comment to the pull request. Feel free to ask for assistance if you need help with progressing this pull request towards integration! |
I'd ping a maintainer directly. |
/integrate |
@apavlyutkin |
/sponsor |
Going to push as commit e9acfce.
Your commit was automatically rebased without conflicts. |
@yan-too @apavlyutkin Pushed as commit e9acfce. |
Hi!
Here is the backport of JDK-8295322 that adds missed tests for JDK-8271459. Except the path shuffling the following changes were done to the original openjdk/jdk11u-dev@70ddb1b
public
to support older JTRegrequires
annotation was removed to support older JTRegVerification (amd64/20.04 LTS): running new
hotspot/test/compiler/c2/TestNegativeStringBuilderCapacity.java
7 of 7 PASS on dfeeceb (integration of JDK-8271459)
4 of 7 FAIL on the previous 43cfe27
Progress
Issue
Reviewers
Reviewing
Using
git
Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk8u-dev pull/152/head:pull/152
$ git checkout pull/152
Update a local copy of the PR:
$ git checkout pull/152
$ git pull https://git.openjdk.org/jdk8u-dev pull/152/head
Using Skara CLI tools
Checkout this PR locally:
$ git pr checkout 152
View PR using the GUI difftool:
$ git pr show -t 152
Using diff file
Download this PR as a diff file:
https://git.openjdk.org/jdk8u-dev/pull/152.diff