Skip to content

8233551: [TESTBUG] SelectEditTableCell.java fails on MacOS#162

Closed
Rudometov wants to merge 3 commits intoopenjdk:masterfrom
Rudometov:8233551
Closed

8233551: [TESTBUG] SelectEditTableCell.java fails on MacOS#162
Rudometov wants to merge 3 commits intoopenjdk:masterfrom
Rudometov:8233551

Conversation

@Rudometov
Copy link
Member

@Rudometov Rudometov commented Nov 8, 2022

Backport for JDK-8233551 [TESTBUG] SelectEditTableCell.java fails on MacOS (openjdk/jdk@9b3fb5d)

Backport for test fix from JDK-7124218.
No risk, only a test change.
Clean backport except for ProblemList.
Test passes during manual run.

This PR depends on #160


Progress

  • Change must be properly reviewed (1 review required, with at least 1 Reviewer)
  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue

Issue

  • JDK-8233551: [TESTBUG] SelectEditTableCell.java fails on MacOS

Reviewers

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk8u-dev pull/162/head:pull/162
$ git checkout pull/162

Update a local copy of the PR:
$ git checkout pull/162
$ git pull https://git.openjdk.org/jdk8u-dev pull/162/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 162

View PR using the GUI difftool:
$ git pr show -t 162

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk8u-dev/pull/162.diff

Avik Niyogi and others added 2 commits November 4, 2022 16:39
Reviewed-by: rchamyal, alexsch
(cherry picked from commit 2e94af3f3d7010e89852721d1fda7a226e8ffb6c)
@bridgekeeper
Copy link

bridgekeeper bot commented Nov 8, 2022

👋 Welcome back vrudomet! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk openjdk bot changed the title Backport 9b3fb5d1d5a6a3f0fc699b10bdff6d43ae8d1898 8233551: [TESTBUG] SelectEditTableCell.java fails on MacOS Nov 8, 2022
@openjdk
Copy link

openjdk bot commented Nov 8, 2022

This backport pull request has now been updated with issue from the original commit.

@openjdk openjdk bot added backport Port of a pull request already in a different code base rfr Pull request is ready for review labels Nov 8, 2022
@mlbridge
Copy link

mlbridge bot commented Nov 8, 2022

Webrevs

Copy link
Member

@phohensee phohensee left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This PR contains the entirety of SelectEditTableCell.java. The latter was created by JDK-7124218 (which you're backporting first), so this PR should include only the edits.

@Rudometov Rudometov changed the base branch from master to pr/160 November 8, 2022 20:30
@Rudometov
Copy link
Member Author

Thank you. I've changed the base of this PR to pr160, so the only changes seen here are the actual pr162 changes.

Copy link
Member

@phohensee phohensee left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, Victor. Lgtm.

@Rudometov
Copy link
Member Author

/integrate

@openjdk
Copy link

openjdk bot commented Nov 9, 2022

@Rudometov This pull request has not yet been marked as ready for integration.

@openjdk-notifier openjdk-notifier bot changed the base branch from pr/160 to master November 9, 2022 17:51
@openjdk-notifier
Copy link

The parent pull request that this pull request depends on has now been integrated and the target branch of this pull request has been updated. This means that changes from the dependent pull request can start to show up as belonging to this pull request, which may be confusing for reviewers. To remedy this situation, simply merge the latest changes from the new target branch into this pull request by running commands similar to these in the local repository for your personal fork:

git checkout 8233551
git fetch https://git.openjdk.org/jdk8u-dev master
git merge FETCH_HEAD
# if there are conflicts, follow the instructions given by git merge
git commit -m "Merge master"
git push

@openjdk
Copy link

openjdk bot commented Nov 9, 2022

@Rudometov This change now passes all automated pre-integration checks.

After integration, the commit message for the final commit will be:

8233551: [TESTBUG] SelectEditTableCell.java fails on MacOS

Reviewed-by: phh

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been no new commits pushed to the master branch. If another commit should be pushed before you perform the /integrate command, your PR will be automatically rebased. If you prefer to avoid any potential automatic rebasing, please check the documentation for the /integrate command for further details.

As you do not have Committer status in this project an existing Committer must agree to sponsor your change. Possible candidates are the reviewers of this PR (@phohensee) but any other Committer may sponsor as well.

➡️ To flag this PR as ready for integration with the above commit message, type /integrate in a new comment. (Afterwards, your sponsor types /sponsor in a new comment to perform the integration).

@openjdk openjdk bot added the ready Pull request is ready to be integrated label Nov 9, 2022
@Rudometov
Copy link
Member Author

/integrate

@openjdk openjdk bot added the sponsor Pull request is ready to be sponsored label Nov 9, 2022
@openjdk
Copy link

openjdk bot commented Nov 9, 2022

@Rudometov
Your change (at version b4d24d3) is now ready to be sponsored by a Committer.

@phohensee
Copy link
Member

/sponsor

@openjdk
Copy link

openjdk bot commented Nov 9, 2022

Going to push as commit 3a1a2e0.
Since your change was applied there has been 1 commit pushed to the master branch:

  • 736c1fb: 8295288: Some vm_flags tests associate with a wrong BugID

Your commit was automatically rebased without conflicts.

@openjdk openjdk bot added the integrated Pull request has been integrated label Nov 9, 2022
@openjdk openjdk bot closed this Nov 9, 2022
@openjdk openjdk bot removed ready Pull request is ready to be integrated rfr Pull request is ready for review sponsor Pull request is ready to be sponsored labels Nov 9, 2022
@openjdk
Copy link

openjdk bot commented Nov 9, 2022

@phohensee @Rudometov Pushed as commit 3a1a2e0.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

@Rudometov Rudometov deleted the 8233551 branch April 13, 2023 22:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

backport Port of a pull request already in a different code base integrated Pull request has been integrated

Development

Successfully merging this pull request may close these issues.

2 participants

Comments