8233551: [TESTBUG] SelectEditTableCell.java fails on MacOS#162
8233551: [TESTBUG] SelectEditTableCell.java fails on MacOS#162Rudometov wants to merge 3 commits intoopenjdk:masterfrom
Conversation
Reviewed-by: rchamyal, alexsch (cherry picked from commit 2e94af3f3d7010e89852721d1fda7a226e8ffb6c)
|
👋 Welcome back vrudomet! A progress list of the required criteria for merging this PR into |
|
This backport pull request has now been updated with issue from the original commit. |
Webrevs
|
phohensee
left a comment
There was a problem hiding this comment.
This PR contains the entirety of SelectEditTableCell.java. The latter was created by JDK-7124218 (which you're backporting first), so this PR should include only the edits.
|
Thank you. I've changed the base of this PR to pr160, so the only changes seen here are the actual pr162 changes. |
|
/integrate |
|
@Rudometov This pull request has not yet been marked as ready for integration. |
|
The parent pull request that this pull request depends on has now been integrated and the target branch of this pull request has been updated. This means that changes from the dependent pull request can start to show up as belonging to this pull request, which may be confusing for reviewers. To remedy this situation, simply merge the latest changes from the new target branch into this pull request by running commands similar to these in the local repository for your personal fork: git checkout 8233551
git fetch https://git.openjdk.org/jdk8u-dev master
git merge FETCH_HEAD
# if there are conflicts, follow the instructions given by git merge
git commit -m "Merge master"
git push |
|
@Rudometov This change now passes all automated pre-integration checks. After integration, the commit message for the final commit will be: You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed. At the time when this comment was updated there had been no new commits pushed to the As you do not have Committer status in this project an existing Committer must agree to sponsor your change. Possible candidates are the reviewers of this PR (@phohensee) but any other Committer may sponsor as well. ➡️ To flag this PR as ready for integration with the above commit message, type |
|
/integrate |
|
@Rudometov |
|
/sponsor |
|
@phohensee @Rudometov Pushed as commit 3a1a2e0. 💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored. |
Backport for JDK-8233551 [TESTBUG] SelectEditTableCell.java fails on MacOS (openjdk/jdk@9b3fb5d)
Backport for test fix from JDK-7124218.
No risk, only a test change.
Clean backport except for ProblemList.
Test passes during manual run.
This PR depends on #160
Progress
Issue
Reviewers
Reviewing
Using
gitCheckout this PR locally:
$ git fetch https://git.openjdk.org/jdk8u-dev pull/162/head:pull/162$ git checkout pull/162Update a local copy of the PR:
$ git checkout pull/162$ git pull https://git.openjdk.org/jdk8u-dev pull/162/headUsing Skara CLI tools
Checkout this PR locally:
$ git pr checkout 162View PR using the GUI difftool:
$ git pr show -t 162Using diff file
Download this PR as a diff file:
https://git.openjdk.org/jdk8u-dev/pull/162.diff