8255559: Leak File Descriptors Because of ResolverLocalFilesystem#engineResolveURI()

[gnu-andrew]

Clean backport from 11u which fixes a resource leak.

Although the indentation changes in the diff make it a little unclear, the only change is to wrap the block in a try-finally clause (more visible with git diff -b)

---

Progress

• Change must not contain extraneous whitespace
• Commit message must refer to an issue

Issue

• JDK-8255559: Leak File Descriptors Because of ResolverLocalFilesystem#engineResolveURI()

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk8u-dev pull/165/head:pull/165
$ git checkout pull/165

Update a local copy of the PR:
$ git checkout pull/165
$ git pull https://git.openjdk.org/jdk8u-dev pull/165/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 165

View PR using the GUI difftool:
$ git pr show -t 165

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk8u-dev/pull/165.diff

[bridgekeeper]

👋 Welcome back andrew! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

[openjdk]

This backport pull request has now been updated with issue from the original commit.

[gnu-andrew]

/clean

[openjdk]

@gnu-andrew This backport pull request is now marked as clean

[openjdk]

@gnu-andrew This change now passes all automated pre-integration checks.

After integration, the commit message for the final commit will be:

8255559: Leak File Descriptors Because of ResolverLocalFilesystem#engineResolveURI()

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 1 new commit pushed to the master branch:

• 6e563e5: 8159720: Failure of C2 compilation with tiered prevents some C1 compilations

Please see this link for an up-to-date comparison between the source branch of this pull request and the master branch.
As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

[mlbridge]

Webrevs

• 00: Full (db11331c)

[gnu-andrew]

Approval requested on the bug.

[gnu-andrew]

I see jdk8u-fix-yes

[gnu-andrew]

/integrate

[openjdk]

Going to push as commit 41159a5.
Since your change was applied there have been 19 commits pushed to the master branch:

• df44cbf: 8073464: GC workers do not have thread names
• 9f2f0c2: 6885993: Named Thread: introduce print() and print_on(outputStream* st) methods
• c501bfa: 8269039: Disable SHA-1 Signed JARs
• 5a32484: 8297141: Fix hotspot/test/runtime/SharedArchiveFile/DefaultUseWithClient.java for 8u
• da0c382: 8241086: Test runtime/NMT/HugeArenaTracking.java is failing on 32bit Windows
• 91d8b89: 8129827: [TEST_BUG] Test java/awt/Robot/RobotWheelTest/RobotWheelTest.java fails
• 9cb8752: 8079255: [TEST_BUG] [macosx] Test closed/java/awt/Robot/RobotWheelTest/RobotWheelTest fails for Mac only
• b98d485: 8197859: VS2017 Complains about UINTPTR_MAX definition in globalDefinitions_VisCPP.hpp
• 7ae002c: 8286582: Build fails on macos aarch64 when using --with-zlib=bundled
• 6849667: 8284389: Improve stability of GHA Pre-submit testing by caching cygwin installer
• ... and 9 more: https://git.openjdk.org/jdk8u-dev/compare/01f7d1e3735ddddd4bd1796b962cf14395d6f4b2...master

Your commit was automatically rebased without conflicts.

[openjdk]

@gnu-andrew Pushed as commit 41159a5.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.