New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
8291570: [TESTBUG] Part of JDK-8250984 absent from 11u #175
Conversation
👋 Welcome back jdowland! A progress list of the required criteria for merging this PR into |
This backport pull request has now been updated with issue from the original commit. |
/clean |
@jmtd This backport pull request is now marked as clean |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes, same ordering issue we had in 11u for which I filed this bug. Please add jdk8u-fix-request
and I'll approve.
428514e
to
a591008
Compare
@jmtd Please do not rebase or force-push to an active PR as it invalidates existing review comments. All changes will be squashed into a single commit automatically when integrating. See OpenJDK Developers’ Guide for more information. |
@jmtd this pull request can not be integrated into git checkout 8291570-jdk8u-dev
git fetch https://git.openjdk.org/jdk8u-dev pr/171
git merge FETCH_HEAD
# resolve conflicts and follow the instructions given by git merge
git commit -m "Merge pr/171"
git push |
58b51ef
to
08917c6
Compare
The parent pull request that this pull request depends on has now been integrated and the target branch of this pull request has been updated. This means that changes from the dependent pull request can start to show up as belonging to this pull request, which may be confusing for reviewers. To remedy this situation, simply merge the latest changes from the new target branch into this pull request by running commands similar to these in the local repository for your personal fork: git checkout 8291570-jdk8u-dev
git fetch https://git.openjdk.org/jdk8u-dev master
git merge FETCH_HEAD
# if there are conflicts, follow the instructions given by git merge
git commit -m "Merge master"
git push |
Reviewed-by: serb, sgehwolf
a591008
to
6106bc9
Compare
@jmtd Please do not rebase or force-push to an active PR as it invalidates existing review comments. Note for future reference, the bots always squash all changes into a single commit automatically as part of the integration. See OpenJDK Developers’ Guide for more information. |
@jmtd This change now passes all automated pre-integration checks. After integration, the commit message for the final commit will be:
You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed. At the time when this comment was updated there had been no new commits pushed to the ➡️ To integrate this PR with the above commit message to the |
/integrate |
Going to push as commit d039c8d. |
This is a clean backport of 8291570 (from jdk11u) as part of cgroups v2 support.
The affected test passes for me after the patch.
Progress
Issue
Reviewers
Reviewing
Using
git
Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk8u-dev pull/175/head:pull/175
$ git checkout pull/175
Update a local copy of the PR:
$ git checkout pull/175
$ git pull https://git.openjdk.org/jdk8u-dev pull/175/head
Using Skara CLI tools
Checkout this PR locally:
$ git pr checkout 175
View PR using the GUI difftool:
$ git pr show -t 175
Using diff file
Download this PR as a diff file:
https://git.openjdk.org/jdk8u-dev/pull/175.diff