8073464: GC workers do not have thread names

[simonis]

This is a backport of "JDK-8073464: GC workers do not have thread names" which I request for parity with Oracle JDK 8 where it was downported to 8u351 (see JDK-8285732). This downport depends on "JDK-6885993: Named Thread: introduce print() and print_on(outputStream* st) methods" for which a pull request already exists.

Both of these changes are required to fix the native names of internal threads like for example GC threads. This does not only simplify debugging, but also helps observability tools. Finally, these two changes fix the "sun.management.HotspotInternal" MxBean which returns the "InternalThreadCpuTimes". The "InternalThreadCpuTimes" attribute returns a map with a thread-name to thread-cpu-time mapping but is currently broken in JDK 8 because internal threads without native names (e.g. GC threads) are all mapped to the same entry (i.e. "Unknown").

The patch applies cleanly except for two copyright year mismatches in concurrentGCThread.cpp and thread.hpp. I've attached a diff of this patch compared to the original JDK 9 patch to this PR for your convenience (see 8073464-jdk8-vs-jdk9.txt)

---

Progress

• Change must be properly reviewed (1 review required, with at least 1 Reviewer)
• Change must not contain extraneous whitespace
• Commit message must refer to an issue

Issue

• JDK-8073464: GC workers do not have thread names

Reviewers

• Paul Hohensee (@phohensee - Reviewer)
• Andrew John Hughes (@gnu-andrew - Reviewer)

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk8u-dev pull/184/head:pull/184
$ git checkout pull/184

Update a local copy of the PR:
$ git checkout pull/184
$ git pull https://git.openjdk.org/jdk8u-dev pull/184/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 184

View PR using the GUI difftool:
$ git pr show -t 184

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk8u-dev/pull/184.diff

[bridgekeeper]

👋 Welcome back simonis! A progress list of the required criteria for merging this PR into pr/183 will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

[openjdk]

This backport pull request has now been updated with issue from the original commit.

[mlbridge]

Webrevs

• 01: Full - Incremental (8b4a0541)
• 00: Full (8b4a0541)

[phohensee]

Lgtm.

[gnu-andrew]

Looks good to me.

[openjdk-notifier]

The parent pull request that this pull request depends on has now been integrated and the target branch of this pull request has been updated. This means that changes from the dependent pull request can start to show up as belonging to this pull request, which may be confusing for reviewers. To remedy this situation, simply merge the latest changes from the new target branch into this pull request by running commands similar to these in the local repository for your personal fork:

git checkout JDK-8073464
git fetch https://git.openjdk.org/jdk8u-dev master
git merge FETCH_HEAD
# if there are conflicts, follow the instructions given by git merge
git commit -m "Merge master"
git push

[openjdk]

@simonis This change now passes all automated pre-integration checks.

After integration, the commit message for the final commit will be:

8073464: GC workers do not have thread names

Reviewed-by: phh, andrew

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 6 new commits pushed to the master branch:

• 9f2f0c2: 6885993: Named Thread: introduce print() and print_on(outputStream* st) methods
• c501bfa: 8269039: Disable SHA-1 Signed JARs
• 5a32484: 8297141: Fix hotspot/test/runtime/SharedArchiveFile/DefaultUseWithClient.java for 8u
• da0c382: 8241086: Test runtime/NMT/HugeArenaTracking.java is failing on 32bit Windows
• 91d8b89: 8129827: [TEST_BUG] Test java/awt/Robot/RobotWheelTest/RobotWheelTest.java fails
• 9cb8752: 8079255: [TEST_BUG] [macosx] Test closed/java/awt/Robot/RobotWheelTest/RobotWheelTest fails for Mac only

Please see this link for an up-to-date comparison between the source branch of this pull request and the master branch.
As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

[simonis]

/integrate

[openjdk]

Going to push as commit df44cbf.
Since your change was applied there have been 6 commits pushed to the master branch:

• 9f2f0c2: 6885993: Named Thread: introduce print() and print_on(outputStream* st) methods
• c501bfa: 8269039: Disable SHA-1 Signed JARs
• 5a32484: 8297141: Fix hotspot/test/runtime/SharedArchiveFile/DefaultUseWithClient.java for 8u
• da0c382: 8241086: Test runtime/NMT/HugeArenaTracking.java is failing on 32bit Windows
• 91d8b89: 8129827: [TEST_BUG] Test java/awt/Robot/RobotWheelTest/RobotWheelTest.java fails
• 9cb8752: 8079255: [TEST_BUG] [macosx] Test closed/java/awt/Robot/RobotWheelTest/RobotWheelTest fails for Mac only

Your commit was automatically rebased without conflicts.

[openjdk]

@simonis Pushed as commit df44cbf.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.