8229182: [TESTBUG] runtime/containers/docker/TestMemoryAwareness.java test fails on SLES12

[lutkerd]

Backporting JDK-8229182, did not apply cleanly and had to be manually fixed up.

---

Progress

• Change must be properly reviewed (1 review required, with at least 1 Reviewer)
• Change must not contain extraneous whitespace
• Commit message must refer to an issue

Issue

• JDK-8229182: [TESTBUG] runtime/containers/docker/TestMemoryAwareness.java test fails on SLES12

Reviewers

• Paul Hohensee (@phohensee - Reviewer)

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk8u-dev pull/186/head:pull/186
$ git checkout pull/186

Update a local copy of the PR:
$ git checkout pull/186
$ git pull https://git.openjdk.org/jdk8u-dev pull/186/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 186

View PR using the GUI difftool:
$ git pr show -t 186

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk8u-dev/pull/186.diff

[bridgekeeper]

👋 Welcome back lutkerd! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

[openjdk]

This backport pull request has now been updated with issue from the original commit.

[mlbridge]

Webrevs

• 01: Full - Incremental (3c86d09b)
• 00: Full (6d7e325a)

[phohensee]

The copyright line in TestMemoryAwareness and DockerRunOptions.java should be

• Copyright (c) 2017, 2019, Oracle and/or its affiliates. All rights reserved.

Otherwise, lgtm.

[lutkerd]

The copyright line in TestMemoryAwareness and DockerRunOptions.java should be

* Copyright (c) 2017, 2019, Oracle and/or its affiliates. All rights reserved.

Thanks, fixed!

[phohensee]

Lgtm.

[openjdk-notifier]

@lutkerd Please do not rebase or force-push to an active PR as it invalidates existing review comments. All changes will be squashed into a single commit automatically when integrating. See OpenJDK Developers’ Guide for more information.

[openjdk]

@lutkerd This change now passes all automated pre-integration checks.

After integration, the commit message for the final commit will be:

8229182: [TESTBUG] runtime/containers/docker/TestMemoryAwareness.java test fails on SLES12

Reviewed-by: phh

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 54 new commits pushed to the master branch:

• 47090d6: 8297996: [8u] generated images are broken due to renaming of MSVC runtime DLL's
• b4a745d: 8284977: MetricsTesterCgroupV2.getLongValueEntryFromFile fails when named value doesn't exist
• b4ef3d3: 8292083: Detected container memory limit may exceed physical machine memory
• 78cdc41: 8234484: Add ability to configure third port for remote JMX
• 06546d7: 8284102: [TESTBUG] [11u] Retroactively add regression test for JDK-8272124
• 9f76da9: 8284756: [11u] Remove unused isUseContainerSupport in CgroupV1Subsystem
• d6101df: 8254717: isAssignableFrom checks in KeyFactorySpi.engineGetKeySpec appear to be backwards
• 99ff02e: 8266391: Replace use of reflection in jdk.internal.platform.Metrics
• 0662db2: 8252957: Wrong comment in CgroupV1Subsystem::cpu_quota
• d039c8d: 8291570: [TESTBUG] Part of JDK-8250984 absent from 11u
• ... and 44 more: https://git.openjdk.org/jdk8u-dev/compare/5a32484f0f3be91ccaef76271361ef2fbfdf7558...master

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

As you do not have Committer status in this project an existing Committer must agree to sponsor your change. Possible candidates are the reviewers of this PR (@phohensee) but any other Committer may sponsor as well.

➡️ To flag this PR as ready for integration with the above commit message, type /integrate in a new comment. (Afterwards, your sponsor types /sponsor in a new comment to perform the integration).

[jerboaa]

This seems fine, but could this wait until after 8u-dev forks to 8u372 (probably next week) and we integrate the cg v2 backports as this conflicts with the patch set?

Note, the work-around seems to be to add cgroup_enable=memory swapaccount=1 to the kernel command line on the test host.

[lutkerd]

Sure, we can wait.

[jerboaa]

Thanks!

[jerboaa]

@lutkerd Feel free to go ahead and integrate. Thanks!

[lutkerd]

/integrate

[openjdk]

@lutkerd
Your change (at version 3c86d09) is now ready to be sponsored by a Committer.

[phohensee]

/sponsor

[openjdk]

Going to push as commit c5751e6.
Since your change was applied there have been 54 commits pushed to the master branch:

• 47090d6: 8297996: [8u] generated images are broken due to renaming of MSVC runtime DLL's
• b4a745d: 8284977: MetricsTesterCgroupV2.getLongValueEntryFromFile fails when named value doesn't exist
• b4ef3d3: 8292083: Detected container memory limit may exceed physical machine memory
• 78cdc41: 8234484: Add ability to configure third port for remote JMX
• 06546d7: 8284102: [TESTBUG] [11u] Retroactively add regression test for JDK-8272124
• 9f76da9: 8284756: [11u] Remove unused isUseContainerSupport in CgroupV1Subsystem
• d6101df: 8254717: isAssignableFrom checks in KeyFactorySpi.engineGetKeySpec appear to be backwards
• 99ff02e: 8266391: Replace use of reflection in jdk.internal.platform.Metrics
• 0662db2: 8252957: Wrong comment in CgroupV1Subsystem::cpu_quota
• d039c8d: 8291570: [TESTBUG] Part of JDK-8250984 absent from 11u
• ... and 44 more: https://git.openjdk.org/jdk8u-dev/compare/5a32484f0f3be91ccaef76271361ef2fbfdf7558...master

Your commit was automatically rebased without conflicts.

[openjdk]

@phohensee @lutkerd Pushed as commit c5751e6.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.