-
Notifications
You must be signed in to change notification settings - Fork 152
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
8296480: java/security/cert/pkix/policyChanges/TestPolicy.java is failing #189
Conversation
👋 Welcome back aoqi! A progress list of the required criteria for merging this PR into |
This backport pull request has now been updated with issue from the original commit. |
/clean |
@phohensee This backport pull request is now marked as clean |
@theaoqi This change now passes all automated pre-integration checks. After integration, the commit message for the final commit will be:
You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed. At the time when this comment was updated there had been 17 new commits pushed to the
As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details. As you do not have Committer status in this project an existing Committer must agree to sponsor your change. ➡️ To flag this PR as ready for integration with the above commit message, type |
I see |
/integrate |
Please enable testing on your fork going forward. |
/sponsor |
Going to push as commit 21a1236.
Your commit was automatically rebased without conflicts. |
Thanks, @jerboaa ! I have realized GHA of my fork is disabled after the PR is created and I have enabled it, but I don't know how to trigger it manually. It will work next time:) |
I request the backport for parity with Oracle JDK 8. The patch applies clean. This backport is only a test change and fixes the test failure.
Progress
Issue
Reviewing
Using
git
Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk8u-dev pull/189/head:pull/189
$ git checkout pull/189
Update a local copy of the PR:
$ git checkout pull/189
$ git pull https://git.openjdk.org/jdk8u-dev pull/189/head
Using Skara CLI tools
Checkout this PR locally:
$ git pr checkout 189
View PR using the GUI difftool:
$ git pr show -t 189
Using diff file
Download this PR as a diff file:
https://git.openjdk.org/jdk8u-dev/pull/189.diff