8235218: Minimal VM is broken after JDK-8173361

[dongbohe]

Hi,

I would like to backport this as follow up of JDK-8173361, only a different context.

Thanks,
hedongbo

---

Progress

• Change must be properly reviewed (1 review required, with at least 1 Reviewer)
• Change must not contain extraneous whitespace
• Commit message must refer to an issue

Issue

• JDK-8235218: Minimal VM is broken after JDK-8173361

Reviewers

• Severin Gehwolf (@jerboaa - Reviewer)
• Andrew John Hughes (@gnu-andrew - Reviewer)

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk8u-dev pull/19/head:pull/19
$ git checkout pull/19

Update a local copy of the PR:
$ git checkout pull/19
$ git pull https://git.openjdk.org/jdk8u-dev pull/19/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 19

View PR using the GUI difftool:
$ git pr show -t 19

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk8u-dev/pull/19.diff

[bridgekeeper]

👋 Welcome back dongbohe! A progress list of the required criteria for merging this PR into pr/9 will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

[openjdk]

This backport pull request has now been updated with issue from the original commit.

[mlbridge]

Webrevs

• 02: Full - Incremental (cc2d6785)
• 01: Full - Incremental (c12d8390)
• 00: Full (149be4cf)

[bridgekeeper]

@dongbohe This pull request has been inactive for more than 4 weeks and will be automatically closed if another 4 weeks passes without any activity. To avoid this, simply add a new comment to the pull request. Feel free to ask for assistance if you need help with progressing this pull request towards integration!

[bridgekeeper]

@dongbohe This pull request has been inactive for more than 8 weeks and will now be automatically closed. If you would like to continue working on this pull request in the future, feel free to reopen it! This can be done using the /open pull request command.

[dongbohe]

/open

[openjdk]

@dongbohe This pull request is now open

[bridgekeeper]

@dongbohe This pull request has been inactive for more than 4 weeks and will be automatically closed if another 4 weeks passes without any activity. To avoid this, simply add a new comment to the pull request. Feel free to ask for assistance if you need help with progressing this pull request towards integration!

[gnu-andrew]

The target of this PR seems wrong. It should be 8u/master not 8u/pr/9. Maybe easier to start fresh?

[openjdk-notifier]

The dependent pull request has now been integrated, and the target branch of this pull request has been updated. This means that changes from the dependent pull request can start to show up as belonging to this pull request, which may be confusing for reviewers. To remedy this situation, simply merge the latest changes from the new target branch into this pull request by running commands similar to these in the local repository for your personal fork:

git checkout 8235218
git fetch https://git.openjdk.org/jdk8u-dev master
git merge FETCH_HEAD
# if there are conflicts, follow the instructions given by git merge
git commit -m "Merge master"
git push

[dongbohe]

According to the description of New Skara feature: dependent pull requests, we need to target to pr/9.

It seems that I need to merge master, I will try.

[dongbohe]

It looks ok.

[dongbohe]

@gnu-andrew Hi, Andrew. Could you please take another look?

[jerboaa]

Looks OK.

[openjdk]

@dongbohe This change now passes all automated pre-integration checks.

After integration, the commit message for the final commit will be:

8235218: Minimal VM is broken after JDK-8173361

Reviewed-by: sgehwolf, andrew

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 4 new commits pushed to the master branch:

• eeef4de: 8150669: C1 intrinsic for Class.isPrimitive
• 6e8292f: 8283849: AsyncGetCallTrace may crash JVM on guarantee
• ce73401: 8136354: [TEST_BUG] Test java/awt/image/RescaleOp/RescaleAlphaTest.java with Bad action for script
• a3c0ed2: 8087283: Add support for the XML Signature here() function to the JDK XPath implementation

Please see this link for an up-to-date comparison between the source branch of this pull request and the master branch.
As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

As you do not have Committer status in this project an existing Committer must agree to sponsor your change. Possible candidates are the reviewers of this PR (@jerboaa, @gnu-andrew) but any other Committer may sponsor as well.

➡️ To flag this PR as ready for integration with the above commit message, type /integrate in a new comment. (Afterwards, your sponsor types /sponsor in a new comment to perform the integration).

[dongbohe]

Got the push approval.
/integrate

[openjdk]

@dongbohe
Your change (at version cc2d678) is now ready to be sponsored by a Committer.

[gnu-andrew]

According to the description of New Skara feature: dependent pull requests, we need to target to pr/9.

It seems that I need to merge master, I will try.

Ah ok, that's the first I've heard of that. It seems the mail was only sent to jdk-dev and not the jdk-updates or jdk8u lists.

[gnu-andrew]

Backport itself looks clean.

[gnu-andrew]

/sponsor

[openjdk]

Going to push as commit e005185.
Since your change was applied there have been 4 commits pushed to the master branch:

• eeef4de: 8150669: C1 intrinsic for Class.isPrimitive
• 6e8292f: 8283849: AsyncGetCallTrace may crash JVM on guarantee
• ce73401: 8136354: [TEST_BUG] Test java/awt/image/RescaleOp/RescaleAlphaTest.java with Bad action for script
• a3c0ed2: 8087283: Add support for the XML Signature here() function to the JDK XPath implementation

Your commit was automatically rebased without conflicts.

[openjdk]

@gnu-andrew @dongbohe Pushed as commit e005185.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.