-
Notifications
You must be signed in to change notification settings - Fork 158
8282458: Update .jcheck/conf file for 8u move to git #2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
👋 Welcome back andrew! A progress list of the required criteria for merging this PR into |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
@gnu-andrew This change now passes all automated pre-integration checks. After integration, the commit message for the final commit will be:
You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed. At the time when this comment was updated there had been no new commits pushed to the ➡️ To integrate this PR with the above commit message to the |
Just waiting on jdk8u-fix-yes before push. |
I've approved. Looking forward to see the bots resolve the bugs correctly once it's integrated :) |
/integrate |
Going to push as commit 4a19c1a. |
@gnu-andrew Pushed as commit 4a19c1a. 💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored. |
And it worked! :) |
This space deliberately left empty.
Progress
Issue
Reviewers
Reviewing
Using
git
Checkout this PR locally:
$ git fetch https://git.openjdk.java.net/jdk8u-dev pull/2/head:pull/2
$ git checkout pull/2
Update a local copy of the PR:
$ git checkout pull/2
$ git pull https://git.openjdk.java.net/jdk8u-dev pull/2/head
Using Skara CLI tools
Checkout this PR locally:
$ git pr checkout 2
View PR using the GUI difftool:
$ git pr show -t 2
Using diff file
Download this PR as a diff file:
https://git.openjdk.java.net/jdk8u-dev/pull/2.diff