8255239: The timezone of the hs_err_pid log file is corrupted in Japanese locale #20

ktakakuri · 2022-03-22T07:04:16Z

This is a backport of JDK-8282051: The timezone of the hs_err_pid log file is corrupted in Japanese locale.

I would like to backport the patch to openjdk8u.
Original patch does not apply cleanly to 8u.
Because the format of time zone in hs_err_pid log is different from 11u and later.
The following is the example of time zone info:
jdk11:
Time: Sat Mar 12 00:14:03 2022 Tokyo Standard Time elapsed time: 0 seconds (0d 0h 0m 0s)
jdk8:
time: Sat Mar 12 00:09:26 2022
timezone: Tokyo Standard Time
elapsed time: 2.736524 seconds (0d 0h 0m 2s)

Testing:
build on Windows x86_64
hotspot/runtime on Windows x86_64
a specific test to confirm the fix in Japanese locale

Could you please review this PR?

Progress

Change must not contain extraneous whitespace
Commit message must refer to an issue
Change must be properly reviewed

Issue

JDK-8255239: The timezone of the hs_err_pid log file is corrupted in Japanese locale

Reviewers

Andrew John Hughes (@gnu-andrew - Reviewer)

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.java.net/jdk8u-dev pull/20/head:pull/20
$ git checkout pull/20

Update a local copy of the PR:
$ git checkout pull/20
$ git pull https://git.openjdk.java.net/jdk8u-dev pull/20/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 20

View PR using the GUI difftool:
$ git pr show -t 20

Using diff file

Download this PR as a diff file:
https://git.openjdk.java.net/jdk8u-dev/pull/20.diff

bridgekeeper · 2022-03-22T07:04:42Z

👋 Welcome back ktakakuri! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

mlbridge · 2022-03-22T07:09:55Z

Webrevs

00: Full (ca0fcc4c)

phohensee

You cannot backport a backport: this PR references the 11u backport issue rather than the original issue. Please close this PR and create a new one referencing the commit for the original issue, which is JDK-8255239.

gnu-andrew · 2022-03-22T18:58:05Z

You cannot backport a backport: this PR references the 11u backport issue rather than the original issue. Please close this PR and create a new one referencing the commit for the original issue, which is JDK-8255239.

You shouldn't need to dump this PR. Just change the subject to "Backport b46d73bee808af7891b699df30a5a6dec3f5139f"

ktakakuri · 2022-03-28T08:30:27Z

You cannot backport a backport: this PR references the 11u backport issue rather than the original issue. Please close this PR and create a new one referencing the commit for the original issue, which is JDK-8255239.

You shouldn't need to dump this PR. Just change the subject to "Backport b46d73bee808af7891b699df30a5a6dec3f5139f"

This backport is not clean.
Would it be ok to just change the commit message?
Should the PR title be changed to "Backport b46d73bee808af7891b699df30a5a6dec3f5139f"?

jerboaa · 2022-03-28T09:01:51Z

You cannot backport a backport: this PR references the 11u backport issue rather than the original issue. Please close this PR and create a new one referencing the commit for the original issue, which is JDK-8255239.

You shouldn't need to dump this PR. Just change the subject to "Backport b46d73bee808af7891b699df30a5a6dec3f5139f"

This backport is not clean.

OK. Once the bot recognizes it as a backport this should be apparent by the bot not adding the clean label.

Would it be ok to just change the commit message?

It's OK, but it wouldn't change anything. The Skara bots go by PR title.

Should the PR title be changed to "Backport b46d73bee808af7891b699df30a5a6dec3f5139f"?

Yes.

gnu-andrew · 2022-03-28T19:57:01Z

You cannot backport a backport: this PR references the 11u backport issue rather than the original issue. Please close this PR and create a new one referencing the commit for the original issue, which is JDK-8255239.

You shouldn't need to dump this PR. Just change the subject to "Backport b46d73bee808af7891b699df30a5a6dec3f5139f"

This backport is not clean.

Few 8u backports are. I don't expect any to be automatically picked up as clean by the bot as even those we human maintainers regard as clean require path shuffling.

Either way, the correct PR title needs to be used so the bot will link this PR to the original issue correctly.

Would it be ok to just change the commit message? Should the PR title be changed to "Backport b46d73bee808af7891b699df30a5a6dec3f5139f"?

You can change the commit message to whatever you like. The bot really doesn't care about it. The PR title does need to be changed as you mention, so the bot picks that up, links in the original bug and sets the PR title to that of the bug.

Once the PR title change is made, we can review the patch :-)

openjdk · 2022-03-29T06:12:12Z

This backport pull request has now been updated with issue from the original commit.

gnu-andrew · 2022-03-29T15:56:19Z

Thanks. The backport looks ok to me. Do you have access to the OpenJDK bug system? If not, I can add the jdk8u-fix-request label on your behalf.

ktakakuri · 2022-03-30T06:20:46Z

Thanks. The backport looks ok to me. Do you have access to the OpenJDK bug system? If not, I can add the jdk8u-fix-request label on your behalf.

Thank you for your cooperation.
Could you add the label?

gnu-andrew

Done. jdk8u-fix-request label added and approval given via jdk8u-fix-yes. I'll sponsor this once it's submitted for integration.

openjdk · 2022-03-30T11:55:11Z

@ktakakuri This change now passes all automated pre-integration checks.

After integration, the commit message for the final commit will be:

8255239: The timezone of the hs_err_pid log file is corrupted in Japanese locale

Reviewed-by: andrew

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 10 new commits pushed to the master branch:

e403fd5: 8274751: Drag And Drop hangs on Windows
f8a6695: 8274658: ISO 4217 Amendment 170 Update
57d8d29: 8132256: jaxp: Investigate removal of com/sun/org/apache/bcel/internal/util/ClassPath.java
bb69732: 8129572: Cleanup usage of getResourceAsStream in jaxp
969f31e: Merge
0183285: Added tag jdk8u332-b05 for changeset 2a92df021686
3a7c382: 8041523: Xerces Update: Serializer improvements from Xalan
2bbec15: 8230865: [TESTBUG] jdk/jfr/event/io/EvilInstrument.java fails at-run shell MakeJAR.sh target
25693fa: 8223396: [TESTBUG] several jfr tests do not clean up files created in /tmp
5fcfb7a: 8194154: System property user.dir should not be changed

Please see this link for an up-to-date comparison between the source branch of this pull request and the master branch.
As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

As you do not have Committer status in this project an existing Committer must agree to sponsor your change. Possible candidates are the reviewers of this PR (@phohensee, @gnu-andrew) but any other Committer may sponsor as well.

➡️ To flag this PR as ready for integration with the above commit message, type /integrate in a new comment. (Afterwards, your sponsor types /sponsor in a new comment to perform the integration).

ktakakuri · 2022-03-31T06:04:41Z

/integrate

openjdk · 2022-03-31T06:06:32Z

@ktakakuri
Your change (at version ca0fcc4) is now ready to be sponsored by a Committer.

gnu-andrew · 2022-04-02T15:06:07Z

/sponsor

openjdk · 2022-04-02T15:06:56Z

Going to push as commit c5ca29f.
Since your change was applied there have been 10 commits pushed to the master branch:

e403fd5: 8274751: Drag And Drop hangs on Windows
f8a6695: 8274658: ISO 4217 Amendment 170 Update
57d8d29: 8132256: jaxp: Investigate removal of com/sun/org/apache/bcel/internal/util/ClassPath.java
bb69732: 8129572: Cleanup usage of getResourceAsStream in jaxp
969f31e: Merge
0183285: Added tag jdk8u332-b05 for changeset 2a92df021686
3a7c382: 8041523: Xerces Update: Serializer improvements from Xalan
2bbec15: 8230865: [TESTBUG] jdk/jfr/event/io/EvilInstrument.java fails at-run shell MakeJAR.sh target
25693fa: 8223396: [TESTBUG] several jfr tests do not clean up files created in /tmp
5fcfb7a: 8194154: System property user.dir should not be changed

Your commit was automatically rebased without conflicts.

openjdk · 2022-04-02T15:07:19Z

@gnu-andrew @ktakakuri Pushed as commit c5ca29f.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

Backport e2f792c54919d3bb42901ed3c23e8c846db03852

ca0fcc4

openjdk bot added the rfr Pull request is ready for review label Mar 22, 2022

phohensee reviewed Mar 22, 2022

View reviewed changes

ktakakuri changed the title ~~8282051: The timezone of the hs_err_pid log file is corrupted in Japanese locale~~ Backport b46d73bee808af7891b699df30a5a6dec3f5139f Mar 29, 2022

openjdk bot changed the title ~~Backport b46d73bee808af7891b699df30a5a6dec3f5139f~~ 8255239: The timezone of the hs_err_pid log file is corrupted in Japanese locale Mar 29, 2022

openjdk bot added the backport Port of a pull request already in a different code base label Mar 29, 2022

gnu-andrew approved these changes Mar 30, 2022

View reviewed changes

openjdk bot added the ready Pull request is ready to be integrated label Mar 30, 2022

openjdk bot added the sponsor Pull request is ready to be sponsored label Mar 31, 2022

openjdk bot added the integrated Pull request has been integrated label Apr 2, 2022

openjdk bot closed this Apr 2, 2022

openjdk bot removed ready Pull request is ready to be integrated rfr Pull request is ready for review sponsor Pull request is ready to be sponsored labels Apr 2, 2022

ktakakuri deleted the 8282051 branch June 22, 2022 06:14

8255239: The timezone of the hs_err_pid log file is corrupted in Japanese locale #20

8255239: The timezone of the hs_err_pid log file is corrupted in Japanese locale #20

Uh oh!

Conversation

ktakakuri commented Mar 22, 2022 • edited by openjdk bot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Progress

Issue

Reviewers

Reviewing

Uh oh!

bridgekeeper bot commented Mar 22, 2022

Uh oh!

mlbridge bot commented Mar 22, 2022

Webrevs

Uh oh!

phohensee left a comment

Choose a reason for hiding this comment

Uh oh!

gnu-andrew commented Mar 22, 2022

Uh oh!

ktakakuri commented Mar 28, 2022

Uh oh!

jerboaa commented Mar 28, 2022

Uh oh!

gnu-andrew commented Mar 28, 2022

Uh oh!

openjdk bot commented Mar 29, 2022

Uh oh!

gnu-andrew commented Mar 29, 2022

Uh oh!

ktakakuri commented Mar 30, 2022

Uh oh!

gnu-andrew left a comment

Choose a reason for hiding this comment

Uh oh!

openjdk bot commented Mar 30, 2022 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

ktakakuri commented Mar 31, 2022

Uh oh!

openjdk bot commented Mar 31, 2022

Uh oh!

gnu-andrew commented Apr 2, 2022

Uh oh!

openjdk bot commented Apr 2, 2022

Uh oh!

openjdk bot commented Apr 2, 2022

Uh oh!

Uh oh!

ktakakuri commented Mar 22, 2022 •

edited by openjdk bot

Loading

openjdk bot commented Mar 30, 2022 •

edited

Loading