New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
8296108: (tz) Update Timezone Data to 2022f #200
Conversation
👋 Welcome back dcherepanov! A progress list of the required criteria for merging this PR into |
This backport pull request has now been updated with issue from the original commit. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Lgtm.
@dimitryc This change now passes all automated pre-integration checks. After integration, the commit message for the final commit will be:
You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed. At the time when this comment was updated there had been no new commits pushed to the ➡️ To integrate this PR with the above commit message to the |
Thanks for doing this. I've been meaning to get to it myself, but not had chance. I've verified the patch against the 11u version and the rearguard tzdata2022f, and it looks fine. However, we should have this PR against https://github.com/openjdk/jdk8u so it will make 8u362. The changes are already overdue and 2022g will likely need to be integrated as well before we freeze 8u362 (https://bugs.openjdk.org/browse/JDK-8297804) |
Thanks. I've created new PR against jdk8u - openjdk/jdk8u#25 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Verified the patch against the 11u version and the rearguard tzdata2022f, and it looks fine.
Please label the bug with jdk8u-critical-request and add an approval request comment.
Ugh, wrong PR. Done the same on openjdk/jdk8u#25 now. Note that you need to enable actions on your 8u fork. It doesn't matter for this one, as it passed tests here, but good to sort for any future PRs. |
Sorry, I forgot about actions when created a new fork (enabled now). I'll close this PR given that the change will go to the jdk8u repo. |
Please review the timezone data update to 2022f
The existing data was replaced with the new data generated from tzdb-2022f in the rearguard format. This also includes updating a copy of the data in tests (jdk/test/sun/util/calendar/zi/tzdata).
Other parts of the original patch applied cleanly after path changes (jdk/src/share/classes/sun/util/resources and jdk/test/java/util/TimeZone/TimeZoneData).
Testing: all relevant tests passed jdk/test/java/util/TimeZone, jdk/test/sun/util/calendar and jdk/test/java/time/test
Progress
Issue
Reviewers
Reviewing
Using
git
Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk8u-dev pull/200/head:pull/200
$ git checkout pull/200
Update a local copy of the PR:
$ git checkout pull/200
$ git pull https://git.openjdk.org/jdk8u-dev pull/200/head
Using Skara CLI tools
Checkout this PR locally:
$ git pr checkout 200
View PR using the GUI difftool:
$ git pr show -t 200
Using diff file
Download this PR as a diff file:
https://git.openjdk.org/jdk8u-dev/pull/200.diff