-
Notifications
You must be signed in to change notification settings - Fork 150
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
8298307: Enable hotspot/tier1 for 32-bit builds in GHA for 8u #204
Conversation
👋 Welcome back zzambers! A progress list of the required criteria for merging this PR into |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, thanks!
@zzambers This change now passes all automated pre-integration checks. After integration, the commit message for the final commit will be:
You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed. At the time when this comment was updated there had been 1 new commit pushed to the
Please see this link for an up-to-date comparison between the source branch of this pull request and the As you do not have Committer status in this project an existing Committer must agree to sponsor your change. Possible candidates are the reviewers of this PR (@jerboaa) but any other Committer may sponsor as well. ➡️ To flag this PR as ready for integration with the above commit message, type |
@jerboaa Thank you for review |
/integrate |
/sponsor |
All issues in hotspot/tier1 affecting 32-bit builds are now resolved so these configurations can now be enabled in GHA. This is the last piece to have full tier1 testing on all platforms we have in GHA.
Notes:
Progress
Issue
Reviewers
Reviewing
Using
git
Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk8u-dev pull/204/head:pull/204
$ git checkout pull/204
Update a local copy of the PR:
$ git checkout pull/204
$ git pull https://git.openjdk.org/jdk8u-dev pull/204/head
Using Skara CLI tools
Checkout this PR locally:
$ git pr checkout 204
View PR using the GUI difftool:
$ git pr show -t 204
Using diff file
Download this PR as a diff file:
https://git.openjdk.org/jdk8u-dev/pull/204.diff