8282511: Use fixed certificate validation date in SSLExampleCert template

[wkia]

Test files changed only.

The original changes use JDK17 strings in SSLExampleCert.java, so it was adapted for JDK8 with the additional commit as it was done for JDK11 backport.

Additionaly the test uses 'hosts' file substitution that is not available in JDK8. So, it was replaced with a custom NameService implementation.

There were 2 changes with test files paths:

• Original test/jdk/javax/net/ssl/ServerName/EndingDotHostname.java path changed to jdk/test/javax/net/ssl/ServerName/EndingDotHostname.java.
• Original test/jdk/javax/net/ssl/templates/SSLExampleCert.java path changed to jdk/test/javax/net/ssl/templates/SSLExampleCert.java.

Please note that this PR is a part of dependant PR chain
Prev PRs:

• 8065422: Trailing dot in hostname causes TLS handshake to fail with SNI disabled #205
• 8282398: EndingDotHostname.java test fails because SSL cert expired #206

---

Progress

• Change must not contain extraneous whitespace
• Commit message must refer to an issue
• Change must be properly reviewed (2 reviews required, with at least 2 Reviewers)

Issues

• JDK-8282511: Use fixed certificate validation date in SSLExampleCert template
• JDK-8299445: EndingDotHostname.java fails because of compilation errors

Reviewers

• Yuri Nesterenko (@yan-too - Reviewer) ⚠️ Review applies to d71de914
• Andrew John Hughes (@gnu-andrew - Reviewer)

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk8u-dev pull/207/head:pull/207
$ git checkout pull/207

Update a local copy of the PR:
$ git checkout pull/207
$ git pull https://git.openjdk.org/jdk8u-dev pull/207/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 207

View PR using the GUI difftool:
$ git pr show -t 207

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk8u-dev/pull/207.diff

[bridgekeeper]

👋 Welcome back rmarchenko! A progress list of the required criteria for merging this PR into pr/206 will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

[openjdk]

This backport pull request has now been updated with issue from the original commit.

[mlbridge]

Webrevs

• 05: Full - Incremental (740b5dad)
• 04: Full (d71de914)
• 03: Full - Incremental (491b6b93)
• 02: Full (58e3086a)
• 01: Full - Incremental (7781cea9)
• 00: Full (7781cea9)

[wkia]

/clean

[openjdk]

@wkia Only OpenJDK Committers can use the /clean command

[gnu-andrew]

/reviewers 2 reviewer

[openjdk]

@gnu-andrew
The total number of required reviews for this PR (including the jcheck configuration and the last /reviewers command) is now set to 2 (with at least 2 Reviewers).

[openjdk]

@wkia Please do not rebase or force-push to an active PR as it invalidates existing review comments. Note for future reference, the bots always squash all changes into a single commit automatically as part of the integration. See OpenJDK Developers’ Guide for more information.

[openjdk]

⚠️ @wkia This pull request contains merges that bring in commits not present in the target repository. Since this is not a "merge style" pull request, these changes will be squashed when this pull request in integrated. If this is your intention, then please ignore this message. If you want to preserve the commit structure, you must change the title of this pull request to Merge <project>:<branch> where <project> is the name of another project in the OpenJDK organization (for example Merge jdk:master).

[wkia]

The original changes use JDK17 strings in SSLExampleCert.java, so it was adapted for JDK8 with the additional commit as it was done for JDK11 backport.

Additionaly the test uses 'hosts' file substitution that is not available in JDK8. So, it was replaced with a custom NameService implementation.

Force-pushed to keep the commit history clean to make reviewing easier.

[openjdk]

@wkia Please do not rebase or force-push to an active PR as it invalidates existing review comments. Note for future reference, the bots always squash all changes into a single commit automatically as part of the integration. See OpenJDK Developers’ Guide for more information.

[wkia]

@gnu-andrew Could you also review this, please?

[openjdk-notifier]

The parent pull request that this pull request depends on has now been integrated and the target branch of this pull request has been updated. This means that changes from the dependent pull request can start to show up as belonging to this pull request, which may be confusing for reviewers. To remedy this situation, simply merge the latest changes from the new target branch into this pull request by running commands similar to these in the local repository for your personal fork:

git checkout backport-268fa693188b685de6289927ee5a1e99473a50f6
git fetch https://git.openjdk.org/jdk8u-dev master
git merge FETCH_HEAD
# if there are conflicts, follow the instructions given by git merge
git commit -m "Merge master"
git push

[openjdk]

@wkia this pull request can not be integrated into master due to one or more merge conflicts. To resolve these merge conflicts and update this pull request you can run the following commands in the local repository for your personal fork:

git checkout backport-268fa693188b685de6289927ee5a1e99473a50f6
git fetch https://git.openjdk.org/jdk8u-dev master
git merge FETCH_HEAD
# resolve conflicts and follow the instructions given by git merge
git commit -m "Merge master"
git push

[wkia]

@gnu-andrew Could you re-review, please?

[gnu-andrew]

The original changes use JDK17 strings in SSLExampleCert.java, so it was adapted for JDK8 with the additional commit as it was done for JDK11 backport.

As far as I can see, the 11u backport still had text blocks. Do you mean you've also included the changes in JDK-8299445 here? If so, we should reference it too.

Additionaly the test uses 'hosts' file substitution that is not available in JDK8. So, it was replaced with a custom NameService implementation.

Force-pushed to keep the commit history clean to make reviewing easier.

Thanks for removing the superfluous module line.

Is there a reason the custom NameService creates an InetAddress using an internal API rather than just returning InetAddress.getLoopbackAddress() which would be closer to the 11u code?

Has the test been run successfully on 8u? The follow-up fix on 11u suggests this wasn't done before committing the fix to 11u.

[gnu-andrew]

/issue JDK-8299445

[openjdk]

@gnu-andrew Only the author (@wkia) is allowed to issue the /issue command.

[wkia]

/issue JDK-8299445

[openjdk]

@wkia
Adding additional issue to issue list: 8299445: EndingDotHostname.java fails because of compilation errors.

[wkia]

As far as I can see, the 11u backport still had text blocks. Do you mean you've also included the changes in JDK-8299445 here? If so, we should reference it too.

Thanks, I added the reference. Should I add "jdk8u-fix-request" label to JDK-8299445?

Is there a reason the custom NameService creates an InetAddress using an internal API rather than just returning InetAddress.getLoopbackAddress() which would be closer to the 11u code?

Sounds reasonable, thanks. I've updated the code.

Has the test been run successfully on 8u? The follow-up fix on 11u suggests this wasn't done before committing the fix to 11u.

Yes, it passes successfully on my Win11/Cygwin.

[gnu-andrew]

Thanks, that looks a lot simpler.

Yes, jdk8u-fix-request can be added to the bug now all reviews are complete. Once you've done that, I'll approve and you can run the integrate command.

Thanks for persisting with this one.

[openjdk]

@wkia This change now passes all automated pre-integration checks.

After integration, the commit message for the final commit will be:

8282511: Use fixed certificate validation date in SSLExampleCert template
8299445: EndingDotHostname.java fails because of compilation errors

Reviewed-by: yan, andrew

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 26 new commits pushed to the master branch:

• 8995356: 6734341: REGTEST fails: SelectionAutoscrollTest.html
• 11a96a7: 8156581: Cleanup of ProblemList.txt
• fd41600: 8205959: Do not restart close if errno is EINTR
• b71f59b: 8298027: Remove SCCS id's from awt jtreg tests
• fbaabf3: 8301620: [8u] some shell tests are passed but have unexpected operator errors
• 8c42e20: 8287109: Distrust.java failed with CertificateExpiredException
• 784f71f: 7124381: DragSourceListener.dragDropEnd() never been called on completion of dnd operation
• 57bc209: 8301550: [8u] Enable additional linux build testing in GitHub
• 165ce6a: 8177560: @headful key can be removed from the tests for JavaSound
• 65b3bd9: 8280048: Missing comma in copyright header
• ... and 16 more: https://git.openjdk.org/jdk8u-dev/compare/75fd39f05e4c090192a5eca1fbdf2b6d1993fc4a...master

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

As you do not have Committer status in this project an existing Committer must agree to sponsor your change. Possible candidates are the reviewers of this PR (@yan-too, @gnu-andrew) but any other Committer may sponsor as well.

➡️ To flag this PR as ready for integration with the above commit message, type /integrate in a new comment. (Afterwards, your sponsor types /sponsor in a new comment to perform the integration).

[wkia]

/integrate

[openjdk]

@wkia
Your change (at version 740b5da) is now ready to be sponsored by a Committer.

[yan-too]

/sponsor

[openjdk]

Going to push as commit 3af19d3.
Since your change was applied there have been 26 commits pushed to the master branch:

• 8995356: 6734341: REGTEST fails: SelectionAutoscrollTest.html
• 11a96a7: 8156581: Cleanup of ProblemList.txt
• fd41600: 8205959: Do not restart close if errno is EINTR
• b71f59b: 8298027: Remove SCCS id's from awt jtreg tests
• fbaabf3: 8301620: [8u] some shell tests are passed but have unexpected operator errors
• 8c42e20: 8287109: Distrust.java failed with CertificateExpiredException
• 784f71f: 7124381: DragSourceListener.dragDropEnd() never been called on completion of dnd operation
• 57bc209: 8301550: [8u] Enable additional linux build testing in GitHub
• 165ce6a: 8177560: @headful key can be removed from the tests for JavaSound
• 65b3bd9: 8280048: Missing comma in copyright header
• ... and 16 more: https://git.openjdk.org/jdk8u-dev/compare/75fd39f05e4c090192a5eca1fbdf2b6d1993fc4a...master

Your commit was automatically rebased without conflicts.

[openjdk]

@yan-too @wkia Pushed as commit 3af19d3.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.