Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

8203485: [freetype] text rotated on 180 degrees is too narrow #208

Closed
wants to merge 1 commit into from

Conversation

xiangzhai
Copy link
Member

@xiangzhai xiangzhai commented Dec 12, 2022

Hi,

java/awt/Graphics2D/DrawString/RotTransText.java fail:

STDERR:
java.lang.RuntimeException: Ratio of blue to red is too great: 0.14015748031496064
        at RotTransText.testIt(RotTransText.java:102)
        at RotTransText.main(RotTransText.java:41)
        at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method)
        at sun.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:62)
        at sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43)
        at java.lang.reflect.Method.invoke(Method.java:498)
        at com.sun.javatest.regtest.agent.MainWrapper$MainThread.run(MainWrapper.java:127)
        at java.lang.Thread.run(Thread.java:750)

And JDK-8203485: [freetype] text rotated on 180 degrees is too narrow fix the issue.

The patch applies clean except manually change the source file path:

  • jdk/src/share/native/sun/font/freetypeScaler.c
  • jdk/test/java/awt/font/Rotate/RotatedTextTest.java

Tested jtreg tier1~3 for fastdebug/release.

Thanks,
Leslie Zhai


Progress

  • Change must be properly reviewed (1 review required, with at least 1 Reviewer)
  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue

Issue

  • JDK-8203485: [freetype] text rotated on 180 degrees is too narrow

Reviewers

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk8u-dev pull/208/head:pull/208
$ git checkout pull/208

Update a local copy of the PR:
$ git checkout pull/208
$ git pull https://git.openjdk.org/jdk8u-dev pull/208/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 208

View PR using the GUI difftool:
$ git pr show -t 208

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk8u-dev/pull/208.diff

@bridgekeeper
Copy link

bridgekeeper bot commented Dec 12, 2022

👋 Welcome back lzhai! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk openjdk bot changed the title Backport db67279f08b2db148958a4faafd19a0d50ff8742 8203485: [freetype] text rotated on 180 degrees is too narrow Dec 12, 2022
@openjdk
Copy link

openjdk bot commented Dec 12, 2022

This backport pull request has now been updated with issue from the original commit.

@openjdk openjdk bot added backport rfr Pull request is ready for review labels Dec 12, 2022
@mlbridge
Copy link

mlbridge bot commented Dec 12, 2022

Webrevs

@mrserb
Copy link
Member

mrserb commented Dec 12, 2022

The change looks fine, but let me additionally test this patch.

@xiangzhai
Copy link
Member Author

Hi @mrserb

The change looks fine, but let me additionally test this patch.

Do I need to trigger another Pre-submit tests or jtreg tier>3?

Thanks,
Leslie Zhai

@mrserb
Copy link
Member

mrserb commented Dec 18, 2022

Do I need to trigger another Pre-submit tests or jtreg tier>3?

No, I'll run them separately.

@mrserb
Copy link
Member

mrserb commented Jan 2, 2023

Looks fine. Please check that the fix for JDK-8233006 need to be backported or not. It reworked this code as well.

@openjdk
Copy link

openjdk bot commented Jan 2, 2023

@xiangzhai This change now passes all automated pre-integration checks.

After integration, the commit message for the final commit will be:

8203485: [freetype] text rotated on 180 degrees is too narrow

Reviewed-by: serb

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 27 new commits pushed to the master branch:

  • c5751e6: 8229182: [TESTBUG] runtime/containers/docker/TestMemoryAwareness.java test fails on SLES12
  • 47090d6: 8297996: [8u] generated images are broken due to renaming of MSVC runtime DLL's
  • b4a745d: 8284977: MetricsTesterCgroupV2.getLongValueEntryFromFile fails when named value doesn't exist
  • b4ef3d3: 8292083: Detected container memory limit may exceed physical machine memory
  • 78cdc41: 8234484: Add ability to configure third port for remote JMX
  • 06546d7: 8284102: [TESTBUG] [11u] Retroactively add regression test for JDK-8272124
  • 9f76da9: 8284756: [11u] Remove unused isUseContainerSupport in CgroupV1Subsystem
  • d6101df: 8254717: isAssignableFrom checks in KeyFactorySpi.engineGetKeySpec appear to be backwards
  • 99ff02e: 8266391: Replace use of reflection in jdk.internal.platform.Metrics
  • 0662db2: 8252957: Wrong comment in CgroupV1Subsystem::cpu_quota
  • ... and 17 more: https://git.openjdk.org/jdk8u-dev/compare/362cf7628b73f4112bee464cea52a8a29e6671ce...master

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

As you do not have Committer status in this project an existing Committer must agree to sponsor your change. Possible candidates are the reviewers of this PR (@mrserb) but any other Committer may sponsor as well.

➡️ To flag this PR as ready for integration with the above commit message, type /integrate in a new comment. (Afterwards, your sponsor types /sponsor in a new comment to perform the integration).

@openjdk openjdk bot added the ready Pull request is ready to be integrated label Jan 2, 2023
@xiangzhai
Copy link
Member Author

/integrate

@openjdk openjdk bot added the sponsor Pull request is ready to be sponsored label Jan 3, 2023
@openjdk
Copy link

openjdk bot commented Jan 3, 2023

@xiangzhai
Your change (at version 4027d7c) is now ready to be sponsored by a Committer.

@xiangzhai
Copy link
Member Author

Please check that the fix for JDK-8233006 need to be backported or not. It reworked this code as well.

Yes! java/awt/font/Rotate/RotatedSyntheticBoldTest.java backported is still reproducible. And I am running jtreg test.

Thanks,
Leslie Zhai

@mrserb
Copy link
Member

mrserb commented Jan 6, 2023

/integrate

You need to get an approval in JBS before integration.

@xiangzhai
Copy link
Member Author

Hi @mrserb

You need to get an approval in JBS before integration.

I added jdk8u-fix-request label back. Please point out my fault.

Thanks,
Leslie Zhai

@phohensee
Copy link
Member

/sponsor

@openjdk
Copy link

openjdk bot commented Jan 17, 2023

Going to push as commit 014f21f.
Since your change was applied there have been 36 commits pushed to the master branch:

  • a5c3ebe: 8299439: java/text/Format/NumberFormat/CurrencyFormat.java fails for hr_HR
  • 9d954b9: 8289695: [TESTBUG] TestMemoryAwareness.java fails on cgroups v2 and crun
  • 5a3fc18: 8299804: Fix non-portable code in hotspot shell tests in 8u
  • 1694a3a: 8296239: ISO 4217 Amendment 174 Update
  • 7c51dae: 8294307: ISO 4217 Amendment 173 Update
  • ca68579: 8289549: ISO 4217 Amendment 172 Update
  • 65fcf61: 8293472: Incorrect container resource limit detection if manual cgroup fs mounts present
  • 0f698da: 8299548: Fix hotspot/test/runtime/Metaspace/MaxMetaspaceSizeTest.java in 8u
  • 7ad517d: 8283277: ISO 4217 Amendment 171 Update
  • c5751e6: 8229182: [TESTBUG] runtime/containers/docker/TestMemoryAwareness.java test fails on SLES12
  • ... and 26 more: https://git.openjdk.org/jdk8u-dev/compare/362cf7628b73f4112bee464cea52a8a29e6671ce...master

Your commit was automatically rebased without conflicts.

@openjdk openjdk bot added the integrated Pull request has been integrated label Jan 17, 2023
@openjdk openjdk bot closed this Jan 17, 2023
@openjdk openjdk bot removed ready Pull request is ready to be integrated rfr Pull request is ready for review sponsor Pull request is ready to be sponsored labels Jan 17, 2023
@openjdk
Copy link

openjdk bot commented Jan 17, 2023

@phohensee @xiangzhai Pushed as commit 014f21f.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

@xiangzhai xiangzhai deleted the 8203485 branch January 18, 2023 01:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport integrated Pull request has been integrated
3 participants