Skip to content

Conversation

@mrserb
Copy link
Member

@mrserb mrserb commented Mar 24, 2022

Hi all,
This pull request contains a backport of commit 06b33a0a from the openjdk/jdk repository.
The commit being backported was authored by Sergey Bylokhov on 4 Feb 2021 and was reviewed by Alexander Zvegintsev and Prasanta Sadhukhan.

The new test failed before and works fine after the fix. No new issues were found by the java_desktop tests.
To apply the patch I had to change the paths and some patch context. The changed lines are the same.

Thanks!


Progress

  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue
  • Change must be properly reviewed

Issue

  • JDK-8261107: ArrayIndexOutOfBoundsException in the ICC_Profile.getInstance(InputStream)

Reviewers

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.java.net/jdk8u-dev pull/21/head:pull/21
$ git checkout pull/21

Update a local copy of the PR:
$ git checkout pull/21
$ git pull https://git.openjdk.java.net/jdk8u-dev pull/21/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 21

View PR using the GUI difftool:
$ git pr show -t 21

Using diff file

Download this PR as a diff file:
https://git.openjdk.java.net/jdk8u-dev/pull/21.diff

@bridgekeeper
Copy link

bridgekeeper bot commented Mar 24, 2022

👋 Welcome back serb! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk openjdk bot changed the title Backport 06b33a0ad78d1577711af22020cf5fdf25112523 8261107: ArrayIndexOutOfBoundsException in the ICC_Profile.getInstance(InputStream) Mar 24, 2022
@openjdk
Copy link

openjdk bot commented Mar 24, 2022

This backport pull request has now been updated with issue from the original commit.

@openjdk openjdk bot added the backport Port of a pull request already in a different code base label Mar 24, 2022
@mrserb mrserb marked this pull request as ready for review March 24, 2022 03:55
@openjdk openjdk bot added the rfr Pull request is ready for review label Mar 24, 2022
@mlbridge
Copy link

mlbridge bot commented Mar 24, 2022

Webrevs

Copy link
Member

@phohensee phohensee left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lgtm.

@openjdk
Copy link

openjdk bot commented Mar 29, 2022

@mrserb This change now passes all automated pre-integration checks.

After integration, the commit message for the final commit will be:

8261107: ArrayIndexOutOfBoundsException in the ICC_Profile.getInstance(InputStream)

Reviewed-by: phh

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 1 new commit pushed to the master branch:

  • f8a6695: 8274658: ISO 4217 Amendment 170 Update

Please see this link for an up-to-date comparison between the source branch of this pull request and the master branch.
As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

@openjdk openjdk bot added the ready Pull request is ready to be integrated label Mar 29, 2022
@mrserb
Copy link
Member Author

mrserb commented Apr 7, 2022

/integrate

1 similar comment
@mrserb
Copy link
Member Author

mrserb commented Apr 7, 2022

/integrate

@openjdk
Copy link

openjdk bot commented Apr 7, 2022

Going to push as commit b249159.
Since your change was applied there have been 5 commits pushed to the master branch:

  • 10029f7: 8253424: Add support for running pre-submit testing using GitHub Actions
  • 62bbb3e: 8281814: Debuginfo.diz contains redundant build path after backport JDK-8025936
  • c5ca29f: 8255239: The timezone of the hs_err_pid log file is corrupted in Japanese locale
  • e403fd5: 8274751: Drag And Drop hangs on Windows
  • f8a6695: 8274658: ISO 4217 Amendment 170 Update

Your commit was automatically rebased without conflicts.

@openjdk openjdk bot added the integrated Pull request has been integrated label Apr 7, 2022
@openjdk openjdk bot closed this Apr 7, 2022
@openjdk openjdk bot removed ready Pull request is ready to be integrated rfr Pull request is ready for review labels Apr 7, 2022
@openjdk
Copy link

openjdk bot commented Apr 7, 2022

@mrserb Pushed as commit b249159.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

@openjdk
Copy link

openjdk bot commented Apr 7, 2022

@mrserb The command integrate can only be used in open pull requests.

@mrserb mrserb deleted the mrserb-backport-06b33a0a branch April 7, 2022 23:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

backport Port of a pull request already in a different code base integrated Pull request has been integrated

Development

Successfully merging this pull request may close these issues.

2 participants