Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

8254717: isAssignableFrom checks in KeyFactorySpi.engineGetKeySpec appear to be backwards #211

Closed
wants to merge 1 commit into from

Conversation

phohensee
Copy link
Member

@phohensee phohensee commented Dec 14, 2022

Backport for Oracle parity from 11u is not clean.

  1. Copyright date mismatch in P11SecretKeyFactory.java.
  2. XDHKeyFactory.java does not exist in 8u.
  3. In KeyFactoryGetKeySpecForInvalidSpec.java, class FakeX509Spec does not include a (byte[], String) constructor since in 8u, X509EncodedKeySpec does not.

Progress

  • Change must be properly reviewed (1 review required, with at least 1 Reviewer)
  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue

Issue

  • JDK-8254717: isAssignableFrom checks in KeyFactorySpi.engineGetKeySpec appear to be backwards

Reviewers

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk8u-dev pull/211/head:pull/211
$ git checkout pull/211

Update a local copy of the PR:
$ git checkout pull/211
$ git pull https://git.openjdk.org/jdk8u-dev pull/211/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 211

View PR using the GUI difftool:
$ git pr show -t 211

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk8u-dev/pull/211.diff

@bridgekeeper
Copy link

bridgekeeper bot commented Dec 14, 2022

👋 Welcome back phh! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk openjdk bot changed the title Backport a777e82cd81fb5f02b09c4917b2a44f94c603939 8254717: isAssignableFrom checks in KeyFactorySpi.engineGetKeySpec appear to be backwards Dec 14, 2022
@openjdk
Copy link

openjdk bot commented Dec 14, 2022

This backport pull request has now been updated with issue from the original commit.

@openjdk openjdk bot added backport rfr Pull request is ready for review labels Dec 14, 2022
@mlbridge
Copy link

mlbridge bot commented Dec 14, 2022

Webrevs

Copy link
Member

@gnu-andrew gnu-andrew left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Patch looks good to me.

We need to make sure we follow this up with JDK-8263404

@openjdk
Copy link

openjdk bot commented Dec 14, 2022

@phohensee This change now passes all automated pre-integration checks.

After integration, the commit message for the final commit will be:

8254717: isAssignableFrom checks in KeyFactorySpi.engineGetKeySpec appear to be backwards

Reviewed-by: andrew

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been no new commits pushed to the master branch. If another commit should be pushed before you perform the /integrate command, your PR will be automatically rebased. If you prefer to avoid any potential automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

@openjdk openjdk bot added the ready Pull request is ready to be integrated label Dec 14, 2022
@phohensee
Copy link
Member Author

Thanks for the review, Andrew, and will do.

@gnu-andrew
Copy link
Member

Ok, if you want to add jdk8u-fix-request to the bug, I'll approve :)

@phohensee
Copy link
Member Author

Done. I'd been waiting until I had time for JDK-8263404, which latter I'm testing now.

@phohensee
Copy link
Member Author

Posted #214.

@gnu-andrew
Copy link
Member

Ok, if you want to add jdk8u-fix-request to the bug, I'll approve :)

Done. I'd been waiting until I had time for JDK-8263404, which latter I'm testing now.

No problem, just wanted to make sure you weren't waiting on me or anything. I've approved it now.

@phohensee
Copy link
Member Author

Posted #214.

@phohensee
Copy link
Member Author

/integrate

Got approval.

@openjdk
Copy link

openjdk bot commented Dec 18, 2022

Going to push as commit d6101df.
Since your change was applied there have been 11 commits pushed to the master branch:

  • 99ff02e: 8266391: Replace use of reflection in jdk.internal.platform.Metrics
  • 0662db2: 8252957: Wrong comment in CgroupV1Subsystem::cpu_quota
  • d039c8d: 8291570: [TESTBUG] Part of JDK-8250984 absent from 11u
  • d7b14be: 8262379: Add regression test for JDK-8257746
  • 1b04ffe: 8254001: [Metrics] Enhance parsing of cgroup interface files for version detection
  • b2619cf: 8253797: [cgroups v2] Account for the fact that swap accounting is disabled on some systems
  • 4dfc742: 8253939: [TESTBUG] Increase coverage of the cgroups detection code
  • d2df91d: 8245543: Cgroups: Incorrect detection logic on some systems (still reproducible)
  • 2bee645: 8253435: Cgroup: 'stomping of _mount_path' crash if manually mounted cpusets exist
  • d9db01c: 8252359: HotSpot Not Identifying it is Running in a Container
  • ... and 1 more: https://git.openjdk.org/jdk8u-dev/compare/537ff942252e33831446d285800e5765a84bc19c...master

Your commit was automatically rebased without conflicts.

@openjdk openjdk bot added the integrated Pull request has been integrated label Dec 18, 2022
@openjdk openjdk bot closed this Dec 18, 2022
@openjdk openjdk bot removed ready Pull request is ready to be integrated rfr Pull request is ready for review labels Dec 18, 2022
@openjdk
Copy link

openjdk bot commented Dec 18, 2022

@phohensee Pushed as commit d6101df.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport integrated Pull request has been integrated
2 participants